pop3: Removed bytecountp from the per-request structure

Removed this pointer to a downloaded bytes counter because it was set in
pop3_init() to point to the same variable the transfer functions keep
the count in (k->bytecount), effectively making the code in transfer.c
"*k->bytecountp = k->bytecount" a no-op.
This commit is contained in:
Steve Holme
2013-02-25 21:46:37 +00:00
parent 005ad9e60d
commit a390454728
2 changed files with 1 additions and 5 deletions

View File

@@ -1115,7 +1115,7 @@ static CURLcode pop3_state_command_resp(struct connectdata *conn,
pop3c->strip = 2; pop3c->strip = 2;
/* POP3 download */ /* POP3 download */
Curl_setup_transfer(conn, FIRSTSOCKET, -1, FALSE, pop3->bytecountp, Curl_setup_transfer(conn, FIRSTSOCKET, -1, FALSE, NULL,
-1, NULL); /* no upload here */ -1, NULL); /* no upload here */
if(pp->cache) { if(pp->cache) {
@@ -1294,9 +1294,6 @@ static CURLcode pop3_init(struct connectdata *conn)
return CURLE_OUT_OF_MEMORY; return CURLE_OUT_OF_MEMORY;
} }
/* Get some initial data into the pop3 struct */
pop3->bytecountp = &data->req.bytecount;
return CURLE_OK; return CURLE_OK;
} }

View File

@@ -57,7 +57,6 @@ typedef enum {
perhaps the SessionHandle is changed between the times the connection is perhaps the SessionHandle is changed between the times the connection is
used. */ used. */
struct POP3 { struct POP3 {
curl_off_t *bytecountp;
curl_pp_transfer transfer; curl_pp_transfer transfer;
char *id; /* Message ID */ char *id; /* Message ID */
char *custom; /* Custom Request */ char *custom; /* Custom Request */