generic-library/curl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

do_sec_send: remove dead code

Browse Source 
Coverity CID 1241951. The condition 'len >= 0' would always be true at
that point and thus not necessary to check for.
This commit is contained in:
Daniel Stenberg
2014-10-08 12:48:06 +02:00
parent b90f6e87cf
commit 87c8e00b7a
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
lib/security.c
View File

@@ -332,7 +332,6 @@ static void do_sec_send(struct connectdata *conn, curl_socket_t fd,
static ssize_t sec_write(struct connectdata *conn, curl_socket_t fd, static ssize_t sec_write(struct connectdata *conn, curl_socket_t fd,
const char *buffer, size_t length) const char *buffer, size_t length)
{ {
/* FIXME: Check for overflow */
ssize_t tx = 0, len = conn->buffer_size; ssize_t tx = 0, len = conn->buffer_size;
len -= conn->mech->overhead(conn->app_data, conn->data_prot, len -= conn->mech->overhead(conn->app_data, conn->data_prot,
@@ -340,10 +339,9 @@ static ssize_t sec_write(struct connectdata *conn, curl_socket_t fd,
if(len <= 0) if(len <= 0)
len = length; len = length;
while(length) { while(length) {
if(len >= 0 || length < (size_t)len) { if(length < (size_t)len)
/* FIXME: Check for overflow. */
len = length; len = length;
}
do_sec_send(conn, fd, buffer, curlx_sztosi(len)); do_sec_send(conn, fd, buffer, curlx_sztosi(len));
length -= len; length -= len;
buffer += len; buffer += len;