generic-library/curl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

- Fixed memory leak in the SCP/SFTP code as it never freed the knownhosts

Browse Source 
data!
This commit is contained in:
Daniel Stenberg 2009-10-18 01:11:25 +00:00
parent e5ee822745
commit 86cec97b22
3 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
CHANGES
View File

@ -7,6 +7,9 @@
Changelog Changelog
Daniel Stenberg (18 Oct 2009) Daniel Stenberg (18 Oct 2009)
- Fixed memory leak in the SCP/SFTP code as it never freed the knownhosts
data!
- John Dennis filed bug report #2873666 - John Dennis filed bug report #2873666
(http://curl.haxx.se/bug/view.cgi?id=2873666) which identified a problem (http://curl.haxx.se/bug/view.cgi?id=2873666) which identified a problem
which made libcurl loop infinitely when given incorrect credentials when which made libcurl loop infinitely when given incorrect credentials when

1
RELEASE-NOTES
View File

@ -38,6 +38,7 @@ This release includes the following bugfixes:
o invalid file name characters handling on Windows o invalid file name characters handling on Windows
o double close() on the primary socket with libcurl-NSS o double close() on the primary socket with libcurl-NSS
o GSS negotiate infinite loop on bad credentials o GSS negotiate infinite loop on bad credentials
o memory leak in SCP/SFTP connections
This release includes the following known bugs: This release includes the following known bugs:

10
lib/ssh.c
View File

@ -2204,6 +2204,13 @@ static CURLcode ssh_statemach_act(struct connectdata *conn, bool *block)
break; break;
case SSH_SESSION_FREE: case SSH_SESSION_FREE:
#ifdef HAVE_LIBSSH2_KNOWNHOST_API
if(sshc->kh) {
libssh2_knownhost_free(sshc->kh);
sshc->kh = NULL;
}
#endif
if(sshc->ssh_session) { if(sshc->ssh_session) {
rc = libssh2_session_free(sshc->ssh_session); rc = libssh2_session_free(sshc->ssh_session);
if(rc == LIBSSH2_ERROR_EAGAIN) { if(rc == LIBSSH2_ERROR_EAGAIN) {
@ -2565,11 +2572,12 @@ static CURLcode ssh_do(struct connectdata *conn, bool *done)
static CURLcode scp_disconnect(struct connectdata *conn) static CURLcode scp_disconnect(struct connectdata *conn)
{ {
CURLcode result = CURLE_OK; CURLcode result = CURLE_OK;
struct ssh_conn *ssh = &conn->proto.sshc;
Curl_safefree(conn->data->state.proto.ssh); Curl_safefree(conn->data->state.proto.ssh);
conn->data->state.proto.ssh = NULL; conn->data->state.proto.ssh = NULL;
if(conn->proto.sshc.ssh_session) { if(ssh->ssh_session) {
/* only if there's a session still around to use! */ /* only if there's a session still around to use! */
state(conn, SSH_SESSION_DISCONNECT); state(conn, SSH_SESSION_DISCONNECT);