generic-library/curl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

pop3: Fixed the issue of having to supply the user name for all requests

Browse Source 
Previously it wasn't possible to connect to POP3 and not specify the
user name as a CURLE_ACCESS_DENIED error would be returned. This error
occurred because USER would be sent to the server with a blank user name
if no mailbox user was specified as the server would reply with -ERR.

This wasn't a problem prior to the 7.26.0 release but with the
introduction of custom commands the user and/or application developer
might want to issue a CAPA command without having to log in as a
specific mailbox user.

Additionally this fix won't send the newly introduced AUTH command if no
user name is specified.
This commit is contained in:
Steve Holme 2012-06-02 22:11:37 +01:00
parent 1fa2af5136
commit 69ba0da827
2 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
RELEASE-NOTES
View File

@ -14,6 +14,7 @@ This release includes the following changes:
This release includes the following bugfixes: This release includes the following bugfixes:
o pop3: Fixed the issue of having to supply the user name for all requests
o o
This release includes the following known bugs: This release includes the following known bugs:

10
lib/pop3.c
View File

@ -305,12 +305,20 @@ static void state(struct connectdata *conn, pop3state newstate)
static CURLcode pop3_state_auth(struct connectdata *conn) static CURLcode pop3_state_auth(struct connectdata *conn)
{ {
CURLcode result; CURLcode result = CURLE_OK;
struct pop3_conn *pop3c = &conn->proto.pop3c; struct pop3_conn *pop3c = &conn->proto.pop3c;
pop3c->authmechs = 0; /* No known authentication mechanisms yet */ pop3c->authmechs = 0; /* No known authentication mechanisms yet */
pop3c->authused = 0; /* Clear the authentication mechanism used */ pop3c->authused = 0; /* Clear the authentication mechanism used */
/* Check we have a username and password to authenticate with and end the
connect phase if we don't */
if(!conn->bits.user_passwd) {
state(conn, SMTP_STOP);
return result;
}
/* send AUTH */ /* send AUTH */
result = Curl_pp_sendf(&pop3c->pp, "AUTH"); result = Curl_pp_sendf(&pop3c->pp, "AUTH");