generic-library/curl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

cleanup: general removal of TODO (and similar) comments

Browse Source 
They tend to never get updated anyway so they're frequently inaccurate
and we never go back to revisit them anyway. We document issues to work
on properly in KNOWN_BUGS and TODO instead.
This commit is contained in:
Daniel Stenberg
2015-11-13 16:15:26 +01:00
parent 86e2197337
commit 64e959ffe3
19 changed files with 26 additions and 97 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
lib/ssh.c
View File

@@ -296,10 +296,6 @@ static CURLcode libssh2_session_error_to_CURLE(int err)
return CURLE_AGAIN;
}
/* TODO: map some more of the libssh2 errors to the more appropriate CURLcode
error code, and possibly add a few new SSH-related one. We must however
not return or even depend on libssh2 errors in the public libcurl API */
return CURLE_SSH;
}
@@ -2824,10 +2820,8 @@ static CURLcode ssh_connect(struct connectdata *conn, bool *done)
if(data->set.str[STRING_SSH_KNOWNHOSTS]) {
int rc;
ssh->kh = libssh2_knownhost_init(ssh->ssh_session);
if(!ssh->kh) {
/* eeek. TODO: free the ssh_session! */
if(!ssh->kh)
return CURLE_FAILED_INIT;
}
/* read all known hosts from there */
rc = libssh2_knownhost_readfile(ssh->kh,
@@ -2964,10 +2958,8 @@ static CURLcode ssh_done(struct connectdata *conn, CURLcode status)
if(!status) {
/* run the state-machine
TODO: when the multi interface is used, this _really_ should be using
the ssh_multi_statemach function but we have no general support for
non-blocking DONE operations, not in the multi state machine and with
Curl_done() invokes on several places in the code!
This should be using the ssh_multi_statemach function but we have no
support for non-blocking DONE operations!
*/
result = ssh_block_statemach(conn, FALSE);
}