Marked with TODO comments a number of problems in the Kerberos code detected

while investigating the issue in http://curl.haxx.se/mail/lib-2008-09/0262.html
I'm hesitant to fix them because I have no way of testing the result.
This commit is contained in:
Dan Fandrich
2008-11-02 05:01:39 +00:00
parent d098ab436d
commit 484d549ece
2 changed files with 8 additions and 1 deletions

View File

@@ -630,13 +630,16 @@ int Curl_read(struct connectdata *conn, /* connection data */
return -1;
#endif
if(nread < 0)
/* since it is negative and not EGAIN, it was a protocol-layer error */
/* since it is negative and not EAGAIN, it was a protocol-layer error */
return CURLE_RECV_ERROR;
}
else {
if(conn->sec_complete)
nread = Curl_sec_read(conn, sockfd, buffertofill,
bytesfromsocket);
/* TODO: Need to handle EAGAIN here somehow, similar to how it
* is done in Curl_read_plain, either right here or in Curl_sec_read
* itself. */
else {
int ret = Curl_read_plain(sockfd, buffertofill, bytesfromsocket,
&nread);