generic-library/curl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

curl_schannel.c: Fixed possible memory or handle leak

Browse Source 
First try to fix possible memory leaks, in this case:
Only connssl->ctxt xor onnssl->cred being initialized.
This commit is contained in:
Marc Hoersken
2014-10-04 18:24:23 +02:00
parent 8128db9ec1
commit 330346d51c
1 changed files with 20 additions and 20 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
lib/vtls/curl_schannel.c
View File

@@ -1145,29 +1145,29 @@ int Curl_schannel_shutdown(struct connectdata *conn, int sockindex)
" (bytes written: %zd)\n", curl_easy_strerror(code), written); " (bytes written: %zd)\n", curl_easy_strerror(code), written);
} }
} }
}
/* free SSPI Schannel API security context handle */ /* free SSPI Schannel API security context handle */
if(connssl->ctxt) { if(connssl->ctxt) {
infof(data, "schannel: clear security context handle\n"); infof(data, "schannel: clear security context handle\n");
s_pSecFn->DeleteSecurityContext(&connssl->ctxt->ctxt_handle); s_pSecFn->DeleteSecurityContext(&connssl->ctxt->ctxt_handle);
Curl_safefree(connssl->ctxt); Curl_safefree(connssl->ctxt);
}
/* free SSPI Schannel API credential handle */
if(connssl->cred) {
/* decrement the reference counter of the credential/session handle */
if(connssl->cred->refcount > 0) {
connssl->cred->refcount--;
infof(data, "schannel: decremented credential handle refcount = %d\n",
connssl->cred->refcount);
} }
/* free SSPI Schannel API credential handle */ /* if the handle was not cached and the refcount is zero */
if(connssl->cred) { if(!connssl->cred->cached && connssl->cred->refcount == 0) {
/* decrement the reference counter of the credential/session handle */ infof(data, "schannel: clear credential handle\n");
if(connssl->cred->refcount > 0) { s_pSecFn->FreeCredentialsHandle(&connssl->cred->cred_handle);
connssl->cred->refcount--; Curl_safefree(connssl->cred);
infof(data, "schannel: decremented credential handle refcount = %d\n",
connssl->cred->refcount);
}
/* if the handle was not cached and the refcount is zero */
if(!connssl->cred->cached && connssl->cred->refcount == 0) {
infof(data, "schannel: clear credential handle\n");
s_pSecFn->FreeCredentialsHandle(&connssl->cred->cred_handle);
Curl_safefree(connssl->cred);
}
} }
} }