- Jon Nelson found a regression that turned out to be a flaw in how libcurl

detects and uses proxies based on the environment variables. If the proxy
  was given as an explicit option it worked, but due to the setup order
  mistake proxies would not be used fine for a few protocols when picked up
  from '[protocol]_proxy'. Obviously this broke after 7.19.4. I now also added
  test case 1106 that verifies this functionality.

  (http://curl.haxx.se/bug/view.cgi?id=2913886)
This commit is contained in:
Daniel Stenberg
2009-12-14 23:16:09 +00:00
parent 2c9644b812
commit 3111701c38
5 changed files with 103 additions and 32 deletions

View File

@@ -63,7 +63,7 @@ EXTRA_DIST = test1 test108 test117 test127 test20 test27 test34 test46 \
test1089 test1090 test1091 test1092 test1093 test1094 test1095 test1096 \
test1097 test560 test561 test1098 test1099 test562 test563 test1100 \
test564 test1101 test1102 test1103 test1104 test299 test310 test311 \
test312 test1105 test565 test800
test312 test1105 test565 test800 test1106
filecheck:
@mkdir test-place; \

56
tests/data/test1106 Normal file
View File

@@ -0,0 +1,56 @@
<testcase>
<info>
<keywords>
FTP
CURLOPT_PORT
HTTP proxy
</keywords>
</info>
# Server-side
<reply>
<data nocheck="yes">
HTTP/1.1 200 OK swsclose
Date: Thu, 09 Nov 2010 14:49:00 GMT
Server: test-server/fake
Accept-Ranges: bytes
Content-Length: 6
hello
</data>
</reply>
# Client-side
<client>
<server>
http
</server>
<name>
FTP URL and with ftp_proxy environment variable set
</name>
<setenv>
ftp_proxy=http://%HOSTIP:%HTTPPORT/
</setenv>
# note that we need quotes around the URL below to make sure the shell doesn't
# treat the semicolon as a separator!
<command>
"ftp://%HOSTIP:23456/1106"
</command>
</client>
# Verify data after the test has been "shot"
<verify>
<strip>
^User-Agent:.*
</strip>
<protocol>
GET ftp://%HOSTIP:23456/1106 HTTP/1.1
Host: %HOSTIP:23456
Accept: */*
Proxy-Connection: Keep-Alive
</protocol>
</verify>
</testcase>