generic-library/curl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Andrew Wansink provided an NTLM bugfix: in the case the server sets the flag

Browse Source 
NTLMFLAG_NEGOTIATE_UNICODE, we need to filter it off because libcurl doesn't
unicode encode the strings it packs into the NTLM authenticate packet.
This commit is contained in:
Daniel Stenberg 2007-08-14 10:28:21 +00:00
parent 5cdcc2b3aa
commit 2f8f12e82e
3 changed files with 16 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
CHANGES
View File

@ -6,6 +6,11 @@
Changelog Changelog
Daniel S (14 August 2007)
- Andrew Wansink provided an NTLM bugfix: in the case the server sets the flag
NTLMFLAG_NEGOTIATE_UNICODE, we need to filter it off because libcurl doesn't
UNICODE encode the strings it packs into the NTLM authenticate packet.
Daniel S (11 August 2007) Daniel S (11 August 2007)
- Allen Pulsifer provided a patch that makes libcurl set the expected download - Allen Pulsifer provided a patch that makes libcurl set the expected download
size earlier when doing HTTP downloads, so that applications and the size earlier when doing HTTP downloads, so that applications and the

6
RELEASE-NOTES
View File

@ -36,8 +36,10 @@ This release includes the following bugfixes:
o AIX 4 and 5 get to use non-blocking sockets o AIX 4 and 5 get to use non-blocking sockets
o small POST with NTLM o small POST with NTLM
o resumed file:// transfers o resumed file:// transfers
o CURLOPT_DNS_CACHE_TIMEOUT and CURLOPT_DNS_USE_GLOBAL_CACHE are 64 bit "clean" o CURLOPT_DNS_CACHE_TIMEOUT and CURLOPT_DNS_USE_GLOBAL_CACHE are 64 bit
"clean"
o memory leak when handling compressed data streams from broken servers o memory leak when handling compressed data streams from broken servers
o no NTLM unicode response
This release includes the following known bugs: This release includes the following known bugs:
@ -61,6 +63,6 @@ advice from friends like these:
Daniel Cater, Colin Hogben, Jofell Gallardo, Daniel Johnson, Daniel Cater, Colin Hogben, Jofell Gallardo, Daniel Johnson,
Ralf S. Engelschall, James Housley, Chris Flerackers, Patrick Monnerat, Ralf S. Engelschall, James Housley, Chris Flerackers, Patrick Monnerat,
Jayesh A Shah, Greg Zavertnik, Peter O'Gorman, Greg Morse, Dmitriy Sergeyev, Jayesh A Shah, Greg Zavertnik, Peter O'Gorman, Greg Morse, Dmitriy Sergeyev,
Scott Cantor, Allen Pulsifer Scott Cantor, Allen Pulsifer, Andrew Wansink
Thanks! (and sorry if I forgot to mention someone) Thanks! (and sorry if I forgot to mention someone)

7
lib/http_ntlm.c
View File

@ -917,6 +917,13 @@ CURLcode Curl_output_ntlm(struct connectdata *conn,
useroff = domoff + domlen; useroff = domoff + domlen;
hostoff = useroff + userlen; hostoff = useroff + userlen;
/*
* In the case the server sets the flag NTLMFLAG_NEGOTIATE_UNICODE, we
* need to filter it off because libcurl doesn't UNICODE encode the
* strings it packs into the NTLM authenticate packet.
*/
ntlm->flags &= ~NTLMFLAG_NEGOTIATE_UNICODE;
/* Create the big type-3 message binary blob */ /* Create the big type-3 message binary blob */
size = snprintf((char *)ntlmbuf, sizeof(ntlmbuf), size = snprintf((char *)ntlmbuf, sizeof(ntlmbuf),
NTLMSSP_SIGNATURE "%c" NTLMSSP_SIGNATURE "%c"