ossl_seed: no more RAND_screen
RAND_screen() is slow, not thread-safe and not needed anymore since OpenSSL uses the thread-safe win32 CryptoAPI nowadays.
This commit is contained in:
10
lib/ssluse.c
10
lib/ssluse.c
@@ -225,7 +225,8 @@ static int ossl_seed(struct SessionHandle *data)
|
|||||||
/* If we get here, it means we need to seed the PRNG using a "silly"
|
/* If we get here, it means we need to seed the PRNG using a "silly"
|
||||||
approach! */
|
approach! */
|
||||||
#ifdef HAVE_RAND_SCREEN
|
#ifdef HAVE_RAND_SCREEN
|
||||||
/* if RAND_screen() is present, it was called during global init */
|
/* if RAND_screen() is present, this is windows and thus we assume that the
|
||||||
|
randomness is already taken care of */
|
||||||
nread = 100; /* just a value */
|
nread = 100; /* just a value */
|
||||||
#else
|
#else
|
||||||
{
|
{
|
||||||
@@ -685,13 +686,6 @@ int Curl_ossl_init(void)
|
|||||||
|
|
||||||
OpenSSL_add_all_algorithms();
|
OpenSSL_add_all_algorithms();
|
||||||
|
|
||||||
#ifdef HAVE_RAND_SCREEN
|
|
||||||
/* This one gets a random value by reading the currently shown screen.
|
|
||||||
RAND_screen() is not thread-safe according to OpenSSL devs - although not
|
|
||||||
mentioned in documentation. */
|
|
||||||
RAND_screen();
|
|
||||||
#endif
|
|
||||||
|
|
||||||
return 1;
|
return 1;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
Reference in New Issue
Block a user