generic-library/curl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

fix potential buffer overflow in test-server logging function

Browse Source
This commit is contained in:
Yang Tse 2008-09-26 00:17:01 +00:00
parent 9e9f70a693
commit 2d1f798d14
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tests/server/util.c
View File

@ -62,7 +62,7 @@ const struct in6_addr in6addr_any = {{ IN6ADDR_ANY_INIT }};
void logmsg(const char *msg, ...)
{
va_list ap;
char buffer[512]; /* possible overflow if you pass in a huge string */
char buffer[2048 + 1];
FILE *logfp;
int error;
struct timeval tv;
@ -80,10 +80,10 @@ void logmsg(const char *msg, ...)
now = localtime(&sec); /* not multithread safe but we don't care */
snprintf(timebuf, sizeof(timebuf), "%02d:%02d:%02d.%06ld",
now->tm_hour, now->tm_min, now->tm_sec, tv.tv_usec);
(int)now->tm_hour, (int)now->tm_min, (int)now->tm_sec, (long)tv.tv_usec);
va_start(ap, msg);
vsprintf(buffer, msg, ap);
vsnprintf(buffer, sizeof(buffer), msg, ap);
va_end(ap);
logfp = fopen(serverlogfile, "a");