generic-library/curl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

tool_operate: Don't sanitize --output path (Windows)

Browse Source 
Due to path separators being incorrectly sanitized in --output
pathnames, eg -o c:\foo => c__foo

This is a partial revert of 3017d8a until I write a proper fix. The
remote-name will continue to be sanitized, but if the user specified an
--output with string replacement (#1, #2, etc) that data is unsanitized
until I finish a fix.

Bug: https://github.com/bagder/curl/issues/624
Reported-by: Octavio Schroeder
This commit is contained in:
Jay Satiro 2016-02-01 04:11:46 -05:00
parent 96596334c8
commit 2b6dadc52d
1 changed files with 0 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/tool_operate.c
View File

@ -563,17 +563,6 @@ static CURLcode operate_do(struct GlobalConfig *global,
char *storefile = outfile; char *storefile = outfile;
result = glob_match_url(&outfile, storefile, urls); result = glob_match_url(&outfile, storefile, urls);
Curl_safefree(storefile); Curl_safefree(storefile);
#if defined(MSDOS) || defined(WIN32)
if(!result) {
result = sanitize_file_name(&outfile);
if(result) {
Curl_safefree(outfile);
goto show_error;
}
}
#endif /* MSDOS || WIN32 */
if(result) { if(result) {
/* bad globbing */ /* bad globbing */
warnf(config->global, "bad output glob!\n"); warnf(config->global, "bad output glob!\n");