generic-library/curl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

pipeline: remove print_pipeline()

Browse Source 
This is a debug function only and serves no purpose in production code,
it only slows things down. I left the code #ifdef'ed for possible future
pipeline debugging.

Also, this was a global function without proper namespace usage.

Reported-by: He Qin
Bug: http://curl.haxx.se/bug/view.cgi?id=1320
This commit is contained in:
Daniel Stenberg 2014-01-03 12:02:56 +01:00
parent 3529162405
commit 231b23acbb
2 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
lib/pipeline.c
View File

@ -6,7 +6,7 @@
* \___|\___/|_| \_\_____| * \___|\___/|_| \_\_____|
* *
* Copyright (C) 2013, Linus Nielsen Feltzing, <linus@haxx.se> * Copyright (C) 2013, Linus Nielsen Feltzing, <linus@haxx.se>
* Copyright (C) 2013, Daniel Stenberg, <daniel@haxx.se>, et al. * Copyright (C) 2013-2014, Daniel Stenberg, <daniel@haxx.se>, et al.
* *
* This software is licensed as described in the file COPYING, which * This software is licensed as described in the file COPYING, which
* you should have received as part of this distribution. The terms * you should have received as part of this distribution. The terms
@ -118,7 +118,9 @@ CURLcode Curl_add_handle_to_pipeline(struct SessionHandle *handle,
Curl_expire(conn->send_pipe->head->ptr, 1); Curl_expire(conn->send_pipe->head->ptr, 1);
} }
#if 0 /* enable for pipeline debugging */
print_pipeline(conn); print_pipeline(conn);
#endif
return rc; return rc;
} }
@ -309,7 +311,7 @@ CURLMcode Curl_pipeline_set_server_blacklist(char **servers,
return CURLM_OK; return CURLM_OK;
} }
#if 0
void print_pipeline(struct connectdata *conn) void print_pipeline(struct connectdata *conn)
{ {
struct curl_llist_element *curr; struct curl_llist_element *curr;
@ -331,3 +333,5 @@ void print_pipeline(struct connectdata *conn)
} }
} }
} }
#endif

4
lib/pipeline.h
View File

@ -7,7 +7,7 @@
* | (__| |_| | _ <| |___ * | (__| |_| | _ <| |___
* \___|\___/|_| \_\_____| * \___|\___/|_| \_\_____|
* *
* Copyright (C) 2013, Linus Nielsen Feltzing, <linus@haxx.se> * Copyright (C) 2013 - 2014, Linus Nielsen Feltzing, <linus@haxx.se>
* *
* This software is licensed as described in the file COPYING, which * This software is licensed as described in the file COPYING, which
* you should have received as part of this distribution. The terms * you should have received as part of this distribution. The terms
@ -41,6 +41,4 @@ bool Curl_pipeline_server_blacklisted(struct SessionHandle *handle,
CURLMcode Curl_pipeline_set_server_blacklist(char **servers, CURLMcode Curl_pipeline_set_server_blacklist(char **servers,
struct curl_llist **list_ptr); struct curl_llist **list_ptr);
void print_pipeline(struct connectdata *conn);
#endif /* HEADER_CURL_PIPELINE_H */ #endif /* HEADER_CURL_PIPELINE_H */