generic-library/curl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

http2: Fix missing nghttp2_session_send call in Curl_http2_switched

Browse Source 
Previously in Curl_http2_switched, we called nghttp2_session_mem_recv to
parse incoming data which were already received while curl was handling
upgrade.  But we didn't call nghttp2_session_send, and it led to make
curl not send any response to the received frames.  Most likely, we
received SETTINGS from server at this point, so we missed opportunity to
send SETTINGS + ACK.  This commit adds missing nghttp2_session_send call
in Curl_http2_switched to fix this issue.

Bug: https://github.com/bagder/curl/issues/192
Reported-by: Stefan Eissing
This commit is contained in:
Tatsuhiro Tsujikawa
2015-04-02 00:28:58 +09:00
committed by Daniel Stenberg
parent 2685041a5c
commit 21e82bd635
2 changed files with 11 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
tests/data/test1801
View File

@@ -23,7 +23,6 @@ lies!
<datacheck>
HTTP/1.1 101 Switching!
</datacheck>
# listen to the upgrade request!
@@ -62,9 +61,9 @@ Upgrade: %H2CVER
HTTP2-Settings: AAMAAABkAAQAAP__
</protocol>
# nothing is returned, because no HTTP/2 data nor headers was handled
# CURLE_HTTP2: Send failure: Broken pipe
<errorcode>
56
16
</errorcode>
</verify>
</testcase>