generic-library/curl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

tftpd: avoid buffer overflow report from glibc

Browse Source
This commit is contained in:
Paul Howarth 2010-12-17 19:07:45 +01:00 committed by Kamil Dudka
parent 76c54bd129
commit 1df74d886d
1 changed files with 4 additions and 2 deletions

6
tests/server/tftpd.c

@ -1291,9 +1291,11 @@ static void nak(int error)
pe->e_msg = strerror(error - 100); pe->e_msg = strerror(error - 100);
tp->th_code = EUNDEF; /* set 'undef' errorcode */ tp->th_code = EUNDEF; /* set 'undef' errorcode */
} }
strcpy(tp->th_msg, pe->e_msg);
length = (int)strlen(pe->e_msg); length = (int)strlen(pe->e_msg);
tp->th_msg[length] = '\0';
/* we use memcpy() instead of strcpy() in order to avoid buffer overflow
* report from glibc with FORTIFY_SOURCE */
memcpy(tp->th_msg, pe->e_msg, length + 1);
length += 5; length += 5;
if (swrite(peer, &buf.storage[0], length) != length) if (swrite(peer, &buf.storage[0], length) != length)
logmsg("nak: fail\n"); logmsg("nak: fail\n");