generic-library/curl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Bug report #1815530 (http://curl.haxx.se/bug/view.cgi?id=1815530) points out

Browse Source 
that specifying a proxy with a trailing slash didn't work (unless it also
contained a port number).
This commit is contained in:
Daniel Stenberg 2007-10-22 09:25:45 +00:00
parent 053654dc4d
commit 1056dc9a26
3 changed files with 20 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
CHANGES
View File

@ -6,6 +6,11 @@
Changelog Changelog
Daniel S (22 October 2007)
- Bug report #1815530 (http://curl.haxx.se/bug/view.cgi?id=1815530) points out
that specifying a proxy with a trailing slash didn't work (unless it also
contained a port number).
Patrick M (15 October 2007) Patrick M (15 October 2007)
- Fixed the dynamic CURLOPT_POSTFIELDS problem: this option is now static again - Fixed the dynamic CURLOPT_POSTFIELDS problem: this option is now static again
and option CURLOPT_COPYPOSTFIELDS has been added to support dynamic mode. and option CURLOPT_COPYPOSTFIELDS has been added to support dynamic mode.

2
RELEASE-NOTES
View File

@ -36,6 +36,8 @@ This release includes the following bugfixes:
o handles chunked-encoded CONNECT responses o handles chunked-encoded CONNECT responses
o misuse of ares_timeout() result o misuse of ares_timeout() result
o --local-port on TFTP transfers o --local-port on TFTP transfers
o specifying a proxy with a trailing slash didn't work (unless it also
contained a port number)
This release includes the following known bugs: This release includes the following known bugs:

18
lib/url.c
View File

@ -3339,10 +3339,17 @@ static CURLcode parse_proxy(struct SessionHandle *data,
/* now set the local port number */ /* now set the local port number */
conn->port = atoi(prox_portno); conn->port = atoi(prox_portno);
} }
else if(data->set.proxyport) { else {
/* None given in the proxy string, then get the default one if it is /* without a port number after the host name, some people seem to use
given */ a slash so we strip everything from the first slash */
conn->port = data->set.proxyport; atsign = strchr(proxyptr, '/');
if(atsign)
*atsign = 0x0; /* cut off path part from host name */
if(data->set.proxyport)
/* None given in the proxy string, then get the default one if it is
given */
conn->port = data->set.proxyport;
} }
/* now, clone the cleaned proxy host name */ /* now, clone the cleaned proxy host name */
@ -3357,7 +3364,8 @@ static CURLcode parse_proxy(struct SessionHandle *data,
} }
/* Extract the user and password from the authentication string */ /* Extract the user and password from the authentication string */
static CURLcode parse_proxy_auth(struct SessionHandle *data, struct connectdata *conn) static CURLcode parse_proxy_auth(struct SessionHandle *data,
struct connectdata *conn)
{ {
char proxyuser[MAX_CURL_USER_LENGTH]=""; char proxyuser[MAX_CURL_USER_LENGTH]="";
char proxypasswd[MAX_CURL_PASSWORD_LENGTH]=""; char proxypasswd[MAX_CURL_PASSWORD_LENGTH]="";