generic-library/curl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

free: instead of Curl_safefree()

Browse Source 
Since we just started make use of free(NULL) in order to simplify code,
this change takes it a step further and:

- converts lots of Curl_safefree() calls to good old free()
- makes Curl_safefree() not check the pointer before free()

The (new) rule of thumb is: if you really want a function call that
frees a pointer and then assigns it to NULL, then use Curl_safefree().
But we will prefer just using free() from now on.
This commit is contained in:
Daniel Stenberg
2015-03-16 15:01:15 +01:00
parent 9e661601fe
commit 0f4a03cbb6
35 changed files with 202 additions and 202 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lib/asyn-ares.c
View File

@@ -533,7 +533,7 @@ Curl_addrinfo *Curl_resolver_getaddrinfo(struct connectdata *conn,
bufp = strdup(hostname); bufp = strdup(hostname);
if(bufp) { if(bufp) {
struct ResolverResults *res = NULL; struct ResolverResults *res = NULL;
Curl_safefree(conn->async.hostname); free(conn->async.hostname);
conn->async.hostname = bufp; conn->async.hostname = bufp;
conn->async.port = port; conn->async.port = port;
conn->async.done = FALSE; /* not done */ conn->async.done = FALSE; /* not done */
@@ -541,7 +541,7 @@ Curl_addrinfo *Curl_resolver_getaddrinfo(struct connectdata *conn,
conn->async.dns = NULL; /* clear */ conn->async.dns = NULL; /* clear */
res = calloc(sizeof(struct ResolverResults),1); res = calloc(sizeof(struct ResolverResults),1);
if(!res) { if(!res) {
Curl_safefree(conn->async.hostname); free(conn->async.hostname);
conn->async.hostname = NULL; conn->async.hostname = NULL;
return NULL; return NULL;
} }

2
lib/asyn-thread.c
View File

@@ -393,7 +393,7 @@ static bool init_resolve_thread (struct connectdata *conn,
if(!init_thread_sync_data(td, hostname, port, hints)) if(!init_thread_sync_data(td, hostname, port, hints))
goto err_exit; goto err_exit;
Curl_safefree(conn->async.hostname); free(conn->async.hostname);
conn->async.hostname = strdup(hostname); conn->async.hostname = strdup(hostname);
if(!conn->async.hostname) if(!conn->async.hostname)
goto err_exit; goto err_exit;

2
lib/base64.c
View File

@@ -149,7 +149,7 @@ CURLcode Curl_base64_decode(const char *src,
for(i = 0; i < numQuantums; i++) { for(i = 0; i < numQuantums; i++) {
size_t result = decodeQuantum(pos, src); size_t result = decodeQuantum(pos, src);
if(!result) { if(!result) {
Curl_safefree(newstr); free(newstr);
return CURLE_BAD_CONTENT_ENCODING; return CURLE_BAD_CONTENT_ENCODING;
} }

4
lib/bundles.c
View File

@@ -6,7 +6,7 @@
* \___|\___/|_| \_\_____| * \___|\___/|_| \_\_____|
* *
* Copyright (C) 2012, Linus Nielsen Feltzing, <linus@haxx.se> * Copyright (C) 2012, Linus Nielsen Feltzing, <linus@haxx.se>
* Copyright (C) 2012, Daniel Stenberg, <daniel@haxx.se>, et al. * Copyright (C) 2012-2015, Daniel Stenberg, <daniel@haxx.se>, et al.
* *
* This software is licensed as described in the file COPYING, which * This software is licensed as described in the file COPYING, which
* you should have received as part of this distribution. The terms * you should have received as part of this distribution. The terms
@@ -74,7 +74,7 @@ void Curl_bundle_destroy(struct connectbundle *cb_ptr)
Curl_llist_destroy(cb_ptr->conn_list, NULL); Curl_llist_destroy(cb_ptr->conn_list, NULL);
cb_ptr->conn_list = NULL; cb_ptr->conn_list = NULL;
} }
Curl_safefree(cb_ptr); free(cb_ptr);
} }
/* Add a connection to a bundle */ /* Add a connection to a bundle */

2
lib/cookie.c
View File

@@ -949,7 +949,7 @@ struct CookieInfo *Curl_cookie_init(struct SessionHandle *data,
return c; return c;
fail: fail:
Curl_safefree(line); free(line);
if(!inc) if(!inc)
/* Only clean up if we allocated it here, as the original could still be in /* Only clean up if we allocated it here, as the original could still be in
* use by a share handle */ * use by a share handle */

6
lib/curl_multibyte.c
View File

@@ -47,7 +47,8 @@ wchar_t *Curl_convert_UTF8_to_wchar(const char *str_utf8)
if(str_w) { if(str_w) {
if(MultiByteToWideChar(CP_UTF8, 0, str_utf8, -1, str_w, if(MultiByteToWideChar(CP_UTF8, 0, str_utf8, -1, str_w,
str_w_len) == 0) { str_w_len) == 0) {
Curl_safefree(str_w); free(str_w);
return NULL;
} }
} }
} }
@@ -68,7 +69,8 @@ char *Curl_convert_wchar_to_UTF8(const wchar_t *str_w)
if(str_utf8) { if(str_utf8) {
if(WideCharToMultiByte(CP_UTF8, 0, str_w, -1, str_utf8, str_utf8_len, if(WideCharToMultiByte(CP_UTF8, 0, str_w, -1, str_utf8, str_utf8_len,
NULL, FALSE) == 0) { NULL, FALSE) == 0) {
Curl_safefree(str_utf8); free(str_utf8);
return NULL;
} }
} }
} }

4
lib/curl_ntlm.c
View File

@@ -173,7 +173,7 @@ CURLcode Curl_output_ntlm(struct connectdata *conn, bool proxy)
return result; return result;
if(base64) { if(base64) {
Curl_safefree(*allocuserpwd); free(*allocuserpwd);
*allocuserpwd = aprintf("%sAuthorization: NTLM %s\r\n", *allocuserpwd = aprintf("%sAuthorization: NTLM %s\r\n",
proxy ? "Proxy-" : "", proxy ? "Proxy-" : "",
base64); base64);
@@ -193,7 +193,7 @@ CURLcode Curl_output_ntlm(struct connectdata *conn, bool proxy)
return result; return result;
if(base64) { if(base64) {
Curl_safefree(*allocuserpwd); free(*allocuserpwd);
*allocuserpwd = aprintf("%sAuthorization: NTLM %s\r\n", *allocuserpwd = aprintf("%sAuthorization: NTLM %s\r\n",
proxy ? "Proxy-" : "", proxy ? "Proxy-" : "",
base64); base64);

5
lib/curl_ntlm_core.c
View File

@@ -618,7 +618,7 @@ CURLcode Curl_ntlm_core_mk_ntlmv2_hash(const char *user, size_t userlen,
result = Curl_hmac_md5(ntlmhash, 16, identity, curlx_uztoui(identity_len), result = Curl_hmac_md5(ntlmhash, 16, identity, curlx_uztoui(identity_len),
ntlmv2hash); ntlmv2hash);
Curl_safefree(identity); free(identity);
return result; return result;
} }
@@ -705,8 +705,7 @@ CURLcode Curl_ntlm_core_mk_ntlmv2_resp(unsigned char *ntlmv2hash,
result = Curl_hmac_md5(ntlmv2hash, NTLM_HMAC_MD5_LEN, ptr + 8, result = Curl_hmac_md5(ntlmv2hash, NTLM_HMAC_MD5_LEN, ptr + 8,
NTLMv2_BLOB_LEN + 8, hmac_output); NTLMv2_BLOB_LEN + 8, hmac_output);
if(result) { if(result) {
Curl_safefree(ptr); free(ptr);
return result; return result;
} }

2
lib/curl_ntlm_msgs.c
View File

@@ -758,7 +758,7 @@ CURLcode Curl_sasl_create_ntlm_type3_message(struct SessionHandle *data,
ntlm_print_hex(stderr, (char *)&ntlmbuf[ntrespoff], ntresplen); ntlm_print_hex(stderr, (char *)&ntlmbuf[ntrespoff], ntresplen);
}); });
Curl_safefree(ntlmv2resp);/* Free the dynamic buffer allocated for NTLMv2 */ free(ntlmv2resp);/* Free the dynamic buffer allocated for NTLMv2 */
#endif #endif

18
lib/curl_ntlm_wb.c
View File

@@ -105,9 +105,9 @@ void Curl_ntlm_wb_cleanup(struct connectdata *conn)
conn->ntlm_auth_hlpr_pid = 0; conn->ntlm_auth_hlpr_pid = 0;
} }
Curl_safefree(conn->challenge_header); free(conn->challenge_header);
conn->challenge_header = NULL; conn->challenge_header = NULL;
Curl_safefree(conn->response_header); free(conn->response_header);
conn->response_header = NULL; conn->response_header = NULL;
} }
@@ -244,13 +244,13 @@ static CURLcode ntlm_wb_init(struct connectdata *conn, const char *userp)
sclose(sockfds[1]); sclose(sockfds[1]);
conn->ntlm_auth_hlpr_socket = sockfds[0]; conn->ntlm_auth_hlpr_socket = sockfds[0];
conn->ntlm_auth_hlpr_pid = child_pid; conn->ntlm_auth_hlpr_pid = child_pid;
Curl_safefree(domain); free(domain);
Curl_safefree(ntlm_auth_alloc); free(ntlm_auth_alloc);
return CURLE_OK; return CURLE_OK;
done: done:
Curl_safefree(domain); free(domain);
Curl_safefree(ntlm_auth_alloc); free(ntlm_auth_alloc);
return CURLE_REMOTE_ACCESS_DENIED; return CURLE_REMOTE_ACCESS_DENIED;
} }
@@ -389,12 +389,12 @@ CURLcode Curl_output_ntlm_wb(struct connectdata *conn,
if(res) if(res)
return res; return res;
Curl_safefree(*allocuserpwd); free(*allocuserpwd);
*allocuserpwd = aprintf("%sAuthorization: %s\r\n", *allocuserpwd = aprintf("%sAuthorization: %s\r\n",
proxy ? "Proxy-" : "", proxy ? "Proxy-" : "",
conn->response_header); conn->response_header);
DEBUG_OUT(fprintf(stderr, "**** Header %s\n ", *allocuserpwd)); DEBUG_OUT(fprintf(stderr, "**** Header %s\n ", *allocuserpwd));
Curl_safefree(conn->response_header); free(conn->response_header);
conn->response_header = NULL; conn->response_header = NULL;
break; break;
case NTLMSTATE_TYPE2: case NTLMSTATE_TYPE2:
@@ -407,7 +407,7 @@ CURLcode Curl_output_ntlm_wb(struct connectdata *conn,
if(res) if(res)
return res; return res;
Curl_safefree(*allocuserpwd); free(*allocuserpwd);
*allocuserpwd = aprintf("%sAuthorization: %s\r\n", *allocuserpwd = aprintf("%sAuthorization: %s\r\n",
proxy ? "Proxy-" : "", proxy ? "Proxy-" : "",
conn->response_header); conn->response_header);

44
lib/curl_sasl.c
View File

@@ -251,7 +251,7 @@ static CURLcode sasl_digest_get_qop_values(const char *options, int *value)
token = strtok_r(NULL, ",", &tok_buf); token = strtok_r(NULL, ",", &tok_buf);
} }
Curl_safefree(tmp); free(tmp);
return CURLE_OK; return CURLE_OK;
} }
@@ -324,7 +324,7 @@ static CURLcode sasl_create_plain_message(struct SessionHandle *data,
/* Base64 encode the reply */ /* Base64 encode the reply */
result = Curl_base64_encode(data, plainauth, 2 * ulen + plen + 2, outptr, result = Curl_base64_encode(data, plainauth, 2 * ulen + plen + 2, outptr,
outlen); outlen);
Curl_safefree(plainauth); free(plainauth);
return result; return result;
} }
@@ -481,7 +481,7 @@ static CURLcode sasl_create_cram_md5_message(struct SessionHandle *data,
/* Base64 encode the response */ /* Base64 encode the response */
result = Curl_base64_encode(data, response, 0, outptr, outlen); result = Curl_base64_encode(data, response, 0, outptr, outlen);
Curl_safefree(response); free(response);
return result; return result;
} }
@@ -531,7 +531,7 @@ static CURLcode sasl_decode_digest_md5_message(const char *chlg64,
/* Retrieve nonce string from the challenge */ /* Retrieve nonce string from the challenge */
if(!sasl_digest_get_key_value((char *)chlg, "nonce=\"", nonce, nlen, '\"')) { if(!sasl_digest_get_key_value((char *)chlg, "nonce=\"", nonce, nlen, '\"')) {
Curl_safefree(chlg); free(chlg);
return CURLE_BAD_CONTENT_ENCODING; return CURLE_BAD_CONTENT_ENCODING;
} }
@@ -543,17 +543,17 @@ static CURLcode sasl_decode_digest_md5_message(const char *chlg64,
/* Retrieve algorithm string from the challenge */ /* Retrieve algorithm string from the challenge */
if(!sasl_digest_get_key_value((char *)chlg, "algorithm=", alg, alen, ',')) { if(!sasl_digest_get_key_value((char *)chlg, "algorithm=", alg, alen, ',')) {
Curl_safefree(chlg); free(chlg);
return CURLE_BAD_CONTENT_ENCODING; return CURLE_BAD_CONTENT_ENCODING;
} }
/* Retrieve qop-options string from the challenge */ /* Retrieve qop-options string from the challenge */
if(!sasl_digest_get_key_value((char *)chlg, "qop=\"", qop, qlen, '\"')) { if(!sasl_digest_get_key_value((char *)chlg, "qop=\"", qop, qlen, '\"')) {
Curl_safefree(chlg); free(chlg);
return CURLE_BAD_CONTENT_ENCODING; return CURLE_BAD_CONTENT_ENCODING;
} }
Curl_safefree(chlg); free(chlg);
return CURLE_OK; return CURLE_OK;
} }
@@ -675,7 +675,7 @@ CURLcode Curl_sasl_create_digest_md5_message(struct SessionHandle *data,
/* Calculate H(A2) */ /* Calculate H(A2) */
ctxt = Curl_MD5_init(Curl_DIGEST_MD5); ctxt = Curl_MD5_init(Curl_DIGEST_MD5);
if(!ctxt) { if(!ctxt) {
Curl_safefree(spn); free(spn);
return CURLE_OUT_OF_MEMORY; return CURLE_OUT_OF_MEMORY;
} }
@@ -693,7 +693,7 @@ CURLcode Curl_sasl_create_digest_md5_message(struct SessionHandle *data,
/* Now calculate the response hash */ /* Now calculate the response hash */
ctxt = Curl_MD5_init(Curl_DIGEST_MD5); ctxt = Curl_MD5_init(Curl_DIGEST_MD5);
if(!ctxt) { if(!ctxt) {
Curl_safefree(spn); free(spn);
return CURLE_OUT_OF_MEMORY; return CURLE_OUT_OF_MEMORY;
} }
@@ -726,14 +726,14 @@ CURLcode Curl_sasl_create_digest_md5_message(struct SessionHandle *data,
"qop=%s", "qop=%s",
userp, realm, nonce, userp, realm, nonce,
cnonce, nonceCount, spn, resp_hash_hex, qop); cnonce, nonceCount, spn, resp_hash_hex, qop);
Curl_safefree(spn); free(spn);
if(!response) if(!response)
return CURLE_OUT_OF_MEMORY; return CURLE_OUT_OF_MEMORY;
/* Base64 encode the response */ /* Base64 encode the response */
result = Curl_base64_encode(data, response, 0, outptr, outlen); result = Curl_base64_encode(data, response, 0, outptr, outlen);
Curl_safefree(response); free(response);
return result; return result;
} }
@@ -947,7 +947,7 @@ CURLcode Curl_sasl_create_digest_http_message(struct SessionHandle *data,
CURL_OUTPUT_DIGEST_CONV(data, md5this); /* convert on non-ASCII machines */ CURL_OUTPUT_DIGEST_CONV(data, md5this); /* convert on non-ASCII machines */
Curl_md5it(md5buf, md5this); Curl_md5it(md5buf, md5this);
Curl_safefree(md5this); free(md5this);
sasl_digest_md5_to_ascii(md5buf, ha1); sasl_digest_md5_to_ascii(md5buf, ha1);
if(digest->algo == CURLDIGESTALGO_MD5SESS) { if(digest->algo == CURLDIGESTALGO_MD5SESS) {
@@ -958,7 +958,7 @@ CURLcode Curl_sasl_create_digest_http_message(struct SessionHandle *data,
CURL_OUTPUT_DIGEST_CONV(data, tmp); /* convert on non-ASCII machines */ CURL_OUTPUT_DIGEST_CONV(data, tmp); /* convert on non-ASCII machines */
Curl_md5it(md5buf, (unsigned char *)tmp); Curl_md5it(md5buf, (unsigned char *)tmp);
Curl_safefree(tmp); free(tmp);
sasl_digest_md5_to_ascii(md5buf, ha1); sasl_digest_md5_to_ascii(md5buf, ha1);
} }
@@ -982,7 +982,7 @@ CURLcode Curl_sasl_create_digest_http_message(struct SessionHandle *data,
TODO: replace md5 of empty string with entity-body for PUT/POST */ TODO: replace md5 of empty string with entity-body for PUT/POST */
unsigned char *md5this2 = (unsigned char *) unsigned char *md5this2 = (unsigned char *)
aprintf("%s:%s", md5this, "d41d8cd98f00b204e9800998ecf8427e"); aprintf("%s:%s", md5this, "d41d8cd98f00b204e9800998ecf8427e");
Curl_safefree(md5this); free(md5this);
md5this = md5this2; md5this = md5this2;
} }
@@ -991,7 +991,7 @@ CURLcode Curl_sasl_create_digest_http_message(struct SessionHandle *data,
CURL_OUTPUT_DIGEST_CONV(data, md5this); /* convert on non-ASCII machines */ CURL_OUTPUT_DIGEST_CONV(data, md5this); /* convert on non-ASCII machines */
Curl_md5it(md5buf, md5this); Curl_md5it(md5buf, md5this);
Curl_safefree(md5this); free(md5this);
sasl_digest_md5_to_ascii(md5buf, ha2); sasl_digest_md5_to_ascii(md5buf, ha2);
if(digest->qop) { if(digest->qop) {
@@ -1015,7 +1015,7 @@ CURLcode Curl_sasl_create_digest_http_message(struct SessionHandle *data,
CURL_OUTPUT_DIGEST_CONV(data, md5this); /* convert on non-ASCII machines */ CURL_OUTPUT_DIGEST_CONV(data, md5this); /* convert on non-ASCII machines */
Curl_md5it(md5buf, md5this); Curl_md5it(md5buf, md5this);
Curl_safefree(md5this); free(md5this);
sasl_digest_md5_to_ascii(md5buf, request_digest); sasl_digest_md5_to_ascii(md5buf, request_digest);
/* for test case 64 (snooped from a Mozilla 1.3a request) /* for test case 64 (snooped from a Mozilla 1.3a request)
@@ -1070,7 +1070,7 @@ CURLcode Curl_sasl_create_digest_http_message(struct SessionHandle *data,
uripath, uripath,
request_digest); request_digest);
} }
Curl_safefree(userp_quoted); free(userp_quoted);
if(!response) if(!response)
return CURLE_OUT_OF_MEMORY; return CURLE_OUT_OF_MEMORY;
@@ -1183,7 +1183,7 @@ static CURLcode sasl_create_xoauth2_message(struct SessionHandle *data,
/* Base64 encode the reply */ /* Base64 encode the reply */
result = Curl_base64_encode(data, xoauth, strlen(xoauth), outptr, outlen); result = Curl_base64_encode(data, xoauth, strlen(xoauth), outptr, outlen);
Curl_safefree(xoauth); free(xoauth);
return result; return result;
} }
@@ -1474,7 +1474,7 @@ CURLcode Curl_sasl_start(struct SASL *sasl, struct connectdata *conn,
if(!result) { if(!result) {
if(resp && sasl->params->maxirlen && if(resp && sasl->params->maxirlen &&
strlen(mech) + len > sasl->params->maxirlen) { strlen(mech) + len > sasl->params->maxirlen) {
Curl_safefree(resp); free(resp);
resp = NULL; resp = NULL;
} }
@@ -1487,7 +1487,7 @@ CURLcode Curl_sasl_start(struct SASL *sasl, struct connectdata *conn,
} }
} }
Curl_safefree(resp); free(resp);
return result; return result;
} }
@@ -1553,7 +1553,7 @@ CURLcode Curl_sasl_continue(struct SASL *sasl, struct connectdata *conn,
if(!result) if(!result)
result = sasl_create_cram_md5_message(data, chlg, conn->user, result = sasl_create_cram_md5_message(data, chlg, conn->user,
conn->passwd, &resp, &len); conn->passwd, &resp, &len);
Curl_safefree(chlg); free(chlg);
break; break;
case SASL_DIGESTMD5: case SASL_DIGESTMD5:
sasl->params->getmessage(data->state.buffer, &serverdata); sasl->params->getmessage(data->state.buffer, &serverdata);
@@ -1659,7 +1659,7 @@ CURLcode Curl_sasl_continue(struct SASL *sasl, struct connectdata *conn,
break; break;
} }
Curl_safefree(resp); free(resp);
state(sasl, conn, newstate); state(sasl, conn, newstate);

20
lib/curl_sasl_gssapi.c
View File

@@ -120,12 +120,12 @@ CURLcode Curl_sasl_create_gssapi_user_message(struct SessionHandle *data,
if(GSS_ERROR(gss_major_status)) { if(GSS_ERROR(gss_major_status)) {
Curl_gss_log_error(data, gss_minor_status, "gss_import_name() failed: "); Curl_gss_log_error(data, gss_minor_status, "gss_import_name() failed: ");
Curl_safefree(spn); free(spn);
return CURLE_OUT_OF_MEMORY; return CURLE_OUT_OF_MEMORY;
} }
Curl_safefree(spn); free(spn);
} }
else { else {
/* Decode the base-64 encoded challenge message */ /* Decode the base-64 encoded challenge message */
@@ -158,7 +158,7 @@ CURLcode Curl_sasl_create_gssapi_user_message(struct SessionHandle *data,
mutual_auth, mutual_auth,
NULL); NULL);
Curl_safefree(input_token.value); free(input_token.value);
if(GSS_ERROR(gss_major_status)) { if(GSS_ERROR(gss_major_status)) {
if(output_token.value) if(output_token.value)
@@ -244,7 +244,7 @@ CURLcode Curl_sasl_create_gssapi_security_message(struct SessionHandle *data,
Curl_gss_log_error(data, gss_minor_status, Curl_gss_log_error(data, gss_minor_status,
"gss_inquire_context() failed: "); "gss_inquire_context() failed: ");
Curl_safefree(chlg); free(chlg);
return CURLE_OUT_OF_MEMORY; return CURLE_OUT_OF_MEMORY;
} }
@@ -255,7 +255,7 @@ CURLcode Curl_sasl_create_gssapi_security_message(struct SessionHandle *data,
if(GSS_ERROR(gss_major_status)) { if(GSS_ERROR(gss_major_status)) {
Curl_gss_log_error(data, gss_minor_status, "gss_display_name() failed: "); Curl_gss_log_error(data, gss_minor_status, "gss_display_name() failed: ");
Curl_safefree(chlg); free(chlg);
return CURLE_OUT_OF_MEMORY; return CURLE_OUT_OF_MEMORY;
} }
@@ -271,7 +271,7 @@ CURLcode Curl_sasl_create_gssapi_security_message(struct SessionHandle *data,
Curl_gss_log_error(data, gss_minor_status, "gss_unwrap() failed: "); Curl_gss_log_error(data, gss_minor_status, "gss_unwrap() failed: ");
gss_release_buffer(&gss_status, &username_token); gss_release_buffer(&gss_status, &username_token);
Curl_safefree(chlg); free(chlg);
return CURLE_BAD_CONTENT_ENCODING; return CURLE_BAD_CONTENT_ENCODING;
} }
@@ -281,7 +281,7 @@ CURLcode Curl_sasl_create_gssapi_security_message(struct SessionHandle *data,
infof(data, "GSSAPI handshake failure (invalid security data)\n"); infof(data, "GSSAPI handshake failure (invalid security data)\n");
gss_release_buffer(&gss_status, &username_token); gss_release_buffer(&gss_status, &username_token);
Curl_safefree(chlg); free(chlg);
return CURLE_BAD_CONTENT_ENCODING; return CURLE_BAD_CONTENT_ENCODING;
} }
@@ -289,7 +289,7 @@ CURLcode Curl_sasl_create_gssapi_security_message(struct SessionHandle *data,
/* Copy the data out and free the challenge as it is not required anymore */ /* Copy the data out and free the challenge as it is not required anymore */
memcpy(&indata, output_token.value, 4); memcpy(&indata, output_token.value, 4);
gss_release_buffer(&gss_status, &output_token); gss_release_buffer(&gss_status, &output_token);
Curl_safefree(chlg); free(chlg);
/* Extract the security layer */ /* Extract the security layer */
sec_layer = indata & 0x000000FF; sec_layer = indata & 0x000000FF;
@@ -344,7 +344,7 @@ CURLcode Curl_sasl_create_gssapi_security_message(struct SessionHandle *data,
if(GSS_ERROR(gss_major_status)) { if(GSS_ERROR(gss_major_status)) {
Curl_gss_log_error(data, gss_minor_status, "gss_wrap() failed: "); Curl_gss_log_error(data, gss_minor_status, "gss_wrap() failed: ");
Curl_safefree(message); free(message);
return CURLE_OUT_OF_MEMORY; return CURLE_OUT_OF_MEMORY;
} }
@@ -357,7 +357,7 @@ CURLcode Curl_sasl_create_gssapi_security_message(struct SessionHandle *data,
gss_release_buffer(&gss_status, &output_token); gss_release_buffer(&gss_status, &output_token);
/* Free the message buffer */ /* Free the message buffer */
Curl_safefree(message); free(message);
return result; return result;
} }

84
lib/curl_sasl_sspi.c
View File

@@ -78,7 +78,7 @@ TCHAR *Curl_sasl_build_spn(const char *service, const char *host)
/* Allocate our TCHAR based SPN */ /* Allocate our TCHAR based SPN */
tchar_spn = Curl_convert_UTF8_to_tchar(utf8_spn); tchar_spn = Curl_convert_UTF8_to_tchar(utf8_spn);
if(!tchar_spn) { if(!tchar_spn) {
Curl_safefree(utf8_spn); free(utf8_spn);
return NULL; return NULL;
} }
@@ -154,7 +154,7 @@ CURLcode Curl_sasl_create_digest_md5_message(struct SessionHandle *data,
status = s_pSecFn->QuerySecurityPackageInfo((TCHAR *) TEXT(SP_NAME_DIGEST), status = s_pSecFn->QuerySecurityPackageInfo((TCHAR *) TEXT(SP_NAME_DIGEST),
&SecurityPackage); &SecurityPackage);
if(status != SEC_E_OK) { if(status != SEC_E_OK) {
Curl_safefree(input_token); free(input_token);
return CURLE_NOT_BUILT_IN; return CURLE_NOT_BUILT_IN;
} }
@@ -167,7 +167,7 @@ CURLcode Curl_sasl_create_digest_md5_message(struct SessionHandle *data,
/* Allocate our response buffer */ /* Allocate our response buffer */
output_token = malloc(token_max); output_token = malloc(token_max);
if(!output_token) { if(!output_token) {
Curl_safefree(input_token); free(input_token);
return CURLE_OUT_OF_MEMORY; return CURLE_OUT_OF_MEMORY;
} }
@@ -175,8 +175,8 @@ CURLcode Curl_sasl_create_digest_md5_message(struct SessionHandle *data,
/* Generate our SPN */ /* Generate our SPN */
spn = Curl_sasl_build_spn(service, data->easy_conn->host.name); spn = Curl_sasl_build_spn(service, data->easy_conn->host.name);
if(!spn) { if(!spn) {
Curl_safefree(output_token); free(output_token);
Curl_safefree(input_token); free(input_token);
return CURLE_OUT_OF_MEMORY; return CURLE_OUT_OF_MEMORY;
} }
@@ -185,9 +185,9 @@ CURLcode Curl_sasl_create_digest_md5_message(struct SessionHandle *data,
/* Populate our identity structure */ /* Populate our identity structure */
result = Curl_create_sspi_identity(userp, passwdp, &identity); result = Curl_create_sspi_identity(userp, passwdp, &identity);
if(result) { if(result) {
Curl_safefree(spn); free(spn);
Curl_safefree(output_token); free(output_token);
Curl_safefree(input_token); free(input_token);
return result; return result;
} }
@@ -208,9 +208,9 @@ CURLcode Curl_sasl_create_digest_md5_message(struct SessionHandle *data,
if(status != SEC_E_OK) { if(status != SEC_E_OK) {
Curl_sspi_free_identity(p_identity); Curl_sspi_free_identity(p_identity);
Curl_safefree(spn); free(spn);
Curl_safefree(output_token); free(output_token);
Curl_safefree(input_token); free(input_token);
return CURLE_LOGIN_DENIED; return CURLE_LOGIN_DENIED;
} }
@@ -243,9 +243,9 @@ CURLcode Curl_sasl_create_digest_md5_message(struct SessionHandle *data,
else if(status != SEC_E_OK && status != SEC_I_CONTINUE_NEEDED) { else if(status != SEC_E_OK && status != SEC_I_CONTINUE_NEEDED) {
s_pSecFn->FreeCredentialsHandle(&credentials); s_pSecFn->FreeCredentialsHandle(&credentials);
Curl_sspi_free_identity(p_identity); Curl_sspi_free_identity(p_identity);
Curl_safefree(spn); free(spn);
Curl_safefree(output_token); free(output_token);
Curl_safefree(input_token); free(input_token);
return CURLE_RECV_ERROR; return CURLE_RECV_ERROR;
} }
@@ -262,13 +262,13 @@ CURLcode Curl_sasl_create_digest_md5_message(struct SessionHandle *data,
Curl_sspi_free_identity(p_identity); Curl_sspi_free_identity(p_identity);
/* Free the SPN */ /* Free the SPN */
Curl_safefree(spn); free(spn);
/* Free the response buffer */ /* Free the response buffer */
Curl_safefree(output_token); free(output_token);
/* Free the decoded challenge message */ /* Free the decoded challenge message */
Curl_safefree(input_token); free(input_token);
return result; return result;
} }
@@ -388,7 +388,7 @@ CURLcode Curl_sasl_create_digest_http_message(struct SessionHandle *data,
p_identity, NULL, NULL, p_identity, NULL, NULL,
&credentials, &expiry); &credentials, &expiry);
if(status != SEC_E_OK) { if(status != SEC_E_OK) {
Curl_safefree(output_token); free(output_token);
return CURLE_LOGIN_DENIED; return CURLE_LOGIN_DENIED;
} }
@@ -428,7 +428,7 @@ CURLcode Curl_sasl_create_digest_http_message(struct SessionHandle *data,
else if(status != SEC_E_OK && status != SEC_I_CONTINUE_NEEDED) { else if(status != SEC_E_OK && status != SEC_I_CONTINUE_NEEDED) {
s_pSecFn->FreeCredentialsHandle(&credentials); s_pSecFn->FreeCredentialsHandle(&credentials);
Curl_safefree(output_token); free(output_token);
return CURLE_OUT_OF_MEMORY; return CURLE_OUT_OF_MEMORY;
} }
@@ -438,7 +438,7 @@ CURLcode Curl_sasl_create_digest_http_message(struct SessionHandle *data,
s_pSecFn->DeleteSecurityContext(&context); s_pSecFn->DeleteSecurityContext(&context);
s_pSecFn->FreeCredentialsHandle(&credentials); s_pSecFn->FreeCredentialsHandle(&credentials);
Curl_safefree(output_token); free(output_token);
return CURLE_OUT_OF_MEMORY; return CURLE_OUT_OF_MEMORY;
} }
@@ -459,7 +459,7 @@ CURLcode Curl_sasl_create_digest_http_message(struct SessionHandle *data,
Curl_sspi_free_identity(p_identity); Curl_sspi_free_identity(p_identity);
/* Free the response buffer */ /* Free the response buffer */
Curl_safefree(output_token); free(output_token);
return CURLE_OK; return CURLE_OK;
} }
@@ -910,7 +910,7 @@ CURLcode Curl_sasl_create_gssapi_user_message(struct SessionHandle *data,
&expiry); &expiry);
if(status != SEC_E_OK && status != SEC_I_CONTINUE_NEEDED) { if(status != SEC_E_OK && status != SEC_I_CONTINUE_NEEDED) {
Curl_safefree(chlg); free(chlg);
return CURLE_RECV_ERROR; return CURLE_RECV_ERROR;
} }
@@ -928,7 +928,7 @@ CURLcode Curl_sasl_create_gssapi_user_message(struct SessionHandle *data,
} }
/* Free the decoded challenge */ /* Free the decoded challenge */
Curl_safefree(chlg); free(chlg);
return result; return result;
} }
@@ -999,7 +999,7 @@ CURLcode Curl_sasl_create_gssapi_security_message(struct SessionHandle *data,
SECPKG_ATTR_SIZES, SECPKG_ATTR_SIZES,
&sizes); &sizes);
if(status != SEC_E_OK) { if(status != SEC_E_OK) {
Curl_safefree(chlg); free(chlg);
return CURLE_OUT_OF_MEMORY; return CURLE_OUT_OF_MEMORY;
} }
@@ -1009,7 +1009,7 @@ CURLcode Curl_sasl_create_gssapi_security_message(struct SessionHandle *data,
SECPKG_CRED_ATTR_NAMES, SECPKG_CRED_ATTR_NAMES,
&names); &names);
if(status != SEC_E_OK) { if(status != SEC_E_OK) {
Curl_safefree(chlg); free(chlg);
return CURLE_RECV_ERROR; return CURLE_RECV_ERROR;
} }
@@ -1030,7 +1030,7 @@ CURLcode Curl_sasl_create_gssapi_security_message(struct SessionHandle *data,
if(status != SEC_E_OK) { if(status != SEC_E_OK) {
infof(data, "GSSAPI handshake failure (empty security message)\n"); infof(data, "GSSAPI handshake failure (empty security message)\n");
Curl_safefree(chlg); free(chlg);
return CURLE_BAD_CONTENT_ENCODING; return CURLE_BAD_CONTENT_ENCODING;
} }
@@ -1039,7 +1039,7 @@ CURLcode Curl_sasl_create_gssapi_security_message(struct SessionHandle *data,
if(input_buf[1].cbBuffer != 4) { if(input_buf[1].cbBuffer != 4) {
infof(data, "GSSAPI handshake failure (invalid security data)\n"); infof(data, "GSSAPI handshake failure (invalid security data)\n");
Curl_safefree(chlg); free(chlg);
return CURLE_BAD_CONTENT_ENCODING; return CURLE_BAD_CONTENT_ENCODING;
} }
@@ -1047,7 +1047,7 @@ CURLcode Curl_sasl_create_gssapi_security_message(struct SessionHandle *data,
/* Copy the data out and free the challenge as it is not required anymore */ /* Copy the data out and free the challenge as it is not required anymore */
memcpy(&indata, input_buf[1].pvBuffer, 4); memcpy(&indata, input_buf[1].pvBuffer, 4);
s_pSecFn->FreeContextBuffer(input_buf[1].pvBuffer); s_pSecFn->FreeContextBuffer(input_buf[1].pvBuffer);
Curl_safefree(chlg); free(chlg);
/* Extract the security layer */ /* Extract the security layer */
sec_layer = indata & 0x000000FF; sec_layer = indata & 0x000000FF;
@@ -1074,7 +1074,7 @@ CURLcode Curl_sasl_create_gssapi_security_message(struct SessionHandle *data,
/* Convert the user name to UTF8 when operating with Unicode */ /* Convert the user name to UTF8 when operating with Unicode */
user_name = Curl_convert_tchar_to_UTF8(names.sUserName); user_name = Curl_convert_tchar_to_UTF8(names.sUserName);
if(!user_name) { if(!user_name) {
Curl_safefree(trailer); free(trailer);
return CURLE_OUT_OF_MEMORY; return CURLE_OUT_OF_MEMORY;
} }
@@ -1083,7 +1083,7 @@ CURLcode Curl_sasl_create_gssapi_security_message(struct SessionHandle *data,
messagelen = sizeof(outdata) + strlen(user_name) + 1; messagelen = sizeof(outdata) + strlen(user_name) + 1;
message = malloc(messagelen); message = malloc(messagelen);
if(!message) { if(!message) {
Curl_safefree(trailer); free(trailer);
Curl_unicodefree(user_name); Curl_unicodefree(user_name);
return CURLE_OUT_OF_MEMORY; return CURLE_OUT_OF_MEMORY;
@@ -1102,8 +1102,8 @@ CURLcode Curl_sasl_create_gssapi_security_message(struct SessionHandle *data,
/* Allocate the padding */ /* Allocate the padding */
padding = malloc(sizes.cbBlockSize); padding = malloc(sizes.cbBlockSize);
if(!padding) { if(!padding) {
Curl_safefree(message); free(message);
Curl_safefree(trailer); free(trailer);
return CURLE_OUT_OF_MEMORY; return CURLE_OUT_OF_MEMORY;
} }
@@ -1126,9 +1126,9 @@ CURLcode Curl_sasl_create_gssapi_security_message(struct SessionHandle *data,
status = s_pSecFn->EncryptMessage(krb5->context, KERB_WRAP_NO_ENCRYPT, status = s_pSecFn->EncryptMessage(krb5->context, KERB_WRAP_NO_ENCRYPT,
&wrap_desc, 0); &wrap_desc, 0);
if(status != SEC_E_OK) { if(status != SEC_E_OK) {
Curl_safefree(padding); free(padding);
Curl_safefree(message); free(message);
Curl_safefree(trailer); free(trailer);
return CURLE_OUT_OF_MEMORY; return CURLE_OUT_OF_MEMORY;
} }
@@ -1138,9 +1138,9 @@ CURLcode Curl_sasl_create_gssapi_security_message(struct SessionHandle *data,
wrap_buf[2].cbBuffer; wrap_buf[2].cbBuffer;
appdata = malloc(appdatalen); appdata = malloc(appdatalen);
if(!appdata) { if(!appdata) {
Curl_safefree(padding); free(padding);
Curl_safefree(message); free(message);
Curl_safefree(trailer); free(trailer);
return CURLE_OUT_OF_MEMORY; return CURLE_OUT_OF_MEMORY;
} }
@@ -1157,10 +1157,10 @@ CURLcode Curl_sasl_create_gssapi_security_message(struct SessionHandle *data,
outlen); outlen);
/* Free all of our local buffers */ /* Free all of our local buffers */
Curl_safefree(appdata); free(appdata);
Curl_safefree(padding); free(padding);
Curl_safefree(message); free(message);
Curl_safefree(trailer); free(trailer);
return result; return result;
} }

4
lib/curl_threads.c
View File

@@ -73,8 +73,8 @@ curl_thread_t Curl_thread_create(unsigned int (*func) (void*), void *arg)
return t; return t;
err: err:
Curl_safefree(t); free(t);
Curl_safefree(ac); free(ac);
return curl_thread_t_null; return curl_thread_t_null;
} }

24
lib/formdata.c
View File

@@ -415,7 +415,7 @@ CURLFORMcode FormAdd(struct curl_httppost **httppost,
else { else {
form = AddFormInfo(fname, NULL, current_form); form = AddFormInfo(fname, NULL, current_form);
if(!form) { if(!form) {
Curl_safefree(fname); free(fname);
return_value = CURL_FORMADD_MEMORY; return_value = CURL_FORMADD_MEMORY;
} }
else { else {
@@ -504,7 +504,7 @@ CURLFORMcode FormAdd(struct curl_httppost **httppost,
else { else {
form = AddFormInfo(NULL, type, current_form); form = AddFormInfo(NULL, type, current_form);
if(!form) { if(!form) {
Curl_safefree(type); free(type);
return_value = CURL_FORMADD_MEMORY; return_value = CURL_FORMADD_MEMORY;
} }
else { else {
@@ -711,7 +711,7 @@ CURLFORMcode FormAdd(struct curl_httppost **httppost,
now by the httppost linked list */ now by the httppost linked list */
while(first_form) { while(first_form) {
FormInfo *ptr = first_form->more; FormInfo *ptr = first_form->more;
Curl_safefree(first_form); free(first_form);
first_form = ptr; first_form = ptr;
} }
@@ -1068,7 +1068,7 @@ static CURLcode formdata_add_filename(const struct curl_httppost *file,
/* filename need be escaped */ /* filename need be escaped */
filename_escaped = malloc(strlen(filename)*2+1); filename_escaped = malloc(strlen(filename)*2+1);
if(!filename_escaped) { if(!filename_escaped) {
Curl_safefree(filebasename); free(filebasename);
return CURLE_OUT_OF_MEMORY; return CURLE_OUT_OF_MEMORY;
} }
p0 = filename_escaped; p0 = filename_escaped;
@@ -1084,8 +1084,8 @@ static CURLcode formdata_add_filename(const struct curl_httppost *file,
result = AddFormDataf(form, size, result = AddFormDataf(form, size,
"; filename=\"%s\"", "; filename=\"%s\"",
filename); filename);
Curl_safefree(filename_escaped); free(filename_escaped);
Curl_safefree(filebasename); free(filebasename);
return result; return result;
} }
@@ -1135,7 +1135,7 @@ CURLcode Curl_getformdata(struct SessionHandle *data,
boundary); boundary);
if(result) { if(result) {
Curl_safefree(boundary); free(boundary);
return result; return result;
} }
/* we DO NOT include that line in the total size of the POST, since it'll be /* we DO NOT include that line in the total size of the POST, since it'll be
@@ -1178,7 +1178,7 @@ CURLcode Curl_getformdata(struct SessionHandle *data,
/* If used, this is a link to more file names, we must then do /* If used, this is a link to more file names, we must then do
the magic to include several files with the same field name */ the magic to include several files with the same field name */
Curl_safefree(fileboundary); free(fileboundary);
fileboundary = formboundary(data); fileboundary = formboundary(data);
if(!fileboundary) { if(!fileboundary) {
result = CURLE_OUT_OF_MEMORY; result = CURLE_OUT_OF_MEMORY;
@@ -1331,15 +1331,15 @@ CURLcode Curl_getformdata(struct SessionHandle *data,
if(result) { if(result) {
Curl_formclean(&firstform); Curl_formclean(&firstform);
Curl_safefree(fileboundary); free(fileboundary);
Curl_safefree(boundary); free(boundary);
return result; return result;
} }
*sizep = size; *sizep = size;
Curl_safefree(fileboundary); free(fileboundary);
Curl_safefree(boundary); free(boundary);
*finalform = firstform; *finalform = firstform;

10
lib/ftp.c
View File

@@ -1101,7 +1101,7 @@ static CURLcode ftp_state_use_port(struct connectdata *conn,
if(getsockname(conn->sock[FIRSTSOCKET], sa, &sslen)) { if(getsockname(conn->sock[FIRSTSOCKET], sa, &sslen)) {
failf(data, "getsockname() failed: %s", failf(data, "getsockname() failed: %s",
Curl_strerror(conn, SOCKERRNO) ); Curl_strerror(conn, SOCKERRNO) );
Curl_safefree(addr); free(addr);
return CURLE_FTP_PORT_FAILED; return CURLE_FTP_PORT_FAILED;
} }
switch(sa->sa_family) { switch(sa->sa_family) {
@@ -1133,11 +1133,11 @@ static CURLcode ftp_state_use_port(struct connectdata *conn,
if(res == NULL) { if(res == NULL) {
failf(data, "failed to resolve the address provided to PORT: %s", host); failf(data, "failed to resolve the address provided to PORT: %s", host);
Curl_safefree(addr); free(addr);
return CURLE_FTP_PORT_FAILED; return CURLE_FTP_PORT_FAILED;
} }
Curl_safefree(addr); free(addr);
host = NULL; host = NULL;
/* step 2, create a socket for the requested address */ /* step 2, create a socket for the requested address */
@@ -3807,7 +3807,7 @@ static void wc_data_dtor(void *ptr)
struct ftp_wc_tmpdata *tmp = ptr; struct ftp_wc_tmpdata *tmp = ptr;
if(tmp) if(tmp)
Curl_ftp_parselist_data_free(&tmp->parser); Curl_ftp_parselist_data_free(&tmp->parser);
Curl_safefree(tmp); free(tmp);
} }
static CURLcode init_wc_data(struct connectdata *conn) static CURLcode init_wc_data(struct connectdata *conn)
@@ -3861,7 +3861,7 @@ static CURLcode init_wc_data(struct connectdata *conn)
ftp_tmp->parser = Curl_ftp_parselist_data_alloc(); ftp_tmp->parser = Curl_ftp_parselist_data_alloc();
if(!ftp_tmp->parser) { if(!ftp_tmp->parser) {
Curl_safefree(wildcard->pattern); Curl_safefree(wildcard->pattern);
Curl_safefree(ftp_tmp); free(ftp_tmp);
return CURLE_OUT_OF_MEMORY; return CURLE_OUT_OF_MEMORY;
} }

6
lib/gopher.c
View File

@@ -120,7 +120,7 @@ static CURLcode gopher_do(struct connectdata *conn, bool *done)
if(!result) { /* Which may not have written it all! */ if(!result) { /* Which may not have written it all! */
result = Curl_client_write(conn, CLIENTWRITE_HEADER, sel, amount); result = Curl_client_write(conn, CLIENTWRITE_HEADER, sel, amount);
if(result) { if(result) {
Curl_safefree(sel_org); free(sel_org);
return result; return result;
} }
k -= amount; k -= amount;
@@ -130,7 +130,7 @@ static CURLcode gopher_do(struct connectdata *conn, bool *done)
} }
else { else {
failf(data, "Failed sending Gopher request"); failf(data, "Failed sending Gopher request");
Curl_safefree(sel_org); free(sel_org);
return result; return result;
} }
/* Don't busyloop. The entire loop thing is a work-around as it causes a /* Don't busyloop. The entire loop thing is a work-around as it causes a
@@ -145,7 +145,7 @@ static CURLcode gopher_do(struct connectdata *conn, bool *done)
Curl_socket_ready(CURL_SOCKET_BAD, sockfd, 100); Curl_socket_ready(CURL_SOCKET_BAD, sockfd, 100);
} }
Curl_safefree(sel_org); free(sel_org);
/* We can use Curl_sendf to send the terminal \r\n relatively safely and /* We can use Curl_sendf to send the terminal \r\n relatively safely and
save allocing another string/doing another _write loop. */ save allocing another string/doing another _write loop. */

6
lib/http.c
View File

@@ -301,7 +301,7 @@ static CURLcode http_output_basic(struct connectdata *conn, bool proxy)
if(!authorization) if(!authorization)
return CURLE_REMOTE_ACCESS_DENIED; return CURLE_REMOTE_ACCESS_DENIED;
Curl_safefree(*userp); free(*userp);
*userp = aprintf("%sAuthorization: Basic %s\r\n", *userp = aprintf("%sAuthorization: Basic %s\r\n",
proxy?"Proxy-":"", proxy?"Proxy-":"",
authorization); authorization);
@@ -3483,7 +3483,7 @@ CURLcode Curl_http_readwrite_headers(struct SessionHandle *data,
if(Curl_pipeline_server_blacklisted(data, server_name)) if(Curl_pipeline_server_blacklisted(data, server_name))
conn->bundle->server_supports_pipelining = FALSE; conn->bundle->server_supports_pipelining = FALSE;
} }
Curl_safefree(server_name); free(server_name);
} }
else if((conn->httpversion == 10) && else if((conn->httpversion == 10) &&
conn->bits.httpproxy && conn->bits.httpproxy &&
@@ -3688,7 +3688,7 @@ CURLcode Curl_http_readwrite_headers(struct SessionHandle *data,
result = Curl_http_input_auth(conn, proxy, auth); result = Curl_http_input_auth(conn, proxy, auth);
Curl_safefree(auth); free(auth);
if(result) if(result)
return result; return result;

4
lib/http2.c
View File

@@ -669,7 +669,7 @@ CURLcode Curl_http2_request_upgrade(Curl_send_buffer *req,
"Upgrade: %s\r\n" "Upgrade: %s\r\n"
"HTTP2-Settings: %s\r\n", "HTTP2-Settings: %s\r\n",
NGHTTP2_CLEARTEXT_PROTO_VERSION_ID, base64); NGHTTP2_CLEARTEXT_PROTO_VERSION_ID, base64);
Curl_safefree(base64); free(base64);
k->upgr101 = UPGR101_REQUESTED; k->upgr101 = UPGR101_REQUESTED;
@@ -945,7 +945,7 @@ static ssize_t http2_send(struct connectdata *conn, int sockindex,
NULL, NULL); NULL, NULL);
} }
Curl_safefree(nva); free(nva);
if(stream_id < 0) { if(stream_id < 0) {
*err = CURLE_SEND_ERROR; *err = CURLE_SEND_ERROR;

6
lib/http_negotiate.c
View File

@@ -78,12 +78,12 @@ CURLcode Curl_input_negotiate(struct connectdata *conn, bool proxy,
if(GSS_ERROR(major_status)) { if(GSS_ERROR(major_status)) {
Curl_gss_log_error(data, minor_status, "gss_import_name() failed: "); Curl_gss_log_error(data, minor_status, "gss_import_name() failed: ");
Curl_safefree(spn); free(spn);
return CURLE_OUT_OF_MEMORY; return CURLE_OUT_OF_MEMORY;
} }
Curl_safefree(spn); free(spn);
} }
header += strlen("Negotiate"); header += strlen("Negotiate");
@@ -179,7 +179,7 @@ CURLcode Curl_output_negotiate(struct connectdata *conn, bool proxy)
conn->allocptr.userpwd = userp; conn->allocptr.userpwd = userp;
} }
Curl_safefree(encoded); free(encoded);
return (userp == NULL) ? CURLE_OUT_OF_MEMORY : CURLE_OK; return (userp == NULL) ? CURLE_OUT_OF_MEMORY : CURLE_OK;
} }

2
lib/http_negotiate_sspi.c
View File

@@ -207,7 +207,7 @@ CURLcode Curl_input_negotiate(struct connectdata *conn, bool proxy,
&attrs, &attrs,
&expiry); &expiry);
Curl_safefree(input_token); free(input_token);
if(GSS_ERROR(neg_ctx->status)) if(GSS_ERROR(neg_ctx->status))
return CURLE_OUT_OF_MEMORY; return CURLE_OUT_OF_MEMORY;

4
lib/http_proxy.c
View File

@@ -212,7 +212,7 @@ CURLcode Curl_proxyCONNECT(struct connectdata *conn,
failf(data, "Failed sending CONNECT to proxy"); failf(data, "Failed sending CONNECT to proxy");
} }
Curl_safefree(req_buffer); free(req_buffer);
if(result) if(result)
return result; return result;
@@ -463,7 +463,7 @@ CURLcode Curl_proxyCONNECT(struct connectdata *conn,
result = Curl_http_input_auth(conn, proxy, auth); result = Curl_http_input_auth(conn, proxy, auth);
Curl_safefree(auth); free(auth);
if(result) if(result)
return result; return result;

22
lib/imap.c
View File

@@ -547,8 +547,8 @@ static CURLcode imap_perform_login(struct connectdata *conn)
result = imap_sendf(conn, "LOGIN %s %s", user ? user : "", result = imap_sendf(conn, "LOGIN %s %s", user ? user : "",
passwd ? passwd : ""); passwd ? passwd : "");
Curl_safefree(user); free(user);
Curl_safefree(passwd); free(passwd);
if(!result) if(!result)
state(conn, IMAP_LOGIN); state(conn, IMAP_LOGIN);
@@ -661,7 +661,7 @@ static CURLcode imap_perform_list(struct connectdata *conn)
/* Send the LIST command */ /* Send the LIST command */
result = imap_sendf(conn, "LIST \"%s\" *", mailbox); result = imap_sendf(conn, "LIST \"%s\" *", mailbox);
Curl_safefree(mailbox); free(mailbox);
} }
if(!result) if(!result)
@@ -702,7 +702,7 @@ static CURLcode imap_perform_select(struct connectdata *conn)
/* Send the SELECT command */ /* Send the SELECT command */
result = imap_sendf(conn, "SELECT %s", mailbox); result = imap_sendf(conn, "SELECT %s", mailbox);
Curl_safefree(mailbox); free(mailbox);
if(!result) if(!result)
state(conn, IMAP_SELECT); state(conn, IMAP_SELECT);
@@ -777,7 +777,7 @@ static CURLcode imap_perform_append(struct connectdata *conn)
result = imap_sendf(conn, "APPEND %s (\\Seen) {%" CURL_FORMAT_CURL_OFF_T "}", result = imap_sendf(conn, "APPEND %s (\\Seen) {%" CURL_FORMAT_CURL_OFF_T "}",
mailbox, conn->data->state.infilesize); mailbox, conn->data->state.infilesize);
Curl_safefree(mailbox); free(mailbox);
if(!result) if(!result)
state(conn, IMAP_APPEND); state(conn, IMAP_APPEND);
@@ -1800,7 +1800,7 @@ static CURLcode imap_sendf(struct connectdata *conn, const char *fmt, ...)
result = Curl_pp_vsendf(&imapc->pp, taggedfmt, ap); result = Curl_pp_vsendf(&imapc->pp, taggedfmt, ap);
va_end(ap); va_end(ap);
Curl_safefree(taggedfmt); free(taggedfmt);
return result; return result;
} }
@@ -2031,7 +2031,7 @@ static CURLcode imap_parse_url_path(struct connectdata *conn)
/* Decode the value parameter */ /* Decode the value parameter */
result = Curl_urldecode(data, begin, ptr - begin, &value, &valuelen, TRUE); result = Curl_urldecode(data, begin, ptr - begin, &value, &valuelen, TRUE);
if(result) { if(result) {
Curl_safefree(name); free(name);
return result; return result;
} }
@@ -2070,14 +2070,14 @@ static CURLcode imap_parse_url_path(struct connectdata *conn)
value = NULL; value = NULL;
} }
else { else {
Curl_safefree(name); free(name);
Curl_safefree(value); free(value);
return CURLE_URL_MALFORMAT; return CURLE_URL_MALFORMAT;
} }
Curl_safefree(name); free(name);
Curl_safefree(value); free(value);
} }
/* Does the URL contain a query parameter? Only valid when we have a mailbox /* Does the URL contain a query parameter? Only valid when we have a mailbox

10
lib/ldap.c
View File

@@ -852,7 +852,7 @@ static int _ldap_url_parse2 (const struct connectdata *conn, LDAPURLDesc *ludp)
ludp->lud_attrs = calloc(count + 1, sizeof(char *)); ludp->lud_attrs = calloc(count + 1, sizeof(char *));
#endif #endif
if(!ludp->lud_attrs) { if(!ludp->lud_attrs) {
Curl_safefree(attributes); free(attributes);
rc = LDAP_NO_MEMORY; rc = LDAP_NO_MEMORY;
@@ -867,7 +867,7 @@ static int _ldap_url_parse2 (const struct connectdata *conn, LDAPURLDesc *ludp)
/* Unescape the attribute */ /* Unescape the attribute */
unescaped = curl_easy_unescape(conn->data, attributes[i], 0, NULL); unescaped = curl_easy_unescape(conn->data, attributes[i], 0, NULL);
if(!unescaped) { if(!unescaped) {
Curl_safefree(attributes); free(attributes);
rc = LDAP_NO_MEMORY; rc = LDAP_NO_MEMORY;
@@ -882,7 +882,7 @@ static int _ldap_url_parse2 (const struct connectdata *conn, LDAPURLDesc *ludp)
Curl_unicodefree(unescaped); Curl_unicodefree(unescaped);
if(!ludp->lud_attrs[i]) { if(!ludp->lud_attrs[i]) {
Curl_safefree(attributes); free(attributes);
rc = LDAP_NO_MEMORY; rc = LDAP_NO_MEMORY;
@@ -895,7 +895,7 @@ static int _ldap_url_parse2 (const struct connectdata *conn, LDAPURLDesc *ludp)
ludp->lud_attrs_dups++; ludp->lud_attrs_dups++;
} }
Curl_safefree(attributes); free(attributes);
} }
p = q; p = q;
@@ -965,7 +965,7 @@ static int _ldap_url_parse2 (const struct connectdata *conn, LDAPURLDesc *ludp)
} }
quit: quit:
Curl_safefree(path); free(path);
return rc; return rc;
} }

4
lib/memdebug.h
View File

@@ -8,7 +8,7 @@
* | (__| |_| | _ <| |___ * | (__| |_| | _ <| |___
* \___|\___/|_| \_\_____| * \___|\___/|_| \_\_____|
* *
* Copyright (C) 1998 - 2013, Daniel Stenberg, <daniel@haxx.se>, et al. * Copyright (C) 1998 - 2015, Daniel Stenberg, <daniel@haxx.se>, et al.
* *
* This software is licensed as described in the file COPYING, which * This software is licensed as described in the file COPYING, which
* you should have received as part of this distribution. The terms * you should have received as part of this distribution. The terms
@@ -171,6 +171,6 @@ CURL_EXTERN int curl_fclose(FILE *file, int line, const char *source);
*/ */
#define Curl_safefree(ptr) \ #define Curl_safefree(ptr) \
do {if((ptr)) {free((ptr)); (ptr) = NULL;}} WHILE_FALSE do { free((ptr)); (ptr) = NULL;} WHILE_FALSE
#endif /* HEADER_CURL_MEMDEBUG_H */ #endif /* HEADER_CURL_MEMDEBUG_H */

2
lib/multi.c
View File

@@ -926,7 +926,7 @@ CURLMcode curl_multi_wait(CURLM *multi_handle,
else else
i = 0; i = 0;
Curl_safefree(ufds); free(ufds);
if(ret) if(ret)
*ret = i; *ret = i;
return CURLM_OK; return CURLM_OK;

4
lib/netrc.c
View File

@@ -102,7 +102,7 @@ int Curl_parsenetrc(const char *host,
netrcfile = curl_maprintf("%s%s%s", home, DIR_CHAR, NETRC); netrcfile = curl_maprintf("%s%s%s", home, DIR_CHAR, NETRC);
if(home_alloc) if(home_alloc)
Curl_safefree(home); free(home);
if(!netrcfile) { if(!netrcfile) {
return -1; return -1;
} }
@@ -111,7 +111,7 @@ int Curl_parsenetrc(const char *host,
file = fopen(netrcfile, "r"); file = fopen(netrcfile, "r");
if(netrc_alloc) if(netrc_alloc)
Curl_safefree(netrcfile); free(netrcfile);
if(file) { if(file) {
char *tok; char *tok;
char *tok_buf; char *tok_buf;

8
lib/pipeline.c
View File

@@ -6,7 +6,7 @@
* \___|\___/|_| \_\_____| * \___|\___/|_| \_\_____|
* *
* Copyright (C) 2013, Linus Nielsen Feltzing, <linus@haxx.se> * Copyright (C) 2013, Linus Nielsen Feltzing, <linus@haxx.se>
* Copyright (C) 2013-2014, Daniel Stenberg, <daniel@haxx.se>, et al. * Copyright (C) 2013-2015, Daniel Stenberg, <daniel@haxx.se>, et al.
* *
* This software is licensed as described in the file COPYING, which * This software is licensed as described in the file COPYING, which
* you should have received as part of this distribution. The terms * you should have received as part of this distribution. The terms
@@ -49,15 +49,13 @@ static void site_blacklist_llist_dtor(void *user, void *element)
(void)user; (void)user;
Curl_safefree(entry->hostname); Curl_safefree(entry->hostname);
Curl_safefree(entry); free(entry);
} }
static void server_blacklist_llist_dtor(void *user, void *element) static void server_blacklist_llist_dtor(void *user, void *element)
{ {
char *server_name = element;
(void)user; (void)user;
free(element);
Curl_safefree(server_name);
} }
bool Curl_pipeline_penalized(struct SessionHandle *data, bool Curl_pipeline_penalized(struct SessionHandle *data,

6
lib/smb.c
View File

@@ -935,7 +935,7 @@ static CURLcode smb_parse_url_path(struct connectdata *conn)
/* Parse the path for the share */ /* Parse the path for the share */
req->share = strdup((*path == '/' || *path == '\\') ? path + 1 : path); req->share = strdup((*path == '/' || *path == '\\') ? path + 1 : path);
if(!req->share) { if(!req->share) {
Curl_safefree(path); free(path);
return CURLE_OUT_OF_MEMORY; return CURLE_OUT_OF_MEMORY;
} }
@@ -946,7 +946,7 @@ static CURLcode smb_parse_url_path(struct connectdata *conn)
/* The share must be present */ /* The share must be present */
if(!slash) { if(!slash) {
Curl_safefree(path); free(path);
return CURLE_URL_MALFORMAT; return CURLE_URL_MALFORMAT;
} }
@@ -960,7 +960,7 @@ static CURLcode smb_parse_url_path(struct connectdata *conn)
*slash = '\\'; *slash = '\\';
} }
Curl_safefree(path); free(path);
return CURLE_OK; return CURLE_OK;
} }

16
lib/smtp.c
View File

@@ -571,7 +571,7 @@ static CURLcode smtp_perform_mail(struct connectdata *conn)
auth = strdup("<>"); auth = strdup("<>");
if(!auth) { if(!auth) {
Curl_safefree(from); free(from);
return CURLE_OUT_OF_MEMORY; return CURLE_OUT_OF_MEMORY;
} }
@@ -582,8 +582,8 @@ static CURLcode smtp_perform_mail(struct connectdata *conn)
size = aprintf("%" CURL_FORMAT_CURL_OFF_T, data->state.infilesize); size = aprintf("%" CURL_FORMAT_CURL_OFF_T, data->state.infilesize);
if(!size) { if(!size) {
Curl_safefree(from); free(from);
Curl_safefree(auth); free(auth);
return CURLE_OUT_OF_MEMORY; return CURLE_OUT_OF_MEMORY;
} }
@@ -603,9 +603,9 @@ static CURLcode smtp_perform_mail(struct connectdata *conn)
result = Curl_pp_sendf(&conn->proto.smtpc.pp, result = Curl_pp_sendf(&conn->proto.smtpc.pp,
"MAIL FROM:%s SIZE=%s", from, size); "MAIL FROM:%s SIZE=%s", from, size);
Curl_safefree(from); free(from);
Curl_safefree(auth); free(auth);
Curl_safefree(size); free(size);
if(!result) if(!result)
state(conn, SMTP_MAIL); state(conn, SMTP_MAIL);
@@ -1657,13 +1657,13 @@ CURLcode Curl_smtp_escape_eob(struct connectdata *conn, const ssize_t nread)
data->state.scratch = scratch; data->state.scratch = scratch;
/* Free the old scratch buffer */ /* Free the old scratch buffer */
Curl_safefree(oldscratch); free(oldscratch);
/* Set the new amount too */ /* Set the new amount too */
data->req.upload_present = si; data->req.upload_present = si;
} }
else else
Curl_safefree(newscratch); free(newscratch);
return CURLE_OK; return CURLE_OK;
} }

20
lib/socks_sspi.c
View File

@@ -143,7 +143,7 @@ CURLcode Curl_SOCKS5_gssapi_negotiate(int sockindex,
if(check_sspi_err(conn, status, "AcquireCredentialsHandle")) { if(check_sspi_err(conn, status, "AcquireCredentialsHandle")) {
failf(data, "Failed to acquire credentials."); failf(data, "Failed to acquire credentials.");
Curl_safefree(service_name); free(service_name);
s_pSecFn->FreeCredentialsHandle(&cred_handle); s_pSecFn->FreeCredentialsHandle(&cred_handle);
return CURLE_COULDNT_CONNECT; return CURLE_COULDNT_CONNECT;
} }
@@ -182,7 +182,7 @@ CURLcode Curl_SOCKS5_gssapi_negotiate(int sockindex,
} }
if(check_sspi_err(conn, status, "InitializeSecurityContext")) { if(check_sspi_err(conn, status, "InitializeSecurityContext")) {
Curl_safefree(service_name); free(service_name);
s_pSecFn->FreeCredentialsHandle(&cred_handle); s_pSecFn->FreeCredentialsHandle(&cred_handle);
s_pSecFn->DeleteSecurityContext(&sspi_context); s_pSecFn->DeleteSecurityContext(&sspi_context);
if(sspi_recv_token.pvBuffer) if(sspi_recv_token.pvBuffer)
@@ -200,7 +200,7 @@ CURLcode Curl_SOCKS5_gssapi_negotiate(int sockindex,
code = Curl_write_plain(conn, sock, (char *)socksreq, 4, &written); code = Curl_write_plain(conn, sock, (char *)socksreq, 4, &written);
if(code || (4 != written)) { if(code || (4 != written)) {
failf(data, "Failed to send SSPI authentication request."); failf(data, "Failed to send SSPI authentication request.");
Curl_safefree(service_name); free(service_name);
if(sspi_send_token.pvBuffer) if(sspi_send_token.pvBuffer)
s_pSecFn->FreeContextBuffer(sspi_send_token.pvBuffer); s_pSecFn->FreeContextBuffer(sspi_send_token.pvBuffer);
if(sspi_recv_token.pvBuffer) if(sspi_recv_token.pvBuffer)
@@ -214,7 +214,7 @@ CURLcode Curl_SOCKS5_gssapi_negotiate(int sockindex,
sspi_send_token.cbBuffer, &written); sspi_send_token.cbBuffer, &written);
if(code || (sspi_send_token.cbBuffer != (size_t)written)) { if(code || (sspi_send_token.cbBuffer != (size_t)written)) {
failf(data, "Failed to send SSPI authentication token."); failf(data, "Failed to send SSPI authentication token.");
Curl_safefree(service_name); free(service_name);
if(sspi_send_token.pvBuffer) if(sspi_send_token.pvBuffer)
s_pSecFn->FreeContextBuffer(sspi_send_token.pvBuffer); s_pSecFn->FreeContextBuffer(sspi_send_token.pvBuffer);
if(sspi_recv_token.pvBuffer) if(sspi_recv_token.pvBuffer)
@@ -254,7 +254,7 @@ CURLcode Curl_SOCKS5_gssapi_negotiate(int sockindex,
result = Curl_blockread_all(conn, sock, (char *)socksreq, 4, &actualread); result = Curl_blockread_all(conn, sock, (char *)socksreq, 4, &actualread);
if(result || (actualread != 4)) { if(result || (actualread != 4)) {
failf(data, "Failed to receive SSPI authentication response."); failf(data, "Failed to receive SSPI authentication response.");
Curl_safefree(service_name); free(service_name);
s_pSecFn->FreeCredentialsHandle(&cred_handle); s_pSecFn->FreeCredentialsHandle(&cred_handle);
s_pSecFn->DeleteSecurityContext(&sspi_context); s_pSecFn->DeleteSecurityContext(&sspi_context);
return CURLE_COULDNT_CONNECT; return CURLE_COULDNT_CONNECT;
@@ -264,7 +264,7 @@ CURLcode Curl_SOCKS5_gssapi_negotiate(int sockindex,
if(socksreq[1] == 255) { /* status / message type */ if(socksreq[1] == 255) { /* status / message type */
failf(data, "User was rejected by the SOCKS5 server (%u %u).", failf(data, "User was rejected by the SOCKS5 server (%u %u).",
(unsigned int)socksreq[0], (unsigned int)socksreq[1]); (unsigned int)socksreq[0], (unsigned int)socksreq[1]);
Curl_safefree(service_name); free(service_name);
s_pSecFn->FreeCredentialsHandle(&cred_handle); s_pSecFn->FreeCredentialsHandle(&cred_handle);
s_pSecFn->DeleteSecurityContext(&sspi_context); s_pSecFn->DeleteSecurityContext(&sspi_context);
return CURLE_COULDNT_CONNECT; return CURLE_COULDNT_CONNECT;
@@ -273,7 +273,7 @@ CURLcode Curl_SOCKS5_gssapi_negotiate(int sockindex,
if(socksreq[1] != 1) { /* status / messgae type */ if(socksreq[1] != 1) { /* status / messgae type */
failf(data, "Invalid SSPI authentication response type (%u %u).", failf(data, "Invalid SSPI authentication response type (%u %u).",
(unsigned int)socksreq[0], (unsigned int)socksreq[1]); (unsigned int)socksreq[0], (unsigned int)socksreq[1]);
Curl_safefree(service_name); free(service_name);
s_pSecFn->FreeCredentialsHandle(&cred_handle); s_pSecFn->FreeCredentialsHandle(&cred_handle);
s_pSecFn->DeleteSecurityContext(&sspi_context); s_pSecFn->DeleteSecurityContext(&sspi_context);
return CURLE_COULDNT_CONNECT; return CURLE_COULDNT_CONNECT;
@@ -286,7 +286,7 @@ CURLcode Curl_SOCKS5_gssapi_negotiate(int sockindex,
sspi_recv_token.pvBuffer = malloc(us_length); sspi_recv_token.pvBuffer = malloc(us_length);
if(!sspi_recv_token.pvBuffer) { if(!sspi_recv_token.pvBuffer) {
Curl_safefree(service_name); free(service_name);
s_pSecFn->FreeCredentialsHandle(&cred_handle); s_pSecFn->FreeCredentialsHandle(&cred_handle);
s_pSecFn->DeleteSecurityContext(&sspi_context); s_pSecFn->DeleteSecurityContext(&sspi_context);
return CURLE_OUT_OF_MEMORY; return CURLE_OUT_OF_MEMORY;
@@ -296,7 +296,7 @@ CURLcode Curl_SOCKS5_gssapi_negotiate(int sockindex,
if(result || (actualread != us_length)) { if(result || (actualread != us_length)) {
failf(data, "Failed to receive SSPI authentication token."); failf(data, "Failed to receive SSPI authentication token.");
Curl_safefree(service_name); free(service_name);
if(sspi_recv_token.pvBuffer) if(sspi_recv_token.pvBuffer)
s_pSecFn->FreeContextBuffer(sspi_recv_token.pvBuffer); s_pSecFn->FreeContextBuffer(sspi_recv_token.pvBuffer);
s_pSecFn->FreeCredentialsHandle(&cred_handle); s_pSecFn->FreeCredentialsHandle(&cred_handle);
@@ -307,7 +307,7 @@ CURLcode Curl_SOCKS5_gssapi_negotiate(int sockindex,
context_handle = &sspi_context; context_handle = &sspi_context;
} }
Curl_safefree(service_name); free(service_name);
/* Everything is good so far, user was authenticated! */ /* Everything is good so far, user was authenticated! */
status = s_pSecFn->QueryCredentialsAttributes(&cred_handle, status = s_pSecFn->QueryCredentialsAttributes(&cred_handle,

10
lib/ssh.c
View File

@@ -855,7 +855,7 @@ static CURLcode ssh_statemach_act(struct connectdata *conn, bool *block)
} }
if(out_of_memory || sshc->rsa == NULL) { if(out_of_memory || sshc->rsa == NULL) {
Curl_safefree(home); free(home);
Curl_safefree(sshc->rsa); Curl_safefree(sshc->rsa);
Curl_safefree(sshc->rsa_pub); Curl_safefree(sshc->rsa_pub);
state(conn, SSH_SESSION_FREE); state(conn, SSH_SESSION_FREE);
@@ -867,7 +867,7 @@ static CURLcode ssh_statemach_act(struct connectdata *conn, bool *block)
if(!sshc->passphrase) if(!sshc->passphrase)
sshc->passphrase = ""; sshc->passphrase = "";
Curl_safefree(home); free(home);
infof(data, "Using SSH public key file '%s'\n", sshc->rsa_pub); infof(data, "Using SSH public key file '%s'\n", sshc->rsa_pub);
infof(data, "Using SSH private key file '%s'\n", sshc->rsa); infof(data, "Using SSH private key file '%s'\n", sshc->rsa);
@@ -1918,7 +1918,7 @@ static CURLcode ssh_statemach_act(struct connectdata *conn, bool *block)
} }
result = Curl_client_write(conn, CLIENTWRITE_BODY, result = Curl_client_write(conn, CLIENTWRITE_BODY,
tmpLine, sshc->readdir_len+1); tmpLine, sshc->readdir_len+1);
Curl_safefree(tmpLine); free(tmpLine);
if(result) { if(result) {
state(conn, SSH_STOP); state(conn, SSH_STOP);
@@ -3267,8 +3267,8 @@ get_pathname(const char **cpp, char **path)
return CURLE_OK; return CURLE_OK;
fail: fail:
Curl_safefree(*path); Curl_safefree(*path);
return CURLE_QUOTE_ERROR; return CURLE_QUOTE_ERROR;
} }

2
lib/tftp.c
View File

@@ -531,7 +531,7 @@ static CURLcode tftp_send_first(tftp_state_data_t *state, tftp_event_t event)
if(senddata != (ssize_t)sbytes) { if(senddata != (ssize_t)sbytes) {
failf(data, "%s", Curl_strerror(state->conn, SOCKERRNO)); failf(data, "%s", Curl_strerror(state->conn, SOCKERRNO));
} }
Curl_safefree(filename); free(filename);
break; break;
case TFTP_EVENT_OACK: case TFTP_EVENT_OACK:

35
lib/url.c
View File

@@ -1235,7 +1235,7 @@ CURLcode Curl_setopt(struct SessionHandle *data, CURLoption option,
argptr = strdup(argptr); argptr = strdup(argptr);
if(!argptr || !data->cookies) { if(!argptr || !data->cookies) {
result = CURLE_OUT_OF_MEMORY; result = CURLE_OUT_OF_MEMORY;
Curl_safefree(argptr); free(argptr);
} }
else { else {
Curl_share_lock(data, CURL_LOCK_DATA_COOKIE, CURL_LOCK_ACCESS_SINGLE); Curl_share_lock(data, CURL_LOCK_DATA_COOKIE, CURL_LOCK_ACCESS_SINGLE);
@@ -3780,9 +3780,9 @@ static struct connectdata *allocate_conn(struct SessionHandle *data)
conn->send_pipe = NULL; conn->send_pipe = NULL;
conn->recv_pipe = NULL; conn->recv_pipe = NULL;
Curl_safefree(conn->master_buffer); free(conn->master_buffer);
Curl_safefree(conn->localdev); free(conn->localdev);
Curl_safefree(conn); free(conn);
return NULL; return NULL;
} }
@@ -4508,8 +4508,8 @@ static CURLcode parse_proxy(struct SessionHandle *data,
} }
} }
Curl_safefree(proxyuser); free(proxyuser);
Curl_safefree(proxypasswd); free(proxypasswd);
if(result) if(result)
return result; return result;
@@ -4721,9 +4721,9 @@ static CURLcode parse_url_login(struct SessionHandle *data,
out: out:
Curl_safefree(userp); free(userp);
Curl_safefree(passwdp); free(passwdp);
Curl_safefree(optionsp); free(optionsp);
return result; return result;
} }
@@ -4811,7 +4811,7 @@ static CURLcode parse_login_details(const char *login, const size_t len,
if(!result && passwdp && plen) { if(!result && passwdp && plen) {
pbuf = malloc(plen + 1); pbuf = malloc(plen + 1);
if(!pbuf) { if(!pbuf) {
Curl_safefree(ubuf); free(ubuf);
result = CURLE_OUT_OF_MEMORY; result = CURLE_OUT_OF_MEMORY;
} }
} }
@@ -4820,8 +4820,8 @@ static CURLcode parse_login_details(const char *login, const size_t len,
if(!result && optionsp && olen) { if(!result && optionsp && olen) {
obuf = malloc(olen + 1); obuf = malloc(olen + 1);
if(!obuf) { if(!obuf) {
Curl_safefree(pbuf); free(pbuf);
Curl_safefree(ubuf); free(ubuf);
result = CURLE_OUT_OF_MEMORY; result = CURLE_OUT_OF_MEMORY;
} }
} }
@@ -5459,7 +5459,8 @@ static CURLcode create_conn(struct SessionHandle *data,
if(proxy) { if(proxy) {
result = parse_proxy(data, conn, proxy); result = parse_proxy(data, conn, proxy);
Curl_safefree(proxy); /* parse_proxy copies the proxy string */ free(proxy); /* parse_proxy copies the proxy string */
proxy = NULL;
if(result) if(result)
goto out; goto out;
@@ -5759,10 +5760,10 @@ static CURLcode create_conn(struct SessionHandle *data,
out: out:
Curl_safefree(options); free(options);
Curl_safefree(passwd); free(passwd);
Curl_safefree(user); free(user);
Curl_safefree(proxy); free(proxy);
return result; return result;
} }

2
tests/data/test96
View File

@@ -37,7 +37,7 @@ MEM tool_cfgable.c
MEM tool_cfgable.c MEM tool_cfgable.c
</file> </file>
<stripfile> <stripfile>
$_ = '' if (($_ !~ /tool_paramhlp/) && ($_ !~ /tool_cfgable/)) $_ = '' if ((($_ !~ /tool_paramhlp/) && ($_ !~ /tool_cfgable/)) || ($_ =~ /free\(\(nil\)\)/))
s/:\d+.*// s/:\d+.*//
s:^(MEM )(.*/)(.*):$1$3: s:^(MEM )(.*/)(.*):$1$3:
</stripfile> </stripfile>