free: instead of Curl_safefree()
Since we just started make use of free(NULL) in order to simplify code, this change takes it a step further and: - converts lots of Curl_safefree() calls to good old free() - makes Curl_safefree() not check the pointer before free() The (new) rule of thumb is: if you really want a function call that frees a pointer and then assigns it to NULL, then use Curl_safefree(). But we will prefer just using free() from now on.
This commit is contained in:
@@ -935,7 +935,7 @@ static CURLcode smb_parse_url_path(struct connectdata *conn)
|
||||
/* Parse the path for the share */
|
||||
req->share = strdup((*path == '/' || *path == '\\') ? path + 1 : path);
|
||||
if(!req->share) {
|
||||
Curl_safefree(path);
|
||||
free(path);
|
||||
|
||||
return CURLE_OUT_OF_MEMORY;
|
||||
}
|
||||
@@ -946,7 +946,7 @@ static CURLcode smb_parse_url_path(struct connectdata *conn)
|
||||
|
||||
/* The share must be present */
|
||||
if(!slash) {
|
||||
Curl_safefree(path);
|
||||
free(path);
|
||||
|
||||
return CURLE_URL_MALFORMAT;
|
||||
}
|
||||
@@ -960,7 +960,7 @@ static CURLcode smb_parse_url_path(struct connectdata *conn)
|
||||
*slash = '\\';
|
||||
}
|
||||
|
||||
Curl_safefree(path);
|
||||
free(path);
|
||||
|
||||
return CURLE_OK;
|
||||
}
|
||||
|
Reference in New Issue
Block a user