generic-library/curl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

formadd: wrong pointer for file name when CURLFORM_BUFFERPTR used

Browse Source 
The internal function that's used to detect known file extensions for
the default Content-Type got the the wrong pointer passed in when
CURLFORM_BUFFER + CURLFORM_BUFFERPTR were used. This had the effect that
strlen() would be used which could lead to an out-of-bounds read (and
thus segfault). In most cases it would only lead to it not finding or
using the correct default content-type.

It also showed that test 554 and test 587 were testing for the
previous/wrong behavior and now they're updated as well.

Bug: http://curl.haxx.se/bug/view.cgi?id=1262
Reported-by: Konstantin Isakov
This commit is contained in:
Daniel Stenberg
2013-08-04 23:27:27 +02:00
parent 51f0b798fa
commit 0ddc678927
3 changed files with 10 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tests/data/test587
View File

@@ -35,7 +35,7 @@ s/boundary=------------------------[a-z0-9]*/boundary=--------------------------
POST /587 HTTP/1.1
Host: %HOSTIP:%HTTPPORT
Accept: */*
Content-Length: 732
Content-Length: 718
Expect: 100-continue
Content-Type: multipart/form-data; boundary=----------------------------