generic-library/curl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

test1520: Fixed initial teething problems

Browse Source 
* Missing initialisation of upload status caused a seg fault
* Missing data termination caused corrupt data to be uploaded
* Data verification should be performed in <upload> element
* Added missing recipient list cleanup
This commit is contained in:
Steve Holme 2014-12-28 13:01:11 +00:00
parent 9459ee99ae
commit 0d037cfdce
2 changed files with 17 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tests/data/test1520
View File

@ -44,6 +44,9 @@ EHLO 1520
MAIL FROM:<sender@example.com> MAIL FROM:<sender@example.com>
RCPT TO:<recipient@example.com> RCPT TO:<recipient@example.com>
DATA DATA
QUIT
</protocol>
<upload>
From: different From: different
To: another To: another
@ -54,6 +57,7 @@ To: another
.. ..
body body
</protocol> .
</upload>
</verify> </verify>
</testcase> </testcase>

22
tests/libtest/lib1520.c
View File

@ -30,16 +30,17 @@
#define FROM "<sender@example.com>" #define FROM "<sender@example.com>"
static const char *payload_text[] = { static const char *payload_text[] = {
"From: different\r\n", "From: different\r\n",
"To: another\r\n", "To: another\r\n",
"\r\n", "\r\n",
"\r\n", "\r\n",
".\r\n", ".\r\n",
".\r\n", ".\r\n",
"\r\n", "\r\n",
".\r\n", ".\r\n",
"\r\n", "\r\n",
"body" "body",
NULL
}; };
struct upload_status { struct upload_status {
@ -103,6 +104,7 @@ int test(char *URL)
test_cleanup: test_cleanup:
curl_slist_free_all(rcpt_list);
curl_easy_cleanup(curl); curl_easy_cleanup(curl);
curl_global_cleanup(); curl_global_cleanup();