Bryan Henderson fixed the progress function so that it can get called
more frequently allowing same calling frecuency for the client progress callback, while keeping the once a second frecuency for speed calculations and internal display of the transfer progress.
This commit is contained in:
Yang Tse
4
CHANGES
4
CHANGES
@@ -6,6 +6,10 @@
|
|||||||
|
|
||||||
Changelog
|
Changelog
|
||||||
|
|
||||||
|
Yang Tse (19 March 2007)
|
||||||
|
- Bryan Henderson fixed the progress function so that it can get called more
|
||||||
|
frequently allowing same calling frecuency for the client progress callback.
|
||||||
|
|
||||||
Dan F (15 March 2007)
|
Dan F (15 March 2007)
|
||||||
- Various memory leaks plugged and NULL pointer fixes made in the ssh code.
|
- Various memory leaks plugged and NULL pointer fixes made in the ssh code.
|
||||||
|
|
||||||
|
|||||||
@@ -41,6 +41,7 @@ This release includes the following bugfixes:
|
|||||||
o CURLOPT_PORT, HTTP proxy, re-using connections and non-HTTP protocols
|
o CURLOPT_PORT, HTTP proxy, re-using connections and non-HTTP protocols
|
||||||
o CURLOPT_INTERFACE for ipv6
|
o CURLOPT_INTERFACE for ipv6
|
||||||
o use-after-free issue with HTTP transfers with the multi interface
|
o use-after-free issue with HTTP transfers with the multi interface
|
||||||
|
o the progress callback can get called more frequently
|
||||||
|
|
||||||
This release includes the following known bugs:
|
This release includes the following known bugs:
|
||||||
|
|
||||||
|
|||||||
296
lib/progress.c
296
lib/progress.c
@@ -5,7 +5,7 @@
|
|||||||
* | (__| |_| | _ <| |___
|
* | (__| |_| | _ <| |___
|
||||||
* \___|\___/|_| \_\_____|
|
* \___|\___/|_| \_\_____|
|
||||||
*
|
*
|
||||||
* Copyright (C) 1998 - 2006, Daniel Stenberg, <daniel@haxx.se>, et al.
|
* Copyright (C) 1998 - 2007, Daniel Stenberg, <daniel@haxx.se>, et al.
|
||||||
*
|
*
|
||||||
* This software is licensed as described in the file COPYING, which
|
* This software is licensed as described in the file COPYING, which
|
||||||
* you should have received as part of this distribution. The terms
|
* you should have received as part of this distribution. The terms
|
||||||
@@ -246,24 +246,6 @@ int Curl_pgrsUpdate(struct connectdata *conn)
|
|||||||
long dlestimate=0;
|
long dlestimate=0;
|
||||||
long total_estimate;
|
long total_estimate;
|
||||||
|
|
||||||
if(data->progress.flags & PGRS_HIDE)
|
|
||||||
; /* We do enter this function even if we don't wanna see anything, since
|
|
||||||
this is were lots of the calculations are being made that will be used
|
|
||||||
even when not displayed! */
|
|
||||||
else if(!(data->progress.flags & PGRS_HEADERS_OUT)) {
|
|
||||||
if (!data->progress.callback) {
|
|
||||||
if(data->reqdata.resume_from)
|
|
||||||
fprintf(data->set.err,
|
|
||||||
"** Resuming transfer from byte position %" FORMAT_OFF_T
|
|
||||||
"\n",
|
|
||||||
data->reqdata.resume_from);
|
|
||||||
fprintf(data->set.err,
|
|
||||||
" %% Total %% Received %% Xferd Average Speed Time Time Time Current\n"
|
|
||||||
" Dload Upload Total Spent Left Speed\n");
|
|
||||||
}
|
|
||||||
data->progress.flags |= PGRS_HEADERS_OUT; /* headers are shown */
|
|
||||||
}
|
|
||||||
|
|
||||||
now = Curl_tvnow(); /* what time is it */
|
now = Curl_tvnow(); /* what time is it */
|
||||||
|
|
||||||
/* The time spent so far (from the start) */
|
/* The time spent so far (from the start) */
|
||||||
@@ -280,145 +262,165 @@ int Curl_pgrsUpdate(struct connectdata *conn)
|
|||||||
((double)data->progress.uploaded/
|
((double)data->progress.uploaded/
|
||||||
(data->progress.timespent>0?data->progress.timespent:1));
|
(data->progress.timespent>0?data->progress.timespent:1));
|
||||||
|
|
||||||
if(data->progress.lastshow == Curl_tvlong(now))
|
/* Calculations done at most once a second, unless end is reached */
|
||||||
return 0; /* never update this more than once a second if the end isn't
|
if(data->progress.lastshow != Curl_tvlong(now)) {
|
||||||
reached */
|
|
||||||
data->progress.lastshow = now.tv_sec;
|
|
||||||
|
|
||||||
/* Let's do the "current speed" thing, which should use the fastest
|
data->progress.lastshow = now.tv_sec;
|
||||||
of the dl/ul speeds. Store the fasted speed at entry 'nowindex'. */
|
|
||||||
data->progress.speeder[ nowindex ] =
|
|
||||||
data->progress.downloaded>data->progress.uploaded?
|
|
||||||
data->progress.downloaded:data->progress.uploaded;
|
|
||||||
|
|
||||||
/* remember the exact time for this moment */
|
/* Let's do the "current speed" thing, which should use the fastest
|
||||||
data->progress.speeder_time [ nowindex ] = now;
|
of the dl/ul speeds. Store the fasted speed at entry 'nowindex'. */
|
||||||
|
data->progress.speeder[ nowindex ] =
|
||||||
|
data->progress.downloaded>data->progress.uploaded?
|
||||||
|
data->progress.downloaded:data->progress.uploaded;
|
||||||
|
|
||||||
/* advance our speeder_c counter, which is increased every time we get
|
/* remember the exact time for this moment */
|
||||||
here and we expect it to never wrap as 2^32 is a lot of seconds! */
|
data->progress.speeder_time [ nowindex ] = now;
|
||||||
data->progress.speeder_c++;
|
|
||||||
|
|
||||||
/* figure out how many index entries of data we have stored in our speeder
|
/* advance our speeder_c counter, which is increased every time we get
|
||||||
array. With N_ENTRIES filled in, we have about N_ENTRIES-1 seconds of
|
here and we expect it to never wrap as 2^32 is a lot of seconds! */
|
||||||
transfer. Imagine, after one second we have filled in two entries,
|
data->progress.speeder_c++;
|
||||||
after two seconds we've filled in three entries etc. */
|
|
||||||
countindex = ((data->progress.speeder_c>=CURR_TIME)?
|
|
||||||
CURR_TIME:data->progress.speeder_c) - 1;
|
|
||||||
|
|
||||||
/* first of all, we don't do this if there's no counted seconds yet */
|
/* figure out how many index entries of data we have stored in our speeder
|
||||||
if(countindex) {
|
array. With N_ENTRIES filled in, we have about N_ENTRIES-1 seconds of
|
||||||
long span_ms;
|
transfer. Imagine, after one second we have filled in two entries,
|
||||||
|
after two seconds we've filled in three entries etc. */
|
||||||
|
countindex = ((data->progress.speeder_c>=CURR_TIME)?
|
||||||
|
CURR_TIME:data->progress.speeder_c) - 1;
|
||||||
|
|
||||||
/* Get the index position to compare with the 'nowindex' position.
|
/* first of all, we don't do this if there's no counted seconds yet */
|
||||||
Get the oldest entry possible. While we have less than CURR_TIME
|
if(countindex) {
|
||||||
entries, the first entry will remain the oldest. */
|
long span_ms;
|
||||||
checkindex = (data->progress.speeder_c>=CURR_TIME)?
|
|
||||||
data->progress.speeder_c%CURR_TIME:0;
|
|
||||||
|
|
||||||
/* Figure out the exact time for the time span */
|
/* Get the index position to compare with the 'nowindex' position.
|
||||||
span_ms = Curl_tvdiff(now,
|
Get the oldest entry possible. While we have less than CURR_TIME
|
||||||
data->progress.speeder_time[checkindex]);
|
entries, the first entry will remain the oldest. */
|
||||||
if(0 == span_ms)
|
checkindex = (data->progress.speeder_c>=CURR_TIME)?
|
||||||
span_ms=1; /* at least one millisecond MUST have passed */
|
data->progress.speeder_c%CURR_TIME:0;
|
||||||
|
|
||||||
/* Calculate the average speed the last 'span_ms' milliseconds */
|
/* Figure out the exact time for the time span */
|
||||||
{
|
span_ms = Curl_tvdiff(now,
|
||||||
curl_off_t amount = data->progress.speeder[nowindex]-
|
data->progress.speeder_time[checkindex]);
|
||||||
data->progress.speeder[checkindex];
|
if(0 == span_ms)
|
||||||
|
span_ms=1; /* at least one millisecond MUST have passed */
|
||||||
|
|
||||||
if(amount > 4294967 /* 0xffffffff/1000 */)
|
/* Calculate the average speed the last 'span_ms' milliseconds */
|
||||||
/* the 'amount' value is bigger than would fit in 32 bits if
|
{
|
||||||
multiplied with 1000, so we use the double math for this */
|
curl_off_t amount = data->progress.speeder[nowindex]-
|
||||||
data->progress.current_speed = (curl_off_t)
|
data->progress.speeder[checkindex];
|
||||||
((double)amount/((double)span_ms/1000.0));
|
|
||||||
else
|
if(amount > 4294967 /* 0xffffffff/1000 */)
|
||||||
/* the 'amount' value is small enough to fit within 32 bits even
|
/* the 'amount' value is bigger than would fit in 32 bits if
|
||||||
when multiplied with 1000 */
|
multiplied with 1000, so we use the double math for this */
|
||||||
data->progress.current_speed = amount*1000/span_ms;
|
data->progress.current_speed = (curl_off_t)
|
||||||
|
((double)amount/((double)span_ms/1000.0));
|
||||||
|
else
|
||||||
|
/* the 'amount' value is small enough to fit within 32 bits even
|
||||||
|
when multiplied with 1000 */
|
||||||
|
data->progress.current_speed = amount*1000/span_ms;
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
else
|
||||||
|
/* the first second we use the main average */
|
||||||
|
data->progress.current_speed =
|
||||||
|
(data->progress.ulspeed>data->progress.dlspeed)?
|
||||||
|
data->progress.ulspeed:data->progress.dlspeed;
|
||||||
|
|
||||||
|
} /* Calculations end */
|
||||||
|
|
||||||
|
if(!(data->progress.flags & PGRS_HIDE)) {
|
||||||
|
|
||||||
|
/* progress meter has not been shut off */
|
||||||
|
|
||||||
|
if(data->set.fprogress) {
|
||||||
|
/* There's a callback set, so we call that instead of writing
|
||||||
|
anything ourselves. This really is the way to go. */
|
||||||
|
result= data->set.fprogress(data->set.progress_client,
|
||||||
|
(double)data->progress.size_dl,
|
||||||
|
(double)data->progress.downloaded,
|
||||||
|
(double)data->progress.size_ul,
|
||||||
|
(double)data->progress.uploaded);
|
||||||
|
if(result)
|
||||||
|
failf(data, "Callback aborted");
|
||||||
|
return result;
|
||||||
|
}
|
||||||
|
|
||||||
|
/* If there's no external callback set, use internal code to show progress */
|
||||||
|
|
||||||
|
if(!(data->progress.flags & PGRS_HEADERS_OUT)) {
|
||||||
|
if(data->reqdata.resume_from) {
|
||||||
|
fprintf(data->set.err,
|
||||||
|
"** Resuming transfer from byte position %" FORMAT_OFF_T
|
||||||
|
"\n",
|
||||||
|
data->reqdata.resume_from);
|
||||||
|
}
|
||||||
|
fprintf(data->set.err,
|
||||||
|
" %% Total %% Received %% Xferd Average Speed Time Time Time Current\n"
|
||||||
|
" Dload Upload Total Spent Left Speed\n");
|
||||||
|
data->progress.flags |= PGRS_HEADERS_OUT; /* headers are shown */
|
||||||
|
}
|
||||||
|
|
||||||
|
/* Figure out the estimated time of arrival for the upload */
|
||||||
|
if((data->progress.flags & PGRS_UL_SIZE_KNOWN) &&
|
||||||
|
(data->progress.ulspeed>0) &&
|
||||||
|
(data->progress.size_ul > 100) ) {
|
||||||
|
ulestimate = (long)(data->progress.size_ul / data->progress.ulspeed);
|
||||||
|
ulpercen = (int)(100*(data->progress.uploaded/100) /
|
||||||
|
(data->progress.size_ul/100) );
|
||||||
|
}
|
||||||
|
|
||||||
|
/* ... and the download */
|
||||||
|
if((data->progress.flags & PGRS_DL_SIZE_KNOWN) &&
|
||||||
|
(data->progress.dlspeed>0) &&
|
||||||
|
(data->progress.size_dl>100)) {
|
||||||
|
dlestimate = (long)(data->progress.size_dl / data->progress.dlspeed);
|
||||||
|
dlpercen = (int)(100*(data->progress.downloaded/100) /
|
||||||
|
(data->progress.size_dl/100));
|
||||||
|
}
|
||||||
|
|
||||||
|
/* Now figure out which of them that is slower and use for the for
|
||||||
|
total estimate! */
|
||||||
|
total_estimate = ulestimate>dlestimate?ulestimate:dlestimate;
|
||||||
|
|
||||||
|
/* create the three time strings */
|
||||||
|
time2str(time_left, total_estimate > 0?(total_estimate - timespent):0);
|
||||||
|
time2str(time_total, total_estimate);
|
||||||
|
time2str(time_spent, timespent);
|
||||||
|
|
||||||
|
/* Get the total amount of data expected to get transfered */
|
||||||
|
total_expected_transfer =
|
||||||
|
(data->progress.flags & PGRS_UL_SIZE_KNOWN?
|
||||||
|
data->progress.size_ul:data->progress.uploaded)+
|
||||||
|
(data->progress.flags & PGRS_DL_SIZE_KNOWN?
|
||||||
|
data->progress.size_dl:data->progress.downloaded);
|
||||||
|
|
||||||
|
/* We have transfered this much so far */
|
||||||
|
total_transfer = data->progress.downloaded + data->progress.uploaded;
|
||||||
|
|
||||||
|
/* Get the percentage of data transfered so far */
|
||||||
|
if(total_expected_transfer > 100)
|
||||||
|
total_percen=(int)(100*(total_transfer/100) /
|
||||||
|
(total_expected_transfer/100) );
|
||||||
|
|
||||||
|
fprintf(data->set.err,
|
||||||
|
"\r%3d %s %3d %s %3d %s %s %s %s %s %s %s",
|
||||||
|
total_percen, /* 3 letters */ /* total % */
|
||||||
|
max5data(total_expected_transfer, max5[2]), /* total size */
|
||||||
|
dlpercen, /* 3 letters */ /* rcvd % */
|
||||||
|
max5data(data->progress.downloaded, max5[0]), /* rcvd size */
|
||||||
|
ulpercen, /* 3 letters */ /* xfer % */
|
||||||
|
max5data(data->progress.uploaded, max5[1]), /* xfer size */
|
||||||
|
max5data(data->progress.dlspeed, max5[3]), /* avrg dl speed */
|
||||||
|
max5data(data->progress.ulspeed, max5[4]), /* avrg ul speed */
|
||||||
|
time_total, /* 8 letters */ /* total time */
|
||||||
|
time_spent, /* 8 letters */ /* time spent */
|
||||||
|
time_left, /* 8 letters */ /* time left */
|
||||||
|
max5data(data->progress.current_speed, max5[5]) /* current speed */
|
||||||
|
);
|
||||||
|
|
||||||
|
/* we flush the output stream to make it appear as soon as possible */
|
||||||
|
fflush(data->set.err);
|
||||||
|
|
||||||
}
|
}
|
||||||
else
|
|
||||||
/* the first second we use the main average */
|
|
||||||
data->progress.current_speed =
|
|
||||||
(data->progress.ulspeed>data->progress.dlspeed)?
|
|
||||||
data->progress.ulspeed:data->progress.dlspeed;
|
|
||||||
|
|
||||||
if(data->progress.flags & PGRS_HIDE)
|
|
||||||
return 0;
|
|
||||||
|
|
||||||
else if(data->set.fprogress) {
|
|
||||||
/* There's a callback set, so we call that instead of writing
|
|
||||||
anything ourselves. This really is the way to go. */
|
|
||||||
result= data->set.fprogress(data->set.progress_client,
|
|
||||||
(double)data->progress.size_dl,
|
|
||||||
(double)data->progress.downloaded,
|
|
||||||
(double)data->progress.size_ul,
|
|
||||||
(double)data->progress.uploaded);
|
|
||||||
if(result)
|
|
||||||
failf(data, "Callback aborted");
|
|
||||||
return result;
|
|
||||||
}
|
|
||||||
|
|
||||||
/* Figure out the estimated time of arrival for the upload */
|
|
||||||
if((data->progress.flags & PGRS_UL_SIZE_KNOWN) &&
|
|
||||||
(data->progress.ulspeed>0) &&
|
|
||||||
(data->progress.size_ul > 100) ) {
|
|
||||||
ulestimate = (long)(data->progress.size_ul / data->progress.ulspeed);
|
|
||||||
ulpercen = (int)(100*(data->progress.uploaded/100) /
|
|
||||||
(data->progress.size_ul/100) );
|
|
||||||
}
|
|
||||||
|
|
||||||
/* ... and the download */
|
|
||||||
if((data->progress.flags & PGRS_DL_SIZE_KNOWN) &&
|
|
||||||
(data->progress.dlspeed>0) &&
|
|
||||||
(data->progress.size_dl>100)) {
|
|
||||||
dlestimate = (long)(data->progress.size_dl / data->progress.dlspeed);
|
|
||||||
dlpercen = (int)(100*(data->progress.downloaded/100) /
|
|
||||||
(data->progress.size_dl/100));
|
|
||||||
}
|
|
||||||
|
|
||||||
/* Now figure out which of them that is slower and use for the for
|
|
||||||
total estimate! */
|
|
||||||
total_estimate = ulestimate>dlestimate?ulestimate:dlestimate;
|
|
||||||
|
|
||||||
/* create the three time strings */
|
|
||||||
time2str(time_left, total_estimate > 0?(total_estimate - timespent):0);
|
|
||||||
time2str(time_total, total_estimate);
|
|
||||||
time2str(time_spent, timespent);
|
|
||||||
|
|
||||||
/* Get the total amount of data expected to get transfered */
|
|
||||||
total_expected_transfer =
|
|
||||||
(data->progress.flags & PGRS_UL_SIZE_KNOWN?
|
|
||||||
data->progress.size_ul:data->progress.uploaded)+
|
|
||||||
(data->progress.flags & PGRS_DL_SIZE_KNOWN?
|
|
||||||
data->progress.size_dl:data->progress.downloaded);
|
|
||||||
|
|
||||||
/* We have transfered this much so far */
|
|
||||||
total_transfer = data->progress.downloaded + data->progress.uploaded;
|
|
||||||
|
|
||||||
/* Get the percentage of data transfered so far */
|
|
||||||
if(total_expected_transfer > 100)
|
|
||||||
total_percen=(int)(100*(total_transfer/100) /
|
|
||||||
(total_expected_transfer/100) );
|
|
||||||
|
|
||||||
fprintf(data->set.err,
|
|
||||||
"\r%3d %s %3d %s %3d %s %s %s %s %s %s %s",
|
|
||||||
total_percen, /* 3 letters */ /* total % */
|
|
||||||
max5data(total_expected_transfer, max5[2]), /* total size */
|
|
||||||
dlpercen, /* 3 letters */ /* rcvd % */
|
|
||||||
max5data(data->progress.downloaded, max5[0]), /* rcvd size */
|
|
||||||
ulpercen, /* 3 letters */ /* xfer % */
|
|
||||||
max5data(data->progress.uploaded, max5[1]), /* xfer size */
|
|
||||||
max5data(data->progress.dlspeed, max5[3]), /* avrg dl speed */
|
|
||||||
max5data(data->progress.ulspeed, max5[4]), /* avrg ul speed */
|
|
||||||
time_total, /* 8 letters */ /* total time */
|
|
||||||
time_spent, /* 8 letters */ /* time spent */
|
|
||||||
time_left, /* 8 letters */ /* time left */
|
|
||||||
max5data(data->progress.current_speed, max5[5]) /* current speed */
|
|
||||||
);
|
|
||||||
|
|
||||||
/* we flush the output stream to make it appear as soon as possible */
|
|
||||||
fflush(data->set.err);
|
|
||||||
|
|
||||||
return 0;
|
return 0;
|
||||||
}
|
}
|
||||||
|
|||||||
Reference in New Issue
Block a user