ftp_state_pasv_resp: connect through proxy also when set by env

When connecting back to an FTP server after having sent PASV/EPSV,
libcurl sometimes didn't use the proxy properly even though the proxy
was used for the initial connect.

The function wrongly checked for the CURLOPT_PROXY variable to be set,
which made it act wrongly if the proxy information was set with an
environment variable.

Added test case 711 to verify (based on 707 which uses --socks5). Also
added test712 to verify another variation of setting the proxy: with
--proxy socks5://

Bug: http://curl.haxx.se/bug/view.cgi?id=1218
Reported-by: Zekun Ni
This commit is contained in:
Daniel Stenberg
2013-04-26 16:45:31 +02:00
parent b37b5233ca
commit 0523152ad6
4 changed files with 106 additions and 7 deletions

49
tests/data/test712 Normal file
View File

@@ -0,0 +1,49 @@
<testcase>
#based off test 707 after bug report #1218
<info>
<keywords>
FTP
PASV
RETR
SOCKS5
all_proxy
</keywords>
</info>
#
# Server-side
<reply>
<data>
silly content
</data>
</reply>
#
# Client-side
<client>
<server>
ftp
socks5
</server>
<name>
FTP fetch with --proxy set to socks5://
</name>
<command>
ftp://%HOSTIP:%FTPPORT/712 --proxy socks5://%HOSTIP:%SOCKSPORT
</command>
</client>
#
# Verify data after the test has been "shot"
<verify>
<protocol>
USER anonymous
PASS ftp@example.com
PWD
EPSV
TYPE I
SIZE 712
RETR 712
QUIT
</protocol>
</verify>
</testcase>