generic-library/curl
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

imap: Minor tidy up of comments in imap_parse_url_path()

Browse Source 
Tidy up of comments before next round of imap changes.
This commit is contained in:
Steve Holme
2013-02-25 15:53:24 +00:00
parent e63c33d88d
commit 015ceb4706
1 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
lib/imap.c
View File

@@ -1720,7 +1720,7 @@ static CURLcode imap_parse_url_path(struct connectdata *conn)
char *value; char *value;
size_t valuelen; size_t valuelen;
/* Decode the parameter name */ /* Find the length of the name parameter */
begin = ++ptr; begin = ++ptr;
while(*ptr && *ptr != '=') while(*ptr && *ptr != '=')
ptr++; ptr++;
@@ -1728,16 +1728,17 @@ static CURLcode imap_parse_url_path(struct connectdata *conn)
if(!*ptr) if(!*ptr)
return CURLE_URL_MALFORMAT; return CURLE_URL_MALFORMAT;
/* Decode the parameter name */ /* Decode the name parameter */
result = Curl_urldecode(data, begin, ptr - begin, &name, NULL, TRUE); result = Curl_urldecode(data, begin, ptr - begin, &name, NULL, TRUE);
if(result) if(result)
return result; return result;
/* Find the length of the value parameter */
begin = ++ptr; begin = ++ptr;
while(imap_is_bchar(*ptr)) while(imap_is_bchar(*ptr))
ptr++; ptr++;
/* Decode the parameter value */ /* Decode the value parameter */
result = Curl_urldecode(data, begin, ptr - begin, &value, &valuelen, TRUE); result = Curl_urldecode(data, begin, ptr - begin, &value, &valuelen, TRUE);
if(result) { if(result) {
Curl_safefree(name); Curl_safefree(name);
@@ -1746,9 +1747,10 @@ static CURLcode imap_parse_url_path(struct connectdata *conn)
DEBUGF(infof(conn->data, "IMAP URL parameter '%s' = '%s'\n", name, value)); DEBUGF(infof(conn->data, "IMAP URL parameter '%s' = '%s'\n", name, value));
/* Process known parameters (UIDVALIDITY, UID and SECTION) and create a /* Process the known hierarchical parameters (UIDVALIDITY, UID and SECTION)
virtual URL level, as they should be followed by a slash, which needs stripping of the trailing slash character if it is present.
to be stripped off. Unknown parameters trigger a URL_MALFORMAT error */
Note: Unknown parameters trigger a URL_MALFORMAT error. */
if(Curl_raw_equal(name, "UIDVALIDITY") && !imap->uidvalidity) { if(Curl_raw_equal(name, "UIDVALIDITY") && !imap->uidvalidity) {
if(valuelen > 0 && value[valuelen - 1] == '/') if(valuelen > 0 && value[valuelen - 1] == '/')
value[valuelen - 1] = '\0'; value[valuelen - 1] = '\0';