generic-library/cppzmq
1
0
Fork 0
mirror of https://github.com/zeromq/cppzmq.git synced 2025-04-27 18:30:54 +02:00
Code Issues Projects Releases Wiki Activity

Problem: unnecessary heap allocations for test subject

Browse Source 
Solution: change to local variables
This commit is contained in:
Simon Giesecke 2018-05-11 11:09:09 +02:00
parent 882f5e844c
commit ee1cc9a791
1 changed files with 23 additions and 27 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

50
tests/active_poller.cpp
View File

@ -17,27 +17,25 @@ static_assert(!std::is_copy_assignable<zmq::active_poller_t>::value, "active_act
TEST(active_poller, move_construct_empty) TEST(active_poller, move_construct_empty)
{ {
std::unique_ptr<zmq::active_poller_t> a {new zmq::active_poller_t}; zmq::active_poller_t a;
ASSERT_TRUE(a->empty ()); ASSERT_TRUE(a.empty ());
zmq::active_poller_t b = std::move (*a); zmq::active_poller_t b = std::move (a);
ASSERT_TRUE(b.empty ()); ASSERT_TRUE(b.empty ());
ASSERT_EQ(0u, a->size ()); ASSERT_EQ(0u, a.size ());
ASSERT_EQ(0u, b.size ()); ASSERT_EQ(0u, b.size ());
a.reset ();
} }
TEST(active_poller, move_assign_empty) TEST(active_poller, move_assign_empty)
{ {
std::unique_ptr<zmq::active_poller_t> a{new zmq::active_poller_t}; zmq::active_poller_t a;
ASSERT_TRUE(a->empty()); ASSERT_TRUE(a.empty());
zmq::active_poller_t b; zmq::active_poller_t b;
ASSERT_TRUE(b.empty()); ASSERT_TRUE(b.empty());
b = std::move(*a); b = std::move(a);
ASSERT_EQ(0u, a->size ()); ASSERT_EQ(0u, a.size ());
ASSERT_EQ(0u, b.size ()); ASSERT_EQ(0u, b.size ());
ASSERT_TRUE(a->empty()); ASSERT_TRUE(a.empty());
ASSERT_TRUE(b.empty()); ASSERT_TRUE(b.empty());
a.reset ();
} }
TEST(active_poller, move_construct_non_empty) TEST(active_poller, move_construct_non_empty)
@ -45,16 +43,15 @@ TEST(active_poller, move_construct_non_empty)
zmq::context_t context; zmq::context_t context;
zmq::socket_t socket{context, zmq::socket_type::router}; zmq::socket_t socket{context, zmq::socket_type::router};
std::unique_ptr<zmq::active_poller_t> a{new zmq::active_poller_t}; zmq::active_poller_t a;
a->add(socket, ZMQ_POLLIN, [](short) {}); a.add(socket, ZMQ_POLLIN, [](short) {});
ASSERT_FALSE(a->empty ()); ASSERT_FALSE(a.empty ());
ASSERT_EQ(1u, a->size ()); ASSERT_EQ(1u, a.size ());
zmq::active_poller_t b = std::move (*a); zmq::active_poller_t b = std::move (a);
ASSERT_TRUE(a->empty ()); ASSERT_TRUE(a.empty ());
ASSERT_EQ(0u, a->size ()); ASSERT_EQ(0u, a.size ());
ASSERT_FALSE(b.empty ()); ASSERT_FALSE(b.empty ());
ASSERT_EQ(1u, b.size ()); ASSERT_EQ(1u, b.size ());
a.reset ();
} }
TEST(active_poller, move_assign_non_empty) TEST(active_poller, move_assign_non_empty)
@ -62,17 +59,16 @@ TEST(active_poller, move_assign_non_empty)
zmq::context_t context; zmq::context_t context;
zmq::socket_t socket{context, zmq::socket_type::router}; zmq::socket_t socket{context, zmq::socket_type::router};
std::unique_ptr<zmq::active_poller_t> a{new zmq::active_poller_t}; zmq::active_poller_t a;
a->add(socket, ZMQ_POLLIN, [](short) {}); a.add(socket, ZMQ_POLLIN, [](short) {});
ASSERT_FALSE(a->empty()); ASSERT_FALSE(a.empty());
ASSERT_EQ(1u, a->size ()); ASSERT_EQ(1u, a.size ());
zmq::active_poller_t b; zmq::active_poller_t b;
b = std::move(*a); b = std::move(a);
ASSERT_TRUE(a->empty ()); ASSERT_TRUE(a.empty ());
ASSERT_EQ(0u, a->size ()); ASSERT_EQ(0u, a.size ());
ASSERT_FALSE(b.empty ()); ASSERT_FALSE(b.empty ());
ASSERT_EQ(1u, b.size ()); ASSERT_EQ(1u, b.size ());
a.reset ();
} }
TEST(active_poller, add_handler) TEST(active_poller, add_handler)