generic-library/cppzmq
1
0
Fork 0
mirror of https://github.com/zeromq/cppzmq.git synced 2025-06-09 23:57:38 +02:00
Code Issues Projects Releases Wiki Activity

Problem: message_t::operator== is absurdly inefficient and constructs temporary copies of both operands

Browse Source 
Solution: implement operator== using memcmp instead
This commit is contained in:
Simon Giesecke 2018-04-13 11:28:40 -04:00
parent 438bad28e6
commit c92afb675e
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
zmq.hpp
View File

@ -393,11 +393,10 @@ namespace zmq
inline bool operator==(const message_t &other) const ZMQ_NOTHROW inline bool operator==(const message_t &other) const ZMQ_NOTHROW
{ {
size_t my_size = size ();
if (size () != other.size ()) if (size () != other.size ())
return false; return false;
const std::string a(data<char>(), size()); return 0 == memcmp (data (), other.data (), my_size);
const std::string b(other.data<char>(), other.size());
return a == b;
} }
inline bool operator!=(const message_t &other) const ZMQ_NOTHROW inline bool operator!=(const message_t &other) const ZMQ_NOTHROW