Update doctest to 2.3.5

Includes a replacement for [[noreturn]] and thread_local

include/cereal/types/memory.hpp

@@ -104,6 +104,11 @@ namespace cereal
         portion of the class and replace it after whatever happens to modify it (e.g. the
         user performing construction or the wrapper shared_ptr in saving).
 
+        Note that this goes into undefined behavior territory, but as of the initial writing
+        of this, all standard library implementations of std::enable_shared_from_this are
+        compatible with this memory manipulation. It is entirely possible that this may someday
+        break or may not work with convoluted use cases.
+
         Example usage:
 
         @code{.cpp}

scripts/updatedoc.in

@@ -11,7 +11,7 @@ branch=`git rev-parse --abbrev-ref HEAD`
 cp -r @PROJECT_BINARY_DIR@/doc/html/ ${tempdir}
 
 git stash
-git checkout gh-pages-develop
+git checkout gh-pages
 
 rm -rf @PROJECT_SOURCE_DIR@/assets/doxygen
 mkdir @PROJECT_SOURCE_DIR@/assets/doxygen

unittests/array.cpp

@@ -27,7 +27,7 @@
 #define DOCTEST_CONFIG_IMPLEMENT_WITH_MAIN
 #include "array.hpp"
 
-TEST_SUITE("array");
+TEST_SUITE_BEGIN("array");
 
 TEST_CASE("binary_array")
 {

unittests/atomic.cpp

@@ -27,7 +27,7 @@
 #define DOCTEST_CONFIG_IMPLEMENT_WITH_MAIN
 #include "atomic.hpp"
 
-TEST_SUITE("atomic");
+TEST_SUITE_BEGIN("atomic");
 
 TEST_CASE("binary_atomic")
 {

unittests/basic_string.cpp

@@ -27,7 +27,7 @@
 #define DOCTEST_CONFIG_IMPLEMENT_WITH_MAIN
 #include "basic_string.hpp"
 
-TEST_SUITE("basic_string");
+TEST_SUITE_BEGIN("basic_string");
 
 TEST_CASE("binary_string")
 {

unittests/bitset.cpp

@@ -27,7 +27,7 @@
 #define DOCTEST_CONFIG_IMPLEMENT_WITH_MAIN
 #include "bitset.hpp"
 
-TEST_SUITE("bitset");
+TEST_SUITE_BEGIN("bitset");
 
 TEST_CASE("binary_bitset")
 {

unittests/boost/boost_variant.cpp

@@ -27,7 +27,7 @@
 #define DOCTEST_CONFIG_IMPLEMENT_WITH_MAIN
 #include "boost_variant.hpp"
 
-TEST_SUITE("boost_variant");
+TEST_SUITE_BEGIN("boost_variant");
 
 TEST_CASE("binary_boost_variant")
 {

unittests/chrono.cpp

@@ -27,7 +27,7 @@
 #define DOCTEST_CONFIG_IMPLEMENT_WITH_MAIN
 #include "chrono.hpp"
 
-TEST_SUITE("chrono");
+TEST_SUITE_BEGIN("chrono");
 
 TEST_CASE("binary_chrono")
 {

unittests/complex.cpp

@@ -27,7 +27,7 @@
 #define DOCTEST_CONFIG_IMPLEMENT_WITH_MAIN
 #include "complex.hpp"
 
-TEST_SUITE("complex");
+TEST_SUITE_BEGIN("complex");
 
 TEST_CASE("binary_complex")
 {

unittests/cpp17/optional.cpp

@@ -30,7 +30,7 @@
 
 #ifdef CEREAL_HAS_CPP17
 
-TEST_SUITE("std_optional");
+TEST_SUITE_BEGIN("std_optional");
 
 TEST_CASE("binary_std_optional")
 {

unittests/cpp17/variant.cpp

@@ -30,7 +30,7 @@
 
 #ifdef CEREAL_HAS_CPP17
 
-TEST_SUITE("std_variant");
+TEST_SUITE_BEGIN("std_variant");
 
 TEST_CASE("binary_std_variant")
 {

unittests/defer.cpp

@@ -27,7 +27,7 @@
 #define DOCTEST_CONFIG_IMPLEMENT_WITH_MAIN
 #include "defer.hpp"
 
-TEST_SUITE("defer");
+TEST_SUITE_BEGIN("defer");
 
 TEST_CASE("binary_defer")
 {

unittests/deque.cpp

@@ -27,7 +27,7 @@
 #define DOCTEST_CONFIG_IMPLEMENT_WITH_MAIN
 #include "deque.hpp"
 
-TEST_SUITE("deque");
+TEST_SUITE_BEGIN("deque");
 
 TEST_CASE("binary_dequeue")
 {

unittests/forward_list.cpp

@@ -27,7 +27,7 @@
 #define DOCTEST_CONFIG_IMPLEMENT_WITH_MAIN
 #include "forward_list.hpp"
 
-TEST_SUITE("forward_list");
+TEST_SUITE_BEGIN("forward_list");
 
 TEST_CASE("binary_forward_list")
 {

unittests/list.cpp

@@ -27,7 +27,7 @@
 #define DOCTEST_CONFIG_IMPLEMENT_WITH_MAIN
 #include "list.hpp"
 
-TEST_SUITE("list");
+TEST_SUITE_BEGIN("list");
 
 TEST_CASE("binary_list")
 {

unittests/load_construct.cpp

@@ -27,7 +27,7 @@
 #define DOCTEST_CONFIG_IMPLEMENT_WITH_MAIN
 #include "load_construct.hpp"
 
-TEST_SUITE("load_construct");
+TEST_SUITE_BEGIN("load_construct");
 
 TEST_CASE("binary_memory_load_construct")
 {

unittests/map.cpp

@@ -27,7 +27,7 @@
 #define DOCTEST_CONFIG_IMPLEMENT_WITH_MAIN
 #include "map.hpp"
 
-TEST_SUITE("map");
+TEST_SUITE_BEGIN("map");
 
 TEST_CASE("binary_map")
 {

unittests/memory.cpp

@@ -27,7 +27,7 @@
 #define DOCTEST_CONFIG_IMPLEMENT_WITH_MAIN
 #include "memory.hpp"
 
-TEST_SUITE("memory");
+TEST_SUITE_BEGIN("memory");
 
 TEST_CASE("binary_memory")
 {

unittests/memory_cycles.cpp

@@ -27,7 +27,7 @@
 #define DOCTEST_CONFIG_IMPLEMENT_WITH_MAIN
 #include "memory_cycles.hpp"
 
-TEST_SUITE("memory_cycles");
+TEST_SUITE_BEGIN("memory_cycles");
 
 TEST_CASE("binary_memory_cycles")
 {

unittests/multimap.cpp

@@ -27,7 +27,7 @@
 #define DOCTEST_CONFIG_IMPLEMENT_WITH_MAIN
 #include "multimap.hpp"
 
-TEST_SUITE("multimap");
+TEST_SUITE_BEGIN("multimap");
 
 TEST_CASE("binary_multimap")
 {

unittests/multiset.cpp

@@ -27,7 +27,7 @@
 #define DOCTEST_CONFIG_IMPLEMENT_WITH_MAIN
 #include "multiset.hpp"
 
-TEST_SUITE("multiset");
+TEST_SUITE_BEGIN("multiset");
 
 TEST_CASE("binary_multiset")
 {

unittests/pair.cpp

@@ -27,7 +27,7 @@
 #define DOCTEST_CONFIG_IMPLEMENT_WITH_MAIN
 #include "pair.hpp"
 
-TEST_SUITE("pair");
+TEST_SUITE_BEGIN("pair");
 
 TEST_CASE("binary_pair")
 {

unittests/pod.cpp

@@ -27,7 +27,7 @@
 #define DOCTEST_CONFIG_IMPLEMENT_WITH_MAIN
 #include "pod.hpp"
 
-TEST_SUITE("pod");
+TEST_SUITE_BEGIN("pod");
 
 TEST_CASE("binary_pod")
 {

unittests/polymorphic.cpp

@@ -27,7 +27,7 @@
 #define DOCTEST_CONFIG_IMPLEMENT_WITH_MAIN
 #include "polymorphic.hpp"
 
-TEST_SUITE("polymorphic");
+TEST_SUITE_BEGIN("polymorphic");
 
 TEST_CASE("binary_polymorphic")
 {

unittests/portable_binary_archive.cpp

@@ -27,7 +27,7 @@
 #define DOCTEST_CONFIG_IMPLEMENT_WITH_MAIN
 #include "portable_binary_archive.hpp"
 
-TEST_SUITE("portable_binary_archive");
+TEST_SUITE_BEGIN("portable_binary_archive");
 
 #ifdef _MSC_VER
 TEST_CASE("util")

unittests/priority_queue.cpp

@@ -27,7 +27,7 @@
 #define DOCTEST_CONFIG_IMPLEMENT_WITH_MAIN
 #include "priority_queue.hpp"
 
-TEST_SUITE("priority_queue");
+TEST_SUITE_BEGIN("priority_queue");
 
 TEST_CASE("binary_priority_queue")
 {

unittests/queue.cpp

@@ -27,7 +27,7 @@
 #define DOCTEST_CONFIG_IMPLEMENT_WITH_MAIN
 #include "queue.hpp"
 
-TEST_SUITE("queue");
+TEST_SUITE_BEGIN("queue");
 
 TEST_CASE("binary_queue")
 {

unittests/set.cpp

@@ -27,7 +27,7 @@
 #define DOCTEST_CONFIG_IMPLEMENT_WITH_MAIN
 #include "set.hpp"
 
-TEST_SUITE("set");
+TEST_SUITE_BEGIN("set");
 
 TEST_CASE("binary_set")
 {

unittests/stack.cpp

@@ -27,7 +27,7 @@
 #define DOCTEST_CONFIG_IMPLEMENT_WITH_MAIN
 #include "stack.hpp"
 
-TEST_SUITE("stack");
+TEST_SUITE_BEGIN("stack");
 
 TEST_CASE("binary_stack")
 {

unittests/structs.cpp

@@ -27,7 +27,7 @@
 #define DOCTEST_CONFIG_IMPLEMENT_WITH_MAIN
 #include "structs.hpp"
 
-TEST_SUITE("structs");
+TEST_SUITE_BEGIN("structs");
 
 TEST_CASE("binary_structs")
 {

unittests/structs_minimal.cpp

@@ -27,7 +27,7 @@
 #define DOCTEST_CONFIG_IMPLEMENT_WITH_MAIN
 #include "structs_minimal.hpp"
 
-TEST_SUITE("structs_minimal");
+TEST_SUITE_BEGIN("structs_minimal");
 
 TEST_CASE("binary_structs_minimal")
 {

unittests/structs_specialized.cpp

@@ -27,7 +27,7 @@
 #define DOCTEST_CONFIG_IMPLEMENT_WITH_MAIN
 #include "structs_specialized.hpp"
 
-TEST_SUITE("structs_specialized");
+TEST_SUITE_BEGIN("structs_specialized");
 
 TEST_CASE("binary_structs_specialized")
 {

unittests/structs_specialized.hpp

@@ -70,6 +70,8 @@ struct BogusBasePolymorphic
   void serialize( Archive & ) {}
 
   virtual void doesNothing() {}
+
+  virtual ~BogusBasePolymorphic() {}
 };
 
 class SpecializedMSerialize : public BogusBase
@@ -158,6 +160,8 @@ class SpecializedMSplitPolymorphic : public BogusBasePolymorphic
     SpecializedMSplitPolymorphic() = default;
     SpecializedMSplitPolymorphic( int xx ) : x(xx) {}
 
+    virtual ~SpecializedMSplitPolymorphic() {}
+
     int x;
 
   private:

unittests/tuple.cpp

@@ -27,7 +27,7 @@
 #define DOCTEST_CONFIG_IMPLEMENT_WITH_MAIN
 #include "tuple.hpp"
 
-TEST_SUITE("tuple");
+TEST_SUITE_BEGIN("tuple");
 
 TEST_CASE("binary_tuple")
 {

unittests/unordered_loads.cpp

@@ -27,7 +27,7 @@
 #define DOCTEST_CONFIG_IMPLEMENT_WITH_MAIN
 #include "unordered_loads.hpp"
 
-TEST_SUITE("unordered_loads");
+TEST_SUITE_BEGIN("unordered_loads");
 
 TEST_CASE("xml_unordered_loads")
 {

unittests/unordered_map.cpp

@@ -27,7 +27,7 @@
 #define DOCTEST_CONFIG_IMPLEMENT_WITH_MAIN
 #include "unordered_map.hpp"
 
-TEST_SUITE("unordered_map");
+TEST_SUITE_BEGIN("unordered_map");
 
 TEST_CASE("binary_unordered_map")
 {

unittests/unordered_multimap.cpp

@@ -27,7 +27,7 @@
 #define DOCTEST_CONFIG_IMPLEMENT_WITH_MAIN
 #include "unordered_multimap.hpp"
 
-TEST_SUITE("unordered_multimap");
+TEST_SUITE_BEGIN("unordered_multimap");
 
 TEST_CASE("binary_unordered_multimap")
 {

unittests/unordered_multiset.cpp

@@ -27,7 +27,7 @@
 #define DOCTEST_CONFIG_IMPLEMENT_WITH_MAIN
 #include "unordered_multiset.hpp"
 
-TEST_SUITE("unordered_multiset");
+TEST_SUITE_BEGIN("unordered_multiset");
 
 TEST_CASE("binary_unordered_multiset")
 {

unittests/unordered_set.cpp

@@ -27,7 +27,7 @@
 #define DOCTEST_CONFIG_IMPLEMENT_WITH_MAIN
 #include "unordered_set.hpp"
 
-TEST_SUITE("unordered_set");
+TEST_SUITE_BEGIN("unordered_set");
 
 TEST_CASE("binary_unordered_set")
 {

unittests/user_data_adapters.cpp

@@ -27,7 +27,7 @@
 #define DOCTEST_CONFIG_IMPLEMENT_WITH_MAIN
 #include "user_data_adapters.hpp"
 
-TEST_SUITE("user_data_adapters");
+TEST_SUITE_BEGIN("user_data_adapters");
 
 TEST_CASE("binary_user_data_adapters")
 {

unittests/valarray.cpp

@@ -27,7 +27,7 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
 #define DOCTEST_CONFIG_IMPLEMENT_WITH_MAIN
 #include "valarray.hpp"
 
-TEST_SUITE("valarray");
+TEST_SUITE_BEGIN("valarray");
 
 TEST_CASE("binary_valarray")
 {

unittests/vector.cpp

@@ -27,7 +27,7 @@
 #define DOCTEST_CONFIG_IMPLEMENT_WITH_MAIN
 #include "vector.hpp"
 
-TEST_SUITE("vector");
+TEST_SUITE_BEGIN("vector");
 
 TEST_CASE("binary_vector")
 {

unittests/versioning.cpp

@@ -27,7 +27,7 @@
 #define DOCTEST_CONFIG_IMPLEMENT_WITH_MAIN
 #include "versioning.hpp"
 
-TEST_SUITE("versioning");
+TEST_SUITE_BEGIN("versioning");
 
 TEST_CASE("binary_versioning")
 {