generic-library/breakpad
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
543 Commits 15 Branches 1 Tag 39 MiB
C++ 68.2%
Makefile 12.8%
C 5.1%
Shell 5%
Objective-C 3.6%
Other 5.3%
6869f2e1b3
Go to file
ted.mielczarek 6869f2e1b3 Breakpad DWARF CFI parser: Use the proper type for offsets in CallFrameInfo::Rule subclasses. 
The subclasses of CallFrameInfo::Rule store the rule currently in
force for recovering a register or computing the canonical frame
address. Their sole responsibility is to accurately convey rules from
the parser, which creates them, to a CallFrameInfo::Handler member
function, which consumes them. So, the types of their data members
should match those of the corresponding arguments of the corresponding
Handler member function.

CallFrameInfo::OffsetRule and CallFrameInfo::ValOffsetRule use an
'int' to store the rule's offset value, but
CallFrameInfo::Handler::OffsetRule and ...::ValOffsetRule expect a
'long'.  On ABIs where 'long' is larger than 'int', this can cause
values to be truncated or sign-extended unexpectedly.

This patch changes those members to 'long'.

Fortunately, offsets appearing in real DWARF call frame information
never even come close to the limits of a 32-bit int, so this bug is
unlikely to cause any practical problems.
A=jimb R=thestig

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@615 4c0a9323-5329-0410-9bdc-e9ce6186880e
2010-06-25 16:56:48 +00:00
autotools Regenerate using automake-1.11.1, autoconf 2.65, and libtool 2.2.6b, 2010-02-02 17:39:51 +00:00
m4 ARM support, with some build system changes to support x86-64, arm, and i386 in an autoconf style build in Linux. The O2 build for the unit tests is still broken but I'm checking this in to unblock people 2010-03-02 00:39:48 +00:00
src Breakpad DWARF CFI parser: Use the proper type for offsets in CallFrameInfo::Rule subclasses. 2010-06-25 16:56:48 +00:00
aclocal.m4 provide a network source line resolver + server. r=mark,jimb at http://breakpad.appspot.com/36001 2010-04-08 23:06:23 +00:00
AUTHORS Make build system less annoying (#8) r=bryner 2006-08-30 20:05:05 +00:00
ChangeLog Initial import, which includes the Windows client-side dump_syms tool, and 2006-08-25 21:14:45 +00:00
codereview.settings Add codereview.settings so we can use gcl. 2010-06-19 02:48:54 +00:00
configure provide a network source line resolver + server. r=mark,jimb at http://breakpad.appspot.com/36001 2010-04-08 23:06:23 +00:00
configure.ac provide a network source line resolver + server. r=mark,jimb at http://breakpad.appspot.com/36001 2010-04-08 23:06:23 +00:00
COPYING Relicense to BSD (#29). r=bryner 2006-09-20 21:16:16 +00:00
DEPS Delete svn:executable from the DEPS file. Hans has a badly configured client on Windows? 2010-05-18 01:46:59 +00:00
INSTALL Add logging to minidump processor (#82). First part: logging infrastructure 2007-05-17 18:34:37 +00:00
Makefile.am Breakpad test support: Move test_assembler.{h,cc} from src/processor to src/common. 2010-04-27 19:17:59 +00:00
Makefile.in Breakpad test support: Move test_assembler.{h,cc} from src/processor to src/common. 2010-04-27 19:17:59 +00:00
NEWS Initial import, which includes the Windows client-side dump_syms tool, and 2006-08-25 21:14:45 +00:00
README Rename Airbag to Breakpad. 2007-02-14 19:51:05 +00:00

README 

Breakpad is a set of client and server components which implement a
crash-reporting system.