Compare commits

...

3 Commits

Author SHA1 Message Date
rmcilroy@chromium.org
a5d7e86dae Cherry pick r1344 into chrome_37 branch
Original commit message:
> Unhook current Breakpad object after handling uncaught NSException.
> After handling an uncaught NSException, release the Breakpad object
> so there will not be a second crash dump logged.
>
> Prior to this change, for every uncaught NSException handled through
> the Breakpad::UncaughtExceptionHandler(), a second crash without
> any useful information (generally __cxa_rethrow and std::__terminate)
> is recorded.
>
> R=qsr@chromium.org
>
> Review URL: https://breakpad.appspot.com/9664002
>
> Patch from Peter Lee <pkl@chromium.org>.

R=mark@chromium.org

Review URL: https://breakpad.appspot.com/1704002

git-svn-id: http://google-breakpad.googlecode.com/svn/branches/chrome_37@1357 4c0a9323-5329-0410-9bdc-e9ce6186880e
2014-07-22 16:54:48 +00:00
rmcilroy@chromium.org
a9d1f1f299 Cherry pick r1351 into chrome_37 branch.
Original commit message:
[Android]: Remove __system_property_get(ro.build.fingerprint) from
WriteOSInformation.

__system_property_get has been removed from the Android NDK for 'L' so Breakpad
no longer links. This CL just removes the call in WriteOSInformation because
Chrome already passes the build fingerprint as a crash key called
"android_build_fp" in the crash report HTTP POST message.

BUG=394841,393903
R=mark@chromium.org



git-svn-id: http://google-breakpad.googlecode.com/svn/branches/chrome_37@1353 4c0a9323-5329-0410-9bdc-e9ce6186880e
2014-07-18 17:58:36 +00:00
mark@chromium.org
a6f96c48f3 Branching for Chrome 37.0.2062 at Breakpad r1338.
git-svn-id: http://google-breakpad.googlecode.com/svn/branches/chrome_37@1352 4c0a9323-5329-0410-9bdc-e9ce6186880e
2014-07-18 17:49:35 +00:00
2 changed files with 1 additions and 17 deletions

View File

@ -258,6 +258,7 @@ void Breakpad::UncaughtExceptionHandler(NSException *exception) {
if (current_breakpad_) {
current_breakpad_->HandleUncaughtException(exception);
}
BreakpadRelease(current_breakpad_);
}
//=============================================================================

View File

@ -1758,23 +1758,6 @@ class MinidumpWriter {
space_left -= info_len;
}
#ifdef __ANDROID__
// On Android, try to get the build fingerprint and append it.
// Fail gracefully because there is no guarantee that the system
// property will always be available or accessible.
char fingerprint[PROP_VALUE_MAX];
int fingerprint_len = __system_property_get("ro.build.fingerprint",
fingerprint);
// System property values shall always be zero-terminated.
// Be paranoid and don't trust the system.
if (fingerprint_len > 0 && fingerprint_len < PROP_VALUE_MAX) {
const char* separator = " ";
if (!first_item)
my_strlcat(buf, separator, sizeof(buf));
my_strlcat(buf, fingerprint, sizeof(buf));
}
#endif
MDLocationDescriptor location;
if (!minidump_writer_.WriteString(buf, 0, &location))
return false;