generic-library/breakpad
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Increasing the Breakpad stack walker max scan limit from 30 to 40.

Browse Source 
Chrome started hitting some crashes in v8 jitted code which happens to be
non ABI compliant and debuggers (including WinDBG) are unable to produce
meaningful stack traces.

The Breakpad stack walker has some builtin heuristics to deal with such cases.
More specifically, when unable to find a good parent frame, it scans the raw
stack to find a suitable parent frame.  The max scan size was set at 30
pointers which was (apparently) not enough to recover in this case.

I'm increasing it to 40 pointers.  I confirmed that at 34 pointers it was able
to recover however I'm setting it to 40 in order to it some slack.

I needed to update two unittests which were expecting the previous scan limit.

BUG=
R=mark@chromium.org

Review URL: https://codereview.chromium.org/1379433005 .
This commit is contained in:
Ivan Penkov 2015-10-05 11:35:09 -07:00
parent 01c8f7cf46
commit f948d8d623
4 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/processor/stackwalker.cc
View File

@ -58,7 +58,7 @@
namespace google_breakpad {
const int Stackwalker::kRASearchWords = 30;
const int Stackwalker::kRASearchWords = 40;
uint32_t Stackwalker::max_frames_ = 1024;
bool Stackwalker::max_frames_set_ = false;

2
src/processor/stackwalker_arm64_unittest.cc
View File

@ -349,7 +349,7 @@ TEST_F(GetCallerFrame, ScanFirstFrame) {
.D64(0xF0000000) // more junk
.D64(0x0000000D)
.Append(256, 0) // more space
.Append(336, 0) // more space
.D64(return_address2) // actual return address
// (won't be found)

2
src/processor/stackwalker_arm_unittest.cc
View File

@ -370,7 +370,7 @@ TEST_F(GetCallerFrame, ScanFirstFrame) {
.D32(0xF0000000) // more junk
.D32(0x0000000D)
.Append(96, 0) // more space
.Append(136, 0) // more space
.D32(return_address2) // actual return address
// (won't be found)

6
src/processor/stackwalker_x86_unittest.cc
View File

@ -1228,9 +1228,9 @@ TEST_F(GetCallerFrame, WindowsFPOSystemCall) {
// Scan the stack for a better return address and potentially skip frames
// when the calculated return address is not in a known module. Note, that
// the span of this scan is somewhat arbitrarily limited to 120 search words
// for the context frame and 30 search words (pointers) for the other frames:
// const int kRASearchWords = 30;
// the span of this scan is somewhat arbitrarily limited to 160 search words
// for the context frame and 40 search words (pointers) for the other frames:
// const int kRASearchWords = 40;
// This means that frames can be skipped only when their size is relatively
// small: smaller than 4 * kRASearchWords * sizeof(InstructionType)
TEST_F(GetCallerFrame, ReturnAddressIsNotInKnownModule) {