generic-library/breakpad
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Remove auto_ptr usage in Breakpad. Also fix some lint errors.

Browse Source 
Review URL: https://breakpad.appspot.com/553002

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1145 4c0a9323-5329-0410-9bdc-e9ce6186880e
This commit is contained in:
thestig@chromium.org 2013-04-09 18:58:39 +00:00
parent 2652675ec2
commit cff813962a
1 changed files with 11 additions and 9 deletions

10
src/common/dwarf/functioninfo.cc

@ -36,10 +36,10 @@
#include <map> #include <map>
#include <queue> #include <queue>
#include <vector> #include <vector>
#include <memory>
#include "common/dwarf/functioninfo.h" #include "common/dwarf/functioninfo.h"
#include "common/dwarf/bytereader.h" #include "common/dwarf/bytereader.h"
#include "common/scoped_ptr.h"
#include "common/using_std_string.h" #include "common/using_std_string.h"
namespace dwarf2reader { namespace dwarf2reader {
@ -164,8 +164,7 @@ void CUFunctionInfoHandler::ProcessAttributeUnsigned(uint64 offset,
SectionMap::const_iterator iter = sections_.find("__debug_line"); SectionMap::const_iterator iter = sections_.find("__debug_line");
assert(iter != sections_.end()); assert(iter != sections_.end());
// this should be a scoped_ptr but we dont' use boost :-( scoped_ptr<LineInfo> lireader(new LineInfo(iter->second.first + data,
std::auto_ptr<LineInfo> lireader(new LineInfo(iter->second.first + data,
iter->second.second - data, iter->second.second - data,
reader_, linehandler_)); reader_, linehandler_));
lireader->Start(); lireader->Start();
@ -208,7 +207,10 @@ void CUFunctionInfoHandler::ProcessAttributeReference(uint64 offset,
current_function_info_->mangled_name = iter->second->mangled_name; current_function_info_->mangled_name = iter->second->mangled_name;
} else { } else {
// If you hit this, this code probably needs to be rewritten. // If you hit this, this code probably needs to be rewritten.
fprintf(stderr, "Error: DW_AT_specification was seen before the referenced DIE! (Looking for DIE at offset %08llx, in DIE at offset %08llx)\n", data, offset); fprintf(stderr,
"Error: DW_AT_specification was seen before the referenced "
"DIE! (Looking for DIE at offset %08llx, in DIE at "
"offset %08llx)\n", data, offset);
} }
break; break;
} }