generic-library/breakpad
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix a clang warning:

Browse Source 
../../breakpad/src/processor/tokenize.cc:65:7: error: logical not is only applied to the left hand side of this comparison [-Werror,-Wlogical-not-parentheses]
  if (!remaining > 0) {
      ^          ~
../../breakpad/src/processor/tokenize.cc:65:7: note: add parentheses after the '!' to evaluate the comparison first
  if (!remaining > 0) {
      ^
       (            )
../../breakpad/src/processor/tokenize.cc:65:7: note: add parentheses around left hand side expression to silence this warning
  if (!remaining > 0) {
      ^
      (         )

R=thakis@chromium.org

Review URL: https://breakpad.appspot.com/608002

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1196 4c0a9323-5329-0410-9bdc-e9ce6186880e
This commit is contained in:
mark@chromium.org
2013-06-28 20:45:10 +00:00
parent f33dd18fd2
commit bbd0e39801
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/processor/tokenize.cc
View File

@@ -62,11 +62,9 @@ bool Tokenize(char *line,
} }
// If there's anything left, just add it as a single token. // If there's anything left, just add it as a single token.
if (!remaining > 0) { if (remaining == 0 && (token = strtok_r(NULL, "\r\n", &save_ptr))) {
if ((token = strtok_r(NULL, "\r\n", &save_ptr))) {
tokens->push_back(token); tokens->push_back(token);
} }
}
return tokens->size() == static_cast<unsigned int>(max_tokens); return tokens->size() == static_cast<unsigned int>(max_tokens);
} }