generic-library/breakpad
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Add option to Breakpad to consume INVALID_HANDLE_VALUE exceptions.

Browse Source 
BUG=chromium:452613
R=mark@chromium.org

Review URL: https://breakpad.appspot.com/7794002

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1427 4c0a9323-5329-0410-9bdc-e9ce6186880e
This commit is contained in:
wfh@chromium.org 2015-02-22 02:27:35 +00:00
parent 94f863af2c
commit b79454627e
2 changed files with 19 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/client/windows/handler/exception_handler.cc
View File

@ -174,6 +174,7 @@ void ExceptionHandler::Initialize(
assertion_ = NULL;
handler_return_value_ = false;
handle_debug_exceptions_ = false;
consume_invalid_handle_exceptions_ = false;
// Attempt to use out-of-process if user has specified a pipe or a
// crash generation client.
@ -481,6 +482,11 @@ LONG ExceptionHandler::HandleException(EXCEPTION_POINTERS* exinfo) {
bool is_debug_exception = (code == EXCEPTION_BREAKPOINT) ||
(code == EXCEPTION_SINGLE_STEP);
if (code == EXCEPTION_INVALID_HANDLE &&
current_handler->consume_invalid_handle_exceptions_) {
return EXCEPTION_CONTINUE_EXECUTION;
}
bool success = false;
if (!is_debug_exception ||

13
src/client/windows/handler/exception_handler.h
View File

@ -263,6 +263,15 @@ class ExceptionHandler {
handle_debug_exceptions_ = handle_debug_exceptions;
}
// Controls behavior of EXCEPTION_INVALID_HANDLE.
bool get_consume_invalid_handle_exceptions() const {
return consume_invalid_handle_exceptions_;
}
void set_consume_invalid_handle_exceptions(
bool consume_invalid_handle_exceptions) {
consume_invalid_handle_exceptions_ = consume_invalid_handle_exceptions;
}
// Returns whether out-of-process dump generation is used or not.
bool IsOutOfProcess() const { return crash_generation_client_.get() != NULL; }
@ -472,6 +481,10 @@ class ExceptionHandler {
// to not interfere with debuggers.
bool handle_debug_exceptions_;
// If true, the handler will consume any EXCEPTION_INVALID_HANDLE exceptions.
// Leave this false (the default) to handle these exceptions as normal.
bool consume_invalid_handle_exceptions_;
// Callers can request additional memory regions to be included in
// the dump.
AppMemoryList app_memory_info_;