generic-library/breakpad
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

GoogleCrashdumpUploader would leak instances of LibcurlWrapper (Coverity)

Browse Source 
The GoogleCrashdumpUploader would create, but never destroy it's instance of LibcurlWrapper.

BUG=574
A=cmumford@chromium.org
Original code review: https://breakpad.appspot.com/1314002/

R=cmumford@chromium.org

Review URL: https://breakpad.appspot.com/1344002

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1294 4c0a9323-5329-0410-9bdc-e9ce6186880e
This commit is contained in:
thestig@chromium.org 2014-04-01 20:18:23 +00:00
parent 0decfdb042
commit 482df94a07
2 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/common/linux/google_crashdump_uploader.cc
View File

@ -112,7 +112,7 @@ void GoogleCrashdumpUploader::Init(const string& product,
ctime_ = ctime;
email_ = email;
comments_ = comments;
http_layer_ = http_layer;
http_layer_.reset(http_layer);
crash_server_ = crash_server;
proxy_host_ = proxy_host;

3
src/common/linux/google_crashdump_uploader.h
View File

@ -31,6 +31,7 @@
#include <string>
#include <map>
#include "common/scoped_ptr.h"
#include "common/using_std_string.h"
namespace google_breakpad {
@ -81,7 +82,7 @@ class GoogleCrashdumpUploader {
private:
bool CheckRequiredParametersArePresent();
LibcurlWrapper* http_layer_;
scoped_ptr<LibcurlWrapper> http_layer_;
string product_;
string version_;
string guid_;