generic-library/breakpad
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix -Wreorder warnings in the Windows code.

Browse Source 
This makes the order of fields in constructor initializer lists match
the order in which the fields are declared in (which is the order
they're initialized in). No intended behavior change.

This change was originally reviewed at
https://codereview.chromium.org/1230923005/

BUG=chromium:505304
TBR=thakis@chromium.org

Review URL: https://codereview.chromium.org/1234653002

git-svn-id: http://google-breakpad.googlecode.com/svn/trunk@1471 4c0a9323-5329-0410-9bdc-e9ce6186880e
This commit is contained in:
wfh@chromium.org 2015-07-10 20:24:33 +00:00
parent 28c9c9b82c
commit 0c426387b8
3 changed files with 14 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/client/windows/crash_generation/crash_generation_client.cc
View File

@ -96,14 +96,14 @@ CrashGenerationClient::CrashGenerationClient(
const CustomClientInfo* custom_info) const CustomClientInfo* custom_info)
: pipe_name_(pipe_name), : pipe_name_(pipe_name),
pipe_handle_(NULL), pipe_handle_(NULL),
custom_info_(),
dump_type_(dump_type), dump_type_(dump_type),
thread_id_(0),
server_process_id_(0),
crash_event_(NULL), crash_event_(NULL),
crash_generated_(NULL), crash_generated_(NULL),
server_alive_(NULL), server_alive_(NULL),
exception_pointers_(NULL), server_process_id_(0),
custom_info_() { thread_id_(0),
exception_pointers_(NULL) {
memset(&assert_info_, 0, sizeof(assert_info_)); memset(&assert_info_, 0, sizeof(assert_info_));
if (custom_info) { if (custom_info) {
custom_info_ = *custom_info; custom_info_ = *custom_info;
@ -116,14 +116,14 @@ CrashGenerationClient::CrashGenerationClient(
const CustomClientInfo* custom_info) const CustomClientInfo* custom_info)
: pipe_name_(), : pipe_name_(),
pipe_handle_(pipe_handle), pipe_handle_(pipe_handle),
custom_info_(),
dump_type_(dump_type), dump_type_(dump_type),
thread_id_(0),
server_process_id_(0),
crash_event_(NULL), crash_event_(NULL),
crash_generated_(NULL), crash_generated_(NULL),
server_alive_(NULL), server_alive_(NULL),
exception_pointers_(NULL), server_process_id_(0),
custom_info_() { thread_id_(0),
exception_pointers_(NULL) {
memset(&assert_info_, 0, sizeof(assert_info_)); memset(&assert_info_, 0, sizeof(assert_info_));
if (custom_info) { if (custom_info) {
custom_info_ = *custom_info; custom_info_ = *custom_info;

4
src/client/windows/crash_generation/crash_generation_server.cc
View File

@ -121,12 +121,12 @@ CrashGenerationServer::CrashGenerationServer(
upload_request_callback_(upload_request_callback), upload_request_callback_(upload_request_callback),
upload_context_(upload_context), upload_context_(upload_context),
generate_dumps_(generate_dumps), generate_dumps_(generate_dumps),
pre_fetch_custom_info_(true),
dump_path_(dump_path ? *dump_path : L""), dump_path_(dump_path ? *dump_path : L""),
server_state_(IPC_SERVER_STATE_UNINITIALIZED), server_state_(IPC_SERVER_STATE_UNINITIALIZED),
shutting_down_(false), shutting_down_(false),
overlapped_(), overlapped_(),
client_info_(NULL), client_info_(NULL) {
pre_fetch_custom_info_(true) {
InitializeCriticalSection(&sync_); InitializeCriticalSection(&sync_);
} }

8
src/client/windows/crash_generation/minidump_generator.cc
View File

@ -259,8 +259,9 @@ MinidumpGenerator::MinidumpGenerator(
const MINIDUMP_TYPE dump_type, const MINIDUMP_TYPE dump_type,
const bool is_client_pointers) const bool is_client_pointers)
: dbghelp_module_(NULL), : dbghelp_module_(NULL),
write_dump_(NULL),
rpcrt4_module_(NULL), rpcrt4_module_(NULL),
dump_path_(dump_path), create_uuid_(NULL),
process_handle_(process_handle), process_handle_(process_handle),
process_id_(process_id), process_id_(process_id),
thread_id_(thread_id), thread_id_(thread_id),
@ -269,14 +270,13 @@ MinidumpGenerator::MinidumpGenerator(
assert_info_(assert_info), assert_info_(assert_info),
dump_type_(dump_type), dump_type_(dump_type),
is_client_pointers_(is_client_pointers), is_client_pointers_(is_client_pointers),
dump_path_(dump_path),
dump_file_(INVALID_HANDLE_VALUE), dump_file_(INVALID_HANDLE_VALUE),
full_dump_file_(INVALID_HANDLE_VALUE), full_dump_file_(INVALID_HANDLE_VALUE),
dump_file_is_internal_(false), dump_file_is_internal_(false),
full_dump_file_is_internal_(false), full_dump_file_is_internal_(false),
additional_streams_(NULL), additional_streams_(NULL),
callback_info_(NULL), callback_info_(NULL) {
write_dump_(NULL),
create_uuid_(NULL) {
InitializeCriticalSection(&module_load_sync_); InitializeCriticalSection(&module_load_sync_);
InitializeCriticalSection(&get_proc_address_sync_); InitializeCriticalSection(&get_proc_address_sync_);
} }