Stupidly I found this bug by accident when writing the existing tests, but I didn't think any real code would hit it. It turns out that libcore always uses an INET6_ADDRSTRLEN-sized buffer even when working with AF_INET addresses. Change-Id: Ieffc8e4bbe9b66b49b033e3e7101c896e097e6f8
		
			
				
	
	
		
			82 lines
		
	
	
		
			2.4 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
			
		
		
	
	
			82 lines
		
	
	
		
			2.4 KiB
		
	
	
	
		
			C++
		
	
	
	
	
	
/*
 | 
						|
 * Copyright (C) 2014 The Android Open Source Project
 | 
						|
 *
 | 
						|
 * Licensed under the Apache License, Version 2.0 (the "License");
 | 
						|
 * you may not use this file except in compliance with the License.
 | 
						|
 * You may obtain a copy of the License at
 | 
						|
 *
 | 
						|
 *      http://www.apache.org/licenses/LICENSE-2.0
 | 
						|
 *
 | 
						|
 * Unless required by applicable law or agreed to in writing, software
 | 
						|
 * distributed under the License is distributed on an "AS IS" BASIS,
 | 
						|
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 | 
						|
 * See the License for the specific language governing permissions and
 | 
						|
 * limitations under the License.
 | 
						|
 */
 | 
						|
 | 
						|
#include <gtest/gtest.h>
 | 
						|
 | 
						|
#include <arpa/inet.h>
 | 
						|
 | 
						|
TEST(arpa_inet, inet_addr) {
 | 
						|
  ASSERT_EQ((htonl)(0x7f000001), inet_addr("127.0.0.1"));
 | 
						|
}
 | 
						|
 | 
						|
TEST(arpa_inet, inet_aton) {
 | 
						|
  in_addr a;
 | 
						|
  ASSERT_EQ(1, inet_aton("127.0.0.1", &a));
 | 
						|
  ASSERT_EQ((htonl)(0x7f000001), a.s_addr);
 | 
						|
}
 | 
						|
 | 
						|
TEST(arpa_inet, inet_lnaof) {
 | 
						|
  in_addr a = { htonl(0x12345678) };
 | 
						|
  ASSERT_EQ(0x00345678U, inet_lnaof(a));
 | 
						|
}
 | 
						|
 | 
						|
TEST(arpa_inet, inet_makeaddr) {
 | 
						|
  in_addr a = inet_makeaddr(0x12U, 0x345678);
 | 
						|
  ASSERT_EQ((htonl)(0x12345678), a.s_addr);
 | 
						|
}
 | 
						|
 | 
						|
TEST(arpa_inet, inet_netof) {
 | 
						|
  in_addr a = { htonl(0x12345678) };
 | 
						|
  ASSERT_EQ(0x12U, inet_netof(a));
 | 
						|
}
 | 
						|
 | 
						|
TEST(arpa_inet, inet_network) {
 | 
						|
  ASSERT_EQ(0x7f000001U, inet_network("127.0.0.1"));
 | 
						|
}
 | 
						|
 | 
						|
TEST(arpa_inet, inet_ntoa) {
 | 
						|
  in_addr a = { (htonl)(0x7f000001) };
 | 
						|
  ASSERT_STREQ("127.0.0.1", inet_ntoa(a));
 | 
						|
}
 | 
						|
 | 
						|
TEST(arpa_inet, inet_pton__inet_ntop) {
 | 
						|
  sockaddr_storage ss;
 | 
						|
  ASSERT_EQ(1, inet_pton(AF_INET, "127.0.0.1", &ss));
 | 
						|
 | 
						|
  char s[INET_ADDRSTRLEN];
 | 
						|
  ASSERT_STREQ("127.0.0.1", inet_ntop(AF_INET, &ss, s, INET_ADDRSTRLEN));
 | 
						|
}
 | 
						|
 | 
						|
TEST(arpa_inet, inet_ntop_overflow) {
 | 
						|
  // OpenBSD's inet_ntop had a bug where passing a 'size' larger than INET_ADDRSTRLEN
 | 
						|
  // for AF_INET or INET6_ADDRSTRLEN for AF_INET6 would cause inet_ntop to overflow an
 | 
						|
  // internal buffer.
 | 
						|
 | 
						|
  sockaddr_storage ss4;
 | 
						|
  ASSERT_EQ(1, inet_pton(AF_INET, "127.0.0.1", &ss4));
 | 
						|
 | 
						|
  sockaddr_storage ss6;
 | 
						|
  ASSERT_EQ(1, inet_pton(AF_INET6, "::1", &ss6));
 | 
						|
 | 
						|
  char s4[INET_ADDRSTRLEN];
 | 
						|
  char s6[INET6_ADDRSTRLEN];
 | 
						|
  ASSERT_STREQ("127.0.0.1", inet_ntop(AF_INET, &ss4, s4, INET_ADDRSTRLEN));
 | 
						|
  ASSERT_STREQ("127.0.0.1", inet_ntop(AF_INET, &ss4, s4, 2*INET_ADDRSTRLEN));
 | 
						|
  ASSERT_STREQ("::1", inet_ntop(AF_INET6, &ss6, s6, INET_ADDRSTRLEN));
 | 
						|
  ASSERT_STREQ("::1", inet_ntop(AF_INET6, &ss6, s6, INET6_ADDRSTRLEN));
 | 
						|
  ASSERT_STREQ("::1", inet_ntop(AF_INET6, &ss6, s6, 2*INET6_ADDRSTRLEN));
 | 
						|
}
 |