Commit Graph

6431 Commits

Author SHA1 Message Date
Elliott Hughes
a85606e156 am c100a100: Merge "\'Avoid confusing "read prevented write" log messages\' 2."
* commit 'c100a10069a16eca57f5f9ab838ff98d7db6eb03':
  'Avoid confusing "read prevented write" log messages' 2.
2013-10-15 17:35:27 -07:00
Elliott Hughes
c100a10069 Merge "'Avoid confusing "read prevented write" log messages' 2." 2013-10-16 00:31:20 +00:00
Elliott Hughes
949676ce6c am cbfa1afd: am 0287db52: am d9913b0b: Merge "Make pthread_create report sched_setscheduler failures on LP64."
* commit 'cbfa1afda32e290ddc9c9bea866c27ae93d040d2':
  Make pthread_create report sched_setscheduler failures on LP64.
2013-10-15 17:29:55 -07:00
Christopher Ferris
3cfa519987 am 03ce5171: am fbefb252: Modify prefetch for krait memcpy.
* commit '03ce51717893dde6a56ef19da9cb3c92b1e4927a':
  Modify prefetch for krait memcpy.
2013-10-15 17:29:52 -07:00
Elliott Hughes
4c46b2992b am df17ce78: am 26491483: am 76725214: Merge "Avoid confusing "read prevented write" log messages."
* commit 'df17ce7858f8df22a14412fa18ee5b80fa6b283e':
  Avoid confusing "read prevented write" log messages.
2013-10-15 17:29:51 -07:00
Elliott Hughes
f60c5baf0b am b01ebe6d: am 14e7482c: am d16391bb: Merge "Fix indentation in sched_getaffinity."
* commit 'b01ebe6d4e76cd57dac09e6bdb581f8f964cd75f':
  Fix indentation in sched_getaffinity.
2013-10-15 17:29:50 -07:00
Christopher Ferris
a3ae4f31ab am 289c460c: am ac6bc319: Remove new aligned memcpy path for cortex-a15.
* commit '289c460c55fdf50c03e8711de077d2db67346d9b':
  Remove new aligned memcpy path for cortex-a15.
2013-10-15 17:29:28 -07:00
Elliott Hughes
68b67113a4 'Avoid confusing "read prevented write" log messages' 2.
This time it's assembler.

Change-Id: Iae6369833b8046b8eda70238bb4ed0cae64269ea
2013-10-15 17:17:05 -07:00
Elliott Hughes
cbfa1afda3 am 0287db52: am d9913b0b: Merge "Make pthread_create report sched_setscheduler failures on LP64."
* commit '0287db52ed93df39ab45c7f60a241ae621866b90':
  Make pthread_create report sched_setscheduler failures on LP64.
2013-10-15 17:14:59 -07:00
Elliott Hughes
0287db52ed am d9913b0b: Merge "Make pthread_create report sched_setscheduler failures on LP64."
* commit 'd9913b0b0dfad473bd1cb81463ac0d6b68a0deb6':
  Make pthread_create report sched_setscheduler failures on LP64.
2013-10-15 17:12:16 -07:00
Elliott Hughes
d9913b0b0d Merge "Make pthread_create report sched_setscheduler failures on LP64." 2013-10-16 00:09:54 +00:00
Christopher Ferris
03ce517178 am fbefb252: Modify prefetch for krait memcpy.
* commit 'fbefb252b09634114977dbd1b48dd42bb2629b83':
  Modify prefetch for krait memcpy.
2013-10-15 17:08:32 -07:00
Elliott Hughes
df17ce7858 am 26491483: am 76725214: Merge "Avoid confusing "read prevented write" log messages."
* commit '264914838d1c22c15ed0069d1217a780835c6d1c':
  Avoid confusing "read prevented write" log messages.
2013-10-15 16:58:19 -07:00
Elliott Hughes
b01ebe6d4e am 14e7482c: am d16391bb: Merge "Fix indentation in sched_getaffinity."
* commit '14e7482c556820d8ad3b77f025dfc465d55c7262':
  Fix indentation in sched_getaffinity.
2013-10-15 16:58:19 -07:00
Elliott Hughes
264914838d am 76725214: Merge "Avoid confusing "read prevented write" log messages."
* commit '7672521440c8b7f98795c3fb4295227398e3e296':
  Avoid confusing "read prevented write" log messages.
2013-10-15 16:56:34 -07:00
Elliott Hughes
14e7482c55 am d16391bb: Merge "Fix indentation in sched_getaffinity."
* commit 'd16391bb88d92a58e3492921ac75a1d5d86031b7':
  Fix indentation in sched_getaffinity.
2013-10-15 16:56:33 -07:00
Elliott Hughes
7672521440 Merge "Avoid confusing "read prevented write" log messages." 2013-10-15 23:53:45 +00:00
Elliott Hughes
d16391bb88 Merge "Fix indentation in sched_getaffinity." 2013-10-15 23:53:25 +00:00
Elliott Hughes
98624c3746 Make pthread_create report sched_setscheduler failures on LP64.
We couldn't fix this for 32-bit because there's too much broken
code out there. (Pretty much everyone asks for real-time
scheduling for all their threads, and the kernel says "don't be
stupid".)

Change-Id: I43c5271e6b6bb91278b9a19eec08cbf05391e3c4
2013-10-15 16:51:17 -07:00
Elliott Hughes
0cfc95e010 Fix indentation in sched_getaffinity.
Change-Id: I966852149a0255ca132cd7a15f135a875ce400d0
2013-10-15 16:49:49 -07:00
Elliott Hughes
d1eda33f01 Avoid confusing "read prevented write" log messages.
Moving to a "function: message" style avoids ambiguity.

Change-Id: If9d590e50265c61725d3673bd03796e65edd2d5e
2013-10-15 16:49:28 -07:00
Christopher Ferris
289c460c55 am ac6bc319: Remove new aligned memcpy path for cortex-a15.
* commit 'ac6bc31942e58c8893c0695d9766d0f3e39335fe':
  Remove new aligned memcpy path for cortex-a15.
2013-10-15 16:17:14 -07:00
Christopher Ferris
fbefb252b0 Modify prefetch for krait memcpy.
I originally modified the krait mainloop prefetch from cacheline * 8 to * 2.
This causes a perf degradation for copies bigger than will fit in the cache.
Fixing this back to the original * 8. I tried other multiples, but * 8 is th
sweet spot on krait.

Bug: 11221806

(cherry picked from commit c3c58fb560)

Change-Id: I369f81d91ba97a3fcecac84ac57dec921b4758c8
2013-10-15 15:44:00 -07:00
Christopher Ferris
ac6bc31942 Remove new aligned memcpy path for cortex-a15.
For some reason the new cortex-a15 memcpy code from ARM is really bad
for really large copies. This change forces us to go down the old path
for all copies.

All of my benchmarks show the new version is faster for large copies, but
something is going on that I don't understand.

Bug: 10838353
Change-Id: I01c16d4a2575e76f4c69862c6f78fd9024eb3fb8
2013-10-15 14:54:02 -07:00
Christopher Ferris
6e96069a2b am d77ff4f4: am 76d78dc0: am dc9d8d05: Merge "Modify prefetch for krait memcpy."
* commit 'd77ff4f423c5b8235914d67af5b5ff450f8a2f95':
  Modify prefetch for krait memcpy.
2013-10-15 14:22:13 -07:00
Christopher Ferris
d77ff4f423 am 76d78dc0: am dc9d8d05: Merge "Modify prefetch for krait memcpy."
* commit '76d78dc0441ba982438ef613a8d6f2f65c6834e0':
  Modify prefetch for krait memcpy.
2013-10-15 14:19:27 -07:00
Elliott Hughes
1489e03d9f am 4681f824: am 5b3f1d8b: am 22b83da4: Merge "Clean up the sigprocmask/pthread_sigmask implementation."
* commit '4681f8244ee6fd3aec5a5c62e604e2a429d0d00f':
  Clean up the sigprocmask/pthread_sigmask implementation.
2013-10-15 14:18:45 -07:00
Christopher Ferris
76d78dc044 am dc9d8d05: Merge "Modify prefetch for krait memcpy."
* commit 'dc9d8d050a43e1cd32f1337e79187124bb15d938':
  Modify prefetch for krait memcpy.
2013-10-15 14:16:47 -07:00
Elliott Hughes
4681f8244e am 5b3f1d8b: am 22b83da4: Merge "Clean up the sigprocmask/pthread_sigmask implementation."
* commit '5b3f1d8b3a6a1caf059dc376e4967a27ddd57dac':
  Clean up the sigprocmask/pthread_sigmask implementation.
2013-10-15 14:16:02 -07:00
Elliott Hughes
5b3f1d8b3a am 22b83da4: Merge "Clean up the sigprocmask/pthread_sigmask implementation."
* commit '22b83da476263bff28fcc6a4696ced58b61d2c1d':
  Clean up the sigprocmask/pthread_sigmask implementation.
2013-10-15 14:13:32 -07:00
Christopher Ferris
dc9d8d050a Merge "Modify prefetch for krait memcpy." 2013-10-15 21:12:31 +00:00
Elliott Hughes
22b83da476 Merge "Clean up the sigprocmask/pthread_sigmask implementation." 2013-10-15 21:10:21 +00:00
Christopher Ferris
c3c58fb560 Modify prefetch for krait memcpy.
I originally modified the krait mainloop prefetch from cacheline * 8 to * 2.
This causes a perf degradation for copies bigger than will fit in the cache.
Fixing this back to the original * 8. I tried other multiples, but * 8 is th
sweet spot on krait.

Bug: 11221806

Change-Id: I1f75fad6440f7417e664795a6e7b5616f6a29c45
2013-10-15 12:10:06 -07:00
Elliott Hughes
19e62325c2 Clean up the sigprocmask/pthread_sigmask implementation.
Let's have both use rt_sigprocmask, like in glibc. The 64-bit ABIs
can share the same code as the 32-bit ABIs.

Also, let's test the return side of these calls, not just the
setting.

Bug: 11069919
Change-Id: I11da99f85b5b481870943c520d05ec929b15eddb
2013-10-15 11:23:57 -07:00
Stephen Hines
29f0db2148 am 8161b236: am 4691325d: am abeafbd6: Merge "Wrap sprintf()/snprintf() macros to prevent expansion errors."
* commit '8161b236891de223b0ebe9b76db57147d50a20f5':
  Wrap sprintf()/snprintf() macros to prevent expansion errors.
2013-10-14 10:48:52 -07:00
Stephen Hines
8e378473a3 am 78f6db64: am 36959302: am 8704ada3: Merge "Fix clang warnings in bionic."
* commit '78f6db64fe90e45f1cdb649543feb2d92696802a':
  Fix clang warnings in bionic.
2013-10-14 10:48:51 -07:00
Stephen Hines
8161b23689 am 4691325d: am abeafbd6: Merge "Wrap sprintf()/snprintf() macros to prevent expansion errors."
* commit '4691325d48406033632fe84a944ac9c3bd2e5097':
  Wrap sprintf()/snprintf() macros to prevent expansion errors.
2013-10-11 16:33:07 -07:00
Stephen Hines
78f6db64fe am 36959302: am 8704ada3: Merge "Fix clang warnings in bionic."
* commit '36959302a334499c7d2ddf4a090e2ab7e3a8ae1d':
  Fix clang warnings in bionic.
2013-10-11 16:33:03 -07:00
Stephen Hines
4691325d48 am abeafbd6: Merge "Wrap sprintf()/snprintf() macros to prevent expansion errors."
* commit 'abeafbd6d5e11044dd305e48134bc3d84319a3da':
  Wrap sprintf()/snprintf() macros to prevent expansion errors.
2013-10-11 16:30:04 -07:00
Stephen Hines
36959302a3 am 8704ada3: Merge "Fix clang warnings in bionic."
* commit '8704ada3d8fae067ed48c2b6da5a1ba4ab062e1a':
  Fix clang warnings in bionic.
2013-10-11 16:30:03 -07:00
Stephen Hines
abeafbd6d5 Merge "Wrap sprintf()/snprintf() macros to prevent expansion errors." 2013-10-11 23:28:32 +00:00
Stephen Hines
8704ada3d8 Merge "Fix clang warnings in bionic." 2013-10-11 23:27:40 +00:00
Stephen Hines
6c7b3cb056 Fix clang warnings in bionic.
This fixes a few diverse issues that clang warns on in bionic. First,
it specifies the appropriate converted types for format specifiers.
The "h" and "hh" modifiers specify that the user is passing a short or
char respectively. We were passing int deliberately in both cases and
relying on the compiler to implicitly downcast to the smaller type.
We also remove the non-standard "d" suffix from our double-precision
floating point constant. This is an extension for gcc that clang does
not implement. The third fix is to mark the c1 variable as unused,
since it truly is neither read nor written.

Change-Id: I4793352b9d3e58f1f4cac9e7581ef4b2a70b43c7
2013-10-11 16:20:08 -07:00
Stephen Hines
6e38072add Wrap sprintf()/snprintf() macros to prevent expansion errors.
Previously, FORTIFY_SOURCE used single macros to define these standard
functions for use with clang. This can cause conflicts with other macros used
to call these functions, particularly when those macros expand the number of
arguments to the function. This change wraps our macro definitions, so that
expansion properly takes place for programmer arguments first.

Change-Id: I55929b1fd2a643b9d14a17631c4bcab3b0b712cf
2013-10-11 12:14:49 -07:00
Nick Kralevich
197cabe25c am 49bb53c8: am 95de0df8: am eda2679e: Merge "FORTIFY_SOURCE: fortify read()"
* commit '49bb53c8e20ff37a1965ba4af645464ea4b8f8fa':
  FORTIFY_SOURCE: fortify read()
2013-10-10 08:24:00 -07:00
Elliott Hughes
d68e8a310f am 2d38f0c1: am 21d70d5f: am 39385aa7: Merge "Clean up the cpuacct cruft."
* commit '2d38f0c1c7ccb123a9a71dcabeb3650d8f5832b7':
  Clean up the cpuacct cruft.
2013-10-10 08:24:00 -07:00
Nick Kralevich
49bb53c8e2 am 95de0df8: am eda2679e: Merge "FORTIFY_SOURCE: fortify read()"
* commit '95de0df8c2daeefca358010f2d15c3346a5284f1':
  FORTIFY_SOURCE: fortify read()
2013-10-09 21:28:52 -07:00
Elliott Hughes
2d38f0c1c7 am 21d70d5f: am 39385aa7: Merge "Clean up the cpuacct cruft."
* commit '21d70d5fd8ff2823a6879d59c7d5a8d6c3e0ce8b':
  Clean up the cpuacct cruft.
2013-10-09 21:28:51 -07:00
Nick Kralevich
95de0df8c2 am eda2679e: Merge "FORTIFY_SOURCE: fortify read()"
* commit 'eda2679e30b997d036e0ec572cda054adc2ac3a6':
  FORTIFY_SOURCE: fortify read()
2013-10-09 21:25:51 -07:00
Elliott Hughes
21d70d5fd8 am 39385aa7: Merge "Clean up the cpuacct cruft."
* commit '39385aa78c5d437cfabc26a1bccdf050a8c94ac4':
  Clean up the cpuacct cruft.
2013-10-09 21:25:50 -07:00