generic-library/bionic
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Merge "Remove a spurious FIXME and unnecessary type cast."

Browse Source
This commit is contained in:
Ben Cheng
2013-05-07 23:56:11 +00:00
committed by Gerrit Code Review
parent b9256adab3 63dd03cced
commit ff220f7003
1 changed files with 1 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
libc/bionic/debug_stacktrace.cpp
View File

@@ -101,10 +101,7 @@ static _Unwind_Reason_Code trace_function(__unwind_context* context, void* arg)
if (ip != 0) { if (ip != 0) {
short* ptr = reinterpret_cast<short*>(ip); short* ptr = reinterpret_cast<short*>(ip);
// Thumb BLX(2) // Thumb BLX(2)
if ((*(ptr-1) & 0xff80) == 0x4780) {
// FIXME - GCC 4.7 seems to have a bug as without the unnecessary cast to
// short the test will never pass.
if ((*(ptr-1) & 0xff80) == (short) 0x4780) {
ip -= 2; ip -= 2;
} else { } else {
ip -= 4; ip -= 4;