generic-library/bionic
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Merge "bionic: clear only the part of the buffer which is not overwritten afterward"

Browse Source
This commit is contained in:
David Turner
2010-03-30 14:52:14 -07:00
committed by Android Code Review
parent acdb052030 3f61212781
commit f8916e2e45
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
libc/bionic/malloc_leak.c
View File

@@ -211,8 +211,7 @@ void get_malloc_leak_info(uint8_t** info, size_t* overallSize,
size_t entrySize = (sizeof(size_t) * 2) + (sizeof(intptr_t) * entry->numEntries); size_t entrySize = (sizeof(size_t) * 2) + (sizeof(intptr_t) * entry->numEntries);
if (entrySize < *infoSize) { if (entrySize < *infoSize) {
/* we're writing less than a full entry, clear out the rest */ /* we're writing less than a full entry, clear out the rest */
/* TODO: only clear out the part we're not overwriting? */ memset(head + entrySize, 0, *infoSize - entrySize);
memset(head, 0, *infoSize);
} else { } else {
/* make sure the amount we're copying doesn't exceed the limit */ /* make sure the amount we're copying doesn't exceed the limit */
entrySize = *infoSize; entrySize = *infoSize;