generic-library/bionic
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Merge "Fix protected symbol lookups for mips"

Browse Source
This commit is contained in:
Dmitriy Ivanov 2015-05-05 22:39:20 +00:00 committed by Gerrit Code Review
commit f3392791bc
2 changed files with 25 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
libc/include/elf.h
View File

@ -187,6 +187,11 @@ typedef struct {
#define STT_LOPROC 13
#define STT_HIPROC 15
#define STV_DEFAULT 0
#define STV_INTERNAL 1
#define STV_HIDDEN 2
#define STV_PROTECTED 3
/* The kernel uses NT_PRFPREG but glibc also offers NT_FPREGSET */
#define NT_FPREGSET NT_PRFPREG

26
linker/linker_mips.cpp
View File

@ -157,20 +157,34 @@ bool soinfo::mips_relocate_got(const VersionTracker& version_tracker,
soinfo* lsi = nullptr;
const ElfW(Sym)* s = nullptr;
const version_info* vi = nullptr;
ElfW(Word) st_visibility = (local_sym->st_other & 0x3);
if (!lookup_version_info(version_tracker, sym, sym_name, &vi)) {
return false;
}
if (st_visibility == STV_DEFAULT) {
const version_info* vi = nullptr;
if (!soinfo_do_lookup(this, sym_name, vi, &lsi, global_group, local_group, &s)) {
if (!lookup_version_info(version_tracker, sym, sym_name, &vi)) {
return false;
}
if (!soinfo_do_lookup(this, sym_name, vi, &lsi, global_group, local_group, &s)) {
return false;
}
} else if (st_visibility == STV_PROTECTED) {
if (local_sym->st_value == 0) {
DL_ERR("%s: invalid symbol \"%s\" (PROTECTED/UNDEFINED) ", get_soname(), sym_name);
return false;
}
s = local_sym;
lsi = this;
} else {
DL_ERR("%s: invalid symbol \"%s\" visibility: 0x%x", get_soname(), sym_name, st_visibility);
return false;
}
if (s == nullptr) {
// We only allow an undefined symbol if this is a weak reference.
if (ELF_ST_BIND(local_sym->st_info) != STB_WEAK) {
DL_ERR("cannot locate \"%s\"...", sym_name);
DL_ERR("%s: cannot locate \"%s\"...", get_soname(), sym_name);
return false;
}
*got = 0;