generic-library/bionic
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

am 1e07463f: Merge "Add tests for fprintf behavior when the underlying fd is bad."

Browse Source 
* commit '1e07463fcc92e515f7f57e9faa94f31e02cd07cb':
  Add tests for fprintf behavior when the underlying fd is bad.
This commit is contained in:
Elliott Hughes 2014-05-14 23:51:56 +00:00 committed by Android Git Automerger
commit f015757fc6
1 changed files with 23 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
tests/stdio_test.cpp
View File

@ -17,6 +17,7 @@
#include <gtest/gtest.h> #include <gtest/gtest.h>
#include <errno.h> #include <errno.h>
#include <fcntl.h>
#include <limits.h> #include <limits.h>
#include <math.h> #include <math.h>
#include <stdio.h> #include <stdio.h>
@ -407,6 +408,28 @@ TEST(stdio, snprintf_negative_zero_5084292) {
EXPECT_STREQ("-0.000000", buf); EXPECT_STREQ("-0.000000", buf);
} }
TEST(stdio, fprintf_failures_7229520) {
FILE* fp;
// Unbuffered case where the fprintf(3) itself fails.
ASSERT_NE(nullptr, fp = tmpfile());
setbuf(fp, NULL);
ASSERT_EQ(4, fprintf(fp, "epic"));
ASSERT_EQ(0, close(fileno(fp)));
ASSERT_EQ(-1, fprintf(fp, "fail"));
ASSERT_EQ(-1, fclose(fp));
// Buffered case where we won't notice until the fclose(3).
// It's likely this is what was actually seen in http://b/7229520,
// and that expecting fprintf to fail is setting yourself up for
// disappointment. Remember to check fclose(3)'s return value, kids!
ASSERT_NE(nullptr, fp = tmpfile());
ASSERT_EQ(4, fprintf(fp, "epic"));
ASSERT_EQ(0, close(fileno(fp)));
ASSERT_EQ(4, fprintf(fp, "fail"));
ASSERT_EQ(-1, fclose(fp));
}
TEST(stdio, popen) { TEST(stdio, popen) {
FILE* fp = popen("cat /proc/version", "r"); FILE* fp = popen("cat /proc/version", "r");
ASSERT_TRUE(fp != NULL); ASSERT_TRUE(fp != NULL);