generic-library/bionic
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

string: Fix wrong comparison semantics

Browse Source 
Chars are signed for x86 -- correct the comparison semantics.

Change-Id: I2049e98eb063c0b4e83ea973d3fcae49c6817dde
Author: Liubov Dmitrieva <liubov.dmitrieva@intel.com>
Signed-off-by: Bruce Beare <bruce.j.beare@intel.com>
This commit is contained in:
Bruce Beare 2011-10-25 13:06:09 +04:00 committed by Jean-Baptiste Queru
parent 89d3fdcae2
commit cb1df91616
4 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libc/string/index.c
View File

@ -34,7 +34,7 @@ char *
index(const char *p, int ch) index(const char *p, int ch)
{ {
for (;; ++p) { for (;; ++p) {
if (*p == ch) if (*p == (char) ch)
return((char *)p); return((char *)p);
if (!*p) if (!*p)
return((char *)NULL); return((char *)NULL);

8
libc/string/memrchr.c
View File

@ -35,10 +35,10 @@ void *memrchr(const void *s, int c, size_t n)
const char* q = p + n; const char* q = p + n;
while (1) { while (1) {
q--; if (q < p || q[0] == c) break; q--; if (q < p || q[0] == (char) c) break;
q--; if (q < p || q[0] == c) break; q--; if (q < p || q[0] == (char) c) break;
q--; if (q < p || q[0] == c) break; q--; if (q < p || q[0] == (char) c) break;
q--; if (q < p || q[0] == c) break; q--; if (q < p || q[0] == (char) c) break;
} }
if (q >= p) if (q >= p)
return (void*)q; return (void*)q;

2
libc/string/strchr.c
View File

@ -34,7 +34,7 @@ char *
strchr(const char *p, int ch) strchr(const char *p, int ch)
{ {
for (;; ++p) { for (;; ++p) {
if (*p == ch) if (*p == (char) ch)
return((char *)p); return((char *)p);
if (!*p) if (!*p)
return((char *)NULL); return((char *)NULL);

2
libc/string/strrchr.c
View File

@ -36,7 +36,7 @@ strrchr(const char *p, int ch)
char *save; char *save;
for (save = NULL;; ++p) { for (save = NULL;; ++p) {
if (*p == ch) if (*p == (char) ch)
save = (char *)p; save = (char *)p;
if (!*p) if (!*p)
return(save); return(save);