From c92f9f8069f567ad2c2557e2ef56e13de4bf8713 Mon Sep 17 00:00:00 2001 From: Nick Kralevich Date: Sun, 31 May 2015 13:43:13 -0700 Subject: [PATCH] libc: Add O_PATH support for fgetxattr / fsetxattr Support O_PATH file descriptors when handling fgetxattr and fsetxattr. This avoids requiring file read access to pull extended attributes. This is needed to support O_PATH file descriptors when calling SELinux's fgetfilecon() call. In particular, this allows the querying and setting of SELinux file context by using something like the following code: int dirfd = open("/path/to/dir", O_DIRECTORY); int fd = openat(dirfd, "file", O_PATH | O_NOFOLLOW); char *context; fgetfilecon(fd, &context); This change was motivated by a comment in https://android-review.googlesource.com/#/c/152680/1/toys/posix/ls.c (cherrypicked from commit 2825f10b7f61558c264231a536cf3affc0d84204) Change-Id: Ic0cdf9f9dd0e35a63b44a4c4a08400020041eddf --- libc/Android.mk | 2 + libc/SYSCALLS.TXT | 4 +- .../syscalls/{fgetxattr.S => ___fgetxattr.S} | 5 +- .../syscalls/{fsetxattr.S => ___fsetxattr.S} | 5 +- .../syscalls/{fgetxattr.S => ___fgetxattr.S} | 5 +- .../syscalls/{fsetxattr.S => ___fsetxattr.S} | 5 +- .../syscalls/{fgetxattr.S => ___fgetxattr.S} | 5 +- .../syscalls/{fsetxattr.S => ___fsetxattr.S} | 5 +- .../syscalls/{fgetxattr.S => ___fgetxattr.S} | 5 +- .../syscalls/{fsetxattr.S => ___fsetxattr.S} | 5 +- .../syscalls/{fgetxattr.S => ___fgetxattr.S} | 5 +- .../syscalls/{fsetxattr.S => ___fsetxattr.S} | 5 +- .../syscalls/{fgetxattr.S => ___fgetxattr.S} | 5 +- .../syscalls/{fsetxattr.S => ___fsetxattr.S} | 5 +- libc/bionic/fgetxattr.cpp | 59 +++++++++++ libc/bionic/fsetxattr.cpp | 59 +++++++++++ tests/Android.mk | 1 + tests/sys_xattr_test.cpp | 100 ++++++++++++++++++ 18 files changed, 259 insertions(+), 26 deletions(-) rename libc/arch-arm/syscalls/{fgetxattr.S => ___fgetxattr.S} (81%) rename libc/arch-arm/syscalls/{fsetxattr.S => ___fsetxattr.S} (89%) rename libc/arch-arm64/syscalls/{fgetxattr.S => ___fgetxattr.S} (79%) rename libc/arch-arm64/syscalls/{fsetxattr.S => ___fsetxattr.S} (79%) rename libc/arch-mips/syscalls/{fgetxattr.S => ___fgetxattr.S} (82%) rename libc/arch-mips/syscalls/{fsetxattr.S => ___fsetxattr.S} (82%) rename libc/arch-mips64/syscalls/{fgetxattr.S => ___fgetxattr.S} (85%) rename libc/arch-mips64/syscalls/{fsetxattr.S => ___fsetxattr.S} (85%) rename libc/arch-x86/syscalls/{fgetxattr.S => ___fgetxattr.S} (92%) rename libc/arch-x86/syscalls/{fsetxattr.S => ___fsetxattr.S} (93%) rename libc/arch-x86_64/syscalls/{fgetxattr.S => ___fgetxattr.S} (82%) rename libc/arch-x86_64/syscalls/{fsetxattr.S => ___fsetxattr.S} (82%) create mode 100644 libc/bionic/fgetxattr.cpp create mode 100644 libc/bionic/fsetxattr.cpp create mode 100644 tests/sys_xattr_test.cpp diff --git a/libc/Android.mk b/libc/Android.mk index d6274dd82..4dd108653 100644 --- a/libc/Android.mk +++ b/libc/Android.mk @@ -129,8 +129,10 @@ libc_bionic_ndk_src_files := \ bionic/fchmod.cpp \ bionic/fchmodat.cpp \ bionic/ffs.cpp \ + bionic/fgetxattr.cpp \ bionic/flockfile.cpp \ bionic/fpclassify.cpp \ + bionic/fsetxattr.cpp \ bionic/ftruncate.cpp \ bionic/futimens.cpp \ bionic/getcwd.cpp \ diff --git a/libc/SYSCALLS.TXT b/libc/SYSCALLS.TXT index 9d7f839c6..4890b89a2 100644 --- a/libc/SYSCALLS.TXT +++ b/libc/SYSCALLS.TXT @@ -122,8 +122,8 @@ int fdatasync(int) all int fchown:fchown32(int, uid_t, gid_t) arm,x86 int fchown:fchown(int, uid_t, gid_t) arm64,mips,mips64,x86_64 void sync(void) all -int fsetxattr(int, const char*, const void*, size_t, int) all -ssize_t fgetxattr(int, const char*, void*, size_t) all +int ___fsetxattr:fsetxattr(int, const char*, const void*, size_t, int) all +ssize_t ___fgetxattr:fgetxattr(int, const char*, void*, size_t) all ssize_t flistxattr(int, char*, size_t) all int fremovexattr(int, const char*) all diff --git a/libc/arch-arm/syscalls/fgetxattr.S b/libc/arch-arm/syscalls/___fgetxattr.S similarity index 81% rename from libc/arch-arm/syscalls/fgetxattr.S rename to libc/arch-arm/syscalls/___fgetxattr.S index 3f1e5fc4e..e776cd6d3 100644 --- a/libc/arch-arm/syscalls/fgetxattr.S +++ b/libc/arch-arm/syscalls/___fgetxattr.S @@ -2,7 +2,7 @@ #include -ENTRY(fgetxattr) +ENTRY(___fgetxattr) mov ip, r7 ldr r7, =__NR_fgetxattr swi #0 @@ -11,4 +11,5 @@ ENTRY(fgetxattr) bxls lr neg r0, r0 b __set_errno_internal -END(fgetxattr) +END(___fgetxattr) +.hidden ___fgetxattr diff --git a/libc/arch-arm/syscalls/fsetxattr.S b/libc/arch-arm/syscalls/___fsetxattr.S similarity index 89% rename from libc/arch-arm/syscalls/fsetxattr.S rename to libc/arch-arm/syscalls/___fsetxattr.S index 0e33ad29f..544519173 100644 --- a/libc/arch-arm/syscalls/fsetxattr.S +++ b/libc/arch-arm/syscalls/___fsetxattr.S @@ -2,7 +2,7 @@ #include -ENTRY(fsetxattr) +ENTRY(___fsetxattr) mov ip, sp stmfd sp!, {r4, r5, r6, r7} .cfi_def_cfa_offset 16 @@ -19,4 +19,5 @@ ENTRY(fsetxattr) bxls lr neg r0, r0 b __set_errno_internal -END(fsetxattr) +END(___fsetxattr) +.hidden ___fsetxattr diff --git a/libc/arch-arm64/syscalls/fgetxattr.S b/libc/arch-arm64/syscalls/___fgetxattr.S similarity index 79% rename from libc/arch-arm64/syscalls/fgetxattr.S rename to libc/arch-arm64/syscalls/___fgetxattr.S index 0d6ada791..c0334cc77 100644 --- a/libc/arch-arm64/syscalls/fgetxattr.S +++ b/libc/arch-arm64/syscalls/___fgetxattr.S @@ -2,7 +2,7 @@ #include -ENTRY(fgetxattr) +ENTRY(___fgetxattr) mov x8, __NR_fgetxattr svc #0 @@ -11,4 +11,5 @@ ENTRY(fgetxattr) b.hi __set_errno_internal ret -END(fgetxattr) +END(___fgetxattr) +.hidden ___fgetxattr diff --git a/libc/arch-arm64/syscalls/fsetxattr.S b/libc/arch-arm64/syscalls/___fsetxattr.S similarity index 79% rename from libc/arch-arm64/syscalls/fsetxattr.S rename to libc/arch-arm64/syscalls/___fsetxattr.S index e69e718b0..92be8decb 100644 --- a/libc/arch-arm64/syscalls/fsetxattr.S +++ b/libc/arch-arm64/syscalls/___fsetxattr.S @@ -2,7 +2,7 @@ #include -ENTRY(fsetxattr) +ENTRY(___fsetxattr) mov x8, __NR_fsetxattr svc #0 @@ -11,4 +11,5 @@ ENTRY(fsetxattr) b.hi __set_errno_internal ret -END(fsetxattr) +END(___fsetxattr) +.hidden ___fsetxattr diff --git a/libc/arch-mips/syscalls/fgetxattr.S b/libc/arch-mips/syscalls/___fgetxattr.S similarity index 82% rename from libc/arch-mips/syscalls/fgetxattr.S rename to libc/arch-mips/syscalls/___fgetxattr.S index 6516feb03..50ab69cd2 100644 --- a/libc/arch-mips/syscalls/fgetxattr.S +++ b/libc/arch-mips/syscalls/___fgetxattr.S @@ -2,7 +2,7 @@ #include -ENTRY(fgetxattr) +ENTRY(___fgetxattr) .set noreorder .cpload t9 li v0, __NR_fgetxattr @@ -16,4 +16,5 @@ ENTRY(fgetxattr) j t9 nop .set reorder -END(fgetxattr) +END(___fgetxattr) +.hidden ___fgetxattr diff --git a/libc/arch-mips/syscalls/fsetxattr.S b/libc/arch-mips/syscalls/___fsetxattr.S similarity index 82% rename from libc/arch-mips/syscalls/fsetxattr.S rename to libc/arch-mips/syscalls/___fsetxattr.S index 663c0df00..03129218f 100644 --- a/libc/arch-mips/syscalls/fsetxattr.S +++ b/libc/arch-mips/syscalls/___fsetxattr.S @@ -2,7 +2,7 @@ #include -ENTRY(fsetxattr) +ENTRY(___fsetxattr) .set noreorder .cpload t9 li v0, __NR_fsetxattr @@ -16,4 +16,5 @@ ENTRY(fsetxattr) j t9 nop .set reorder -END(fsetxattr) +END(___fsetxattr) +.hidden ___fsetxattr diff --git a/libc/arch-mips64/syscalls/fgetxattr.S b/libc/arch-mips64/syscalls/___fgetxattr.S similarity index 85% rename from libc/arch-mips64/syscalls/fgetxattr.S rename to libc/arch-mips64/syscalls/___fgetxattr.S index 44c248a38..935b080f6 100644 --- a/libc/arch-mips64/syscalls/fgetxattr.S +++ b/libc/arch-mips64/syscalls/___fgetxattr.S @@ -2,7 +2,7 @@ #include -ENTRY(fgetxattr) +ENTRY(___fgetxattr) .set push .set noreorder li v0, __NR_fgetxattr @@ -22,4 +22,5 @@ ENTRY(fgetxattr) j t9 move ra, t0 .set pop -END(fgetxattr) +END(___fgetxattr) +.hidden ___fgetxattr diff --git a/libc/arch-mips64/syscalls/fsetxattr.S b/libc/arch-mips64/syscalls/___fsetxattr.S similarity index 85% rename from libc/arch-mips64/syscalls/fsetxattr.S rename to libc/arch-mips64/syscalls/___fsetxattr.S index 0ad1f9000..c02f406ef 100644 --- a/libc/arch-mips64/syscalls/fsetxattr.S +++ b/libc/arch-mips64/syscalls/___fsetxattr.S @@ -2,7 +2,7 @@ #include -ENTRY(fsetxattr) +ENTRY(___fsetxattr) .set push .set noreorder li v0, __NR_fsetxattr @@ -22,4 +22,5 @@ ENTRY(fsetxattr) j t9 move ra, t0 .set pop -END(fsetxattr) +END(___fsetxattr) +.hidden ___fsetxattr diff --git a/libc/arch-x86/syscalls/fgetxattr.S b/libc/arch-x86/syscalls/___fgetxattr.S similarity index 92% rename from libc/arch-x86/syscalls/fgetxattr.S rename to libc/arch-x86/syscalls/___fgetxattr.S index 1eff93172..28915113c 100644 --- a/libc/arch-x86/syscalls/fgetxattr.S +++ b/libc/arch-x86/syscalls/___fgetxattr.S @@ -2,7 +2,7 @@ #include -ENTRY(fgetxattr) +ENTRY(___fgetxattr) pushl %ebx .cfi_def_cfa_offset 8 .cfi_rel_offset ebx, 0 @@ -33,4 +33,5 @@ ENTRY(fgetxattr) popl %ecx popl %ebx ret -END(fgetxattr) +END(___fgetxattr) +.hidden ___fgetxattr diff --git a/libc/arch-x86/syscalls/fsetxattr.S b/libc/arch-x86/syscalls/___fsetxattr.S similarity index 93% rename from libc/arch-x86/syscalls/fsetxattr.S rename to libc/arch-x86/syscalls/___fsetxattr.S index 7af0ef02a..287dafcda 100644 --- a/libc/arch-x86/syscalls/fsetxattr.S +++ b/libc/arch-x86/syscalls/___fsetxattr.S @@ -2,7 +2,7 @@ #include -ENTRY(fsetxattr) +ENTRY(___fsetxattr) pushl %ebx .cfi_def_cfa_offset 8 .cfi_rel_offset ebx, 0 @@ -38,4 +38,5 @@ ENTRY(fsetxattr) popl %ecx popl %ebx ret -END(fsetxattr) +END(___fsetxattr) +.hidden ___fsetxattr diff --git a/libc/arch-x86_64/syscalls/fgetxattr.S b/libc/arch-x86_64/syscalls/___fgetxattr.S similarity index 82% rename from libc/arch-x86_64/syscalls/fgetxattr.S rename to libc/arch-x86_64/syscalls/___fgetxattr.S index 7762474f9..302fd77fb 100644 --- a/libc/arch-x86_64/syscalls/fgetxattr.S +++ b/libc/arch-x86_64/syscalls/___fgetxattr.S @@ -2,7 +2,7 @@ #include -ENTRY(fgetxattr) +ENTRY(___fgetxattr) movq %rcx, %r10 movl $__NR_fgetxattr, %eax syscall @@ -13,4 +13,5 @@ ENTRY(fgetxattr) call __set_errno_internal 1: ret -END(fgetxattr) +END(___fgetxattr) +.hidden ___fgetxattr diff --git a/libc/arch-x86_64/syscalls/fsetxattr.S b/libc/arch-x86_64/syscalls/___fsetxattr.S similarity index 82% rename from libc/arch-x86_64/syscalls/fsetxattr.S rename to libc/arch-x86_64/syscalls/___fsetxattr.S index 97822c4c8..125ef2065 100644 --- a/libc/arch-x86_64/syscalls/fsetxattr.S +++ b/libc/arch-x86_64/syscalls/___fsetxattr.S @@ -2,7 +2,7 @@ #include -ENTRY(fsetxattr) +ENTRY(___fsetxattr) movq %rcx, %r10 movl $__NR_fsetxattr, %eax syscall @@ -13,4 +13,5 @@ ENTRY(fsetxattr) call __set_errno_internal 1: ret -END(fsetxattr) +END(___fsetxattr) +.hidden ___fsetxattr diff --git a/libc/bionic/fgetxattr.cpp b/libc/bionic/fgetxattr.cpp new file mode 100644 index 000000000..6d999bf5c --- /dev/null +++ b/libc/bionic/fgetxattr.cpp @@ -0,0 +1,59 @@ +/* + * Copyright (C) 2015 The Android Open Source Project + * All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * * Redistributions of source code must retain the above copyright + * notice, this list of conditions and the following disclaimer. + * * Redistributions in binary form must reproduce the above copyright + * notice, this list of conditions and the following disclaimer in + * the documentation and/or other materials provided with the + * distribution. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS + * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE + * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, + * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, + * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS + * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED + * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, + * OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT + * OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF + * SUCH DAMAGE. + */ + +#include +#include +#include +#include +#include +#include + +extern "C" ssize_t ___fgetxattr(int, const char*, void*, size_t); + +ssize_t fgetxattr(int fd, const char *name, void *value, size_t size) { + int saved_errno = errno; + ssize_t result = ___fgetxattr(fd, name, value, size); + + if ((result != -1) || (errno != EBADF)) { + return result; + } + + // fd could be an O_PATH file descriptor, and the kernel + // may not directly support fgetxattr() on such a file descriptor. + // Use /proc/self/fd instead to emulate this support. + int fd_flag = fcntl(fd, F_GETFL); + if ((fd_flag == -1) || ((fd_flag & O_PATH) == 0)) { + errno = EBADF; + return -1; + } + + char buf[40]; + snprintf(buf, sizeof(buf), "/proc/self/fd/%d", fd); + errno = saved_errno; + return getxattr(buf, name, value, size); +} diff --git a/libc/bionic/fsetxattr.cpp b/libc/bionic/fsetxattr.cpp new file mode 100644 index 000000000..6d2e868f3 --- /dev/null +++ b/libc/bionic/fsetxattr.cpp @@ -0,0 +1,59 @@ +/* + * Copyright (C) 2015 The Android Open Source Project + * All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * * Redistributions of source code must retain the above copyright + * notice, this list of conditions and the following disclaimer. + * * Redistributions in binary form must reproduce the above copyright + * notice, this list of conditions and the following disclaimer in + * the documentation and/or other materials provided with the + * distribution. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS + * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE + * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, + * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, + * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS + * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED + * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, + * OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT + * OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF + * SUCH DAMAGE. + */ + +#include +#include +#include +#include +#include +#include + +extern "C" int ___fsetxattr(int, const char*, const void*, size_t, int); + +int fsetxattr(int fd, const char* name, const void* value, size_t size, int flags) { + int saved_errno = errno; + int result = ___fsetxattr(fd, name, value, size, flags); + + if ((result == 0) || (errno != EBADF)) { + return result; + } + + // fd could be an O_PATH file descriptor, and the kernel + // may not directly support fsetxattr() on such a file descriptor. + // Use /proc/self/fd instead to emulate this support. + int fd_flag = fcntl(fd, F_GETFL); + if ((fd_flag == -1) || ((fd_flag & O_PATH) == 0)) { + errno = EBADF; + return -1; + } + + char buf[40]; + snprintf(buf, sizeof(buf), "/proc/self/fd/%d", fd); + errno = saved_errno; + return setxattr(buf, name, value, size, flags); +} diff --git a/tests/Android.mk b/tests/Android.mk index 0f3454cbf..37f7b4f43 100644 --- a/tests/Android.mk +++ b/tests/Android.mk @@ -107,6 +107,7 @@ libBionicStandardTests_src_files := \ sys_time_test.cpp \ sys_types_test.cpp \ sys_vfs_test.cpp \ + sys_xattr_test.cpp \ system_properties_test.cpp \ time_test.cpp \ uchar_test.cpp \ diff --git a/tests/sys_xattr_test.cpp b/tests/sys_xattr_test.cpp new file mode 100644 index 000000000..184268220 --- /dev/null +++ b/tests/sys_xattr_test.cpp @@ -0,0 +1,100 @@ +/* + * Copyright (C) 2015 The Android Open Source Project + * + * Licensed under the Apache License, Version 2.0 (the "License"); + * you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +#include + +#include +#include + +#include "TemporaryFile.h" + +TEST(sys_xattr, setxattr) { + TemporaryFile tf; + char buf[10]; + ASSERT_EQ(0, setxattr(tf.filename, "user.foo", "bar", 4, 0)); + ASSERT_EQ(4, getxattr(tf.filename, "user.foo", buf, sizeof(buf))); + ASSERT_STREQ("bar", buf); + buf[0] = '\0'; + ASSERT_EQ(4, lgetxattr(tf.filename, "user.foo", buf, sizeof(buf))); + ASSERT_STREQ("bar", buf); +} + +TEST(sys_xattr, fsetxattr) { + TemporaryFile tf; + char buf[10]; + ASSERT_EQ(0, fsetxattr(tf.fd, "user.foo", "bar", 4, 0)); + ASSERT_EQ(4, fgetxattr(tf.fd, "user.foo", buf, sizeof(buf))); + ASSERT_STREQ("bar", buf); +} + +TEST(sys_xattr, fsetxattr_zerobuf) { + TemporaryFile tf; + char buf[10]; + ASSERT_EQ(0, fsetxattr(tf.fd, "user.foo", "", 0, 0)); + ASSERT_EQ(0, fgetxattr(tf.fd, "user.foo", buf, sizeof(buf))); +} + +TEST(sys_xattr, fsetxattr_toosmallbuf) { + TemporaryFile tf; + char buf[10]; + ASSERT_EQ(0, fsetxattr(tf.fd, "user.foo", "01234567890123456789", 21, 0)); + ASSERT_EQ(-1, fgetxattr(tf.fd, "user.foo", buf, sizeof(buf))); + ASSERT_EQ(ERANGE, errno); +} + +TEST(sys_xattr, fsetxattr_invalidfd) { + char buf[10]; + errno = 0; + ASSERT_EQ(-1, fsetxattr(65535, "user.foo", "0123", 5, 0)); + ASSERT_EQ(EBADF, errno); + errno = 0; + ASSERT_EQ(-1, fgetxattr(65535, "user.foo", buf, sizeof(buf))); + ASSERT_EQ(EBADF, errno); +} + +TEST(sys_xattr, fsetxattr_with_opath) { + TemporaryFile tf; + int fd = open(tf.filename, O_PATH); + ASSERT_NE(-1, fd); + + int res = fsetxattr(fd, "user.foo", "bar", 4, 0); +#if defined(__BIONIC__) + char buf[10]; + ASSERT_EQ(0, res); + ASSERT_EQ(4, fgetxattr(fd, "user.foo", buf, sizeof(buf))); + ASSERT_STREQ("bar", buf); +#else + ASSERT_EQ(-1, res); + ASSERT_EQ(EBADF, errno); +#endif +} + +TEST(sys_xattr, fsetxattr_with_opath_toosmall) { + TemporaryFile tf; + int fd = open(tf.filename, O_PATH); + ASSERT_NE(-1, fd); + + int res = fsetxattr(fd, "user.foo", "01234567890123456789", 21, 0); +#if defined(__BIONIC__) + char buf[10]; + ASSERT_EQ(0, res); + ASSERT_EQ(-1, fgetxattr(fd, "user.foo", buf, sizeof(buf))); + ASSERT_EQ(ERANGE, errno); +#else + ASSERT_EQ(-1, res); + ASSERT_EQ(EBADF, errno); +#endif +}