From e4c6b08c4e81f640afc502804d1226a3e79dc26d Mon Sep 17 00:00:00 2001 From: Nick Kralevich Date: Wed, 18 Dec 2013 19:17:14 -0800 Subject: [PATCH] Clean up more recursive FORTIFY_SOURCE calls Don't use FORTIFY_SOURCE on functions which implement FORTIFY_SOURCE, to avoid infinite recursion problems. The previous patch only addressed one of the problems. Bug: 12216860 Change-Id: I6f30ae7cb5b481be9942add18182ea4839d348a6 --- libc/bionic/__fgets_chk.cpp | 2 ++ libc/bionic/__memmove_chk.cpp | 2 ++ libc/bionic/__memset_chk.cpp | 2 ++ libc/bionic/__strlcat_chk.cpp | 2 ++ libc/bionic/__strlcpy_chk.cpp | 2 ++ libc/bionic/__strncpy_chk.cpp | 2 ++ libc/bionic/__vsnprintf_chk.cpp | 2 ++ libc/bionic/__vsprintf_chk.cpp | 2 ++ 8 files changed, 16 insertions(+) diff --git a/libc/bionic/__fgets_chk.cpp b/libc/bionic/__fgets_chk.cpp index 61dad7077..c09f6c531 100644 --- a/libc/bionic/__fgets_chk.cpp +++ b/libc/bionic/__fgets_chk.cpp @@ -26,6 +26,8 @@ * SUCH DAMAGE. */ +#undef _FORTIFY_SOURCE + #include #include #include "private/libc_logging.h" diff --git a/libc/bionic/__memmove_chk.cpp b/libc/bionic/__memmove_chk.cpp index 26bd646cd..b88a94f76 100644 --- a/libc/bionic/__memmove_chk.cpp +++ b/libc/bionic/__memmove_chk.cpp @@ -26,6 +26,8 @@ * SUCH DAMAGE. */ +#undef _FORTIFY_SOURCE + #include #include #include "private/libc_logging.h" diff --git a/libc/bionic/__memset_chk.cpp b/libc/bionic/__memset_chk.cpp index 9a3be19dd..5f20452f5 100644 --- a/libc/bionic/__memset_chk.cpp +++ b/libc/bionic/__memset_chk.cpp @@ -26,6 +26,8 @@ * SUCH DAMAGE. */ +#undef _FORTIFY_SOURCE + #include #include #include "private/libc_logging.h" diff --git a/libc/bionic/__strlcat_chk.cpp b/libc/bionic/__strlcat_chk.cpp index f583154ae..2b7373b9d 100644 --- a/libc/bionic/__strlcat_chk.cpp +++ b/libc/bionic/__strlcat_chk.cpp @@ -26,6 +26,8 @@ * SUCH DAMAGE. */ +#undef _FORTIFY_SOURCE + #include #include #include "private/libc_logging.h" diff --git a/libc/bionic/__strlcpy_chk.cpp b/libc/bionic/__strlcpy_chk.cpp index ebf1444b9..6b2187932 100644 --- a/libc/bionic/__strlcpy_chk.cpp +++ b/libc/bionic/__strlcpy_chk.cpp @@ -26,6 +26,8 @@ * SUCH DAMAGE. */ +#undef _FORTIFY_SOURCE + #include #include #include "private/libc_logging.h" diff --git a/libc/bionic/__strncpy_chk.cpp b/libc/bionic/__strncpy_chk.cpp index 76458aa74..9625929cd 100644 --- a/libc/bionic/__strncpy_chk.cpp +++ b/libc/bionic/__strncpy_chk.cpp @@ -26,6 +26,8 @@ * SUCH DAMAGE. */ +#undef _FORTIFY_SOURCE + #include #include #include "private/libc_logging.h" diff --git a/libc/bionic/__vsnprintf_chk.cpp b/libc/bionic/__vsnprintf_chk.cpp index 8550224b3..8c0911162 100644 --- a/libc/bionic/__vsnprintf_chk.cpp +++ b/libc/bionic/__vsnprintf_chk.cpp @@ -26,6 +26,8 @@ * SUCH DAMAGE. */ +#undef _FORTIFY_SOURCE + #include #include #include diff --git a/libc/bionic/__vsprintf_chk.cpp b/libc/bionic/__vsprintf_chk.cpp index bd2aeaba5..5914026b0 100644 --- a/libc/bionic/__vsprintf_chk.cpp +++ b/libc/bionic/__vsprintf_chk.cpp @@ -26,6 +26,8 @@ * SUCH DAMAGE. */ +#undef _FORTIFY_SOURCE + #include #include #include