generic-library/bionic
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Use the stmdb instead of str to save the fn/arg

Browse Source 
Directly save data into stack without properly adjustment
   of stack point is dangous. For example, if a signal comes,
   kernel will put sigframe into userspace's stack, which
   will overwrite the saved data if sp is not adjusted properly.

Bug: 15195265
Change-Id: Iea0cadfd3b94d50cf40252ad52fe5950811b9192
Signed-off-by: Jiangli Yuan <a6808c@motorola.com>
This commit is contained in:
Jiangli Yuan 2014-12-09 17:02:59 -08:00 committed by Elliott Hughes
parent 3f1c604c9d
commit c3d1728583
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
libc/arch-arm/bionic/__bionic_clone.S
View File

@ -43,8 +43,7 @@ ENTRY(__bionic_clone)
ldmfd ip, {r4, r5, r6}
# store 'fn' and 'arg' to the child stack
str r5, [r1, #-4]
str r6, [r1, #-8]
stmdb r1!, {r5, r6}
# System call
ldr r7, =__NR_clone
@ -62,8 +61,7 @@ ENTRY(__bionic_clone)
1: # The child.
# Setting lr to 0 will make the unwinder stop at __start_thread
mov lr, #0
ldr r0, [sp, #-4]
ldr r1, [sp, #-8]
pop {r0, r1}
b __start_thread
END(__bionic_clone)
.hidden __bionic_clone