diff --git a/libc/Android.mk b/libc/Android.mk index b77e3941f..0e45c0d56 100644 --- a/libc/Android.mk +++ b/libc/Android.mk @@ -180,6 +180,7 @@ libc_common_src_files += \ bionic/fstatfs.c \ bionic/__get_tls.cpp \ bionic/lseek64.c \ + bionic/ndk_cruft.cpp \ bionic/statfs.c \ endif diff --git a/libc/bionic/ndk_cruft.cpp b/libc/bionic/ndk_cruft.cpp new file mode 100644 index 000000000..cbdc6e65a --- /dev/null +++ b/libc/bionic/ndk_cruft.cpp @@ -0,0 +1,55 @@ +/* + * Copyright (C) 2013 The Android Open Source Project + * All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions + * are met: + * * Redistributions of source code must retain the above copyright + * notice, this list of conditions and the following disclaimer. + * * Redistributions in binary form must reproduce the above copyright + * notice, this list of conditions and the following disclaimer in + * the documentation and/or other materials provided with the + * distribution. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS + * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT + * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS + * FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE + * COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, + * INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, + * BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS + * OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED + * AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, + * OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT + * OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF + * SUCH DAMAGE. + */ + +// This file perpetuates the mistakes of the past, but only for 32-bit targets. +#if !defined(__LP64__) + +#include +#include +#include +#include +#include +#include + +// These were accidentally declared in because we stupidly used to inline +// getpagesize() and __getpageshift(). Needed for backwards compatibility with old NDK apps. +extern "C" { + unsigned int __page_size = PAGE_SIZE; + unsigned int __page_shift = PAGE_SHIFT; +} + +// TODO: remove this backward compatibility hack (for jb-mr1 strace binaries). +extern "C" pid_t __wait4(pid_t pid, int* status, int options, struct rusage* rusage) { + return wait4(pid, status, options, rusage); +} + +extern "C" int __open() { + abort(); +} + +#endif diff --git a/libc/bionic/stubs.cpp b/libc/bionic/stubs.cpp index 56f5c045f..6edaa19e7 100644 --- a/libc/bionic/stubs.cpp +++ b/libc/bionic/stubs.cpp @@ -474,10 +474,3 @@ void endusershell() { int getpagesize() { return sysconf(_SC_PAGESIZE); } - -// These were accidentally declared in because we stupidly used to inline -// getpagesize() and __getpageshift(). Needed for backwards compatibility with old NDK apps. -extern "C" { - unsigned int __page_size = PAGE_SIZE; - unsigned int __page_shift = PAGE_SHIFT; -} diff --git a/libc/bionic/wait.cpp b/libc/bionic/wait.cpp index 27453bbc3..cd75c101c 100644 --- a/libc/bionic/wait.cpp +++ b/libc/bionic/wait.cpp @@ -47,8 +47,3 @@ int waitid(idtype_t which, id_t id, siginfo_t* info, int options) { // The system call takes an optional struct rusage that we don't need. return __waitid(which, id, info, options, NULL); } - -// TODO: remove this backward compatibility hack (for jb-mr1 strace binaries). -extern "C" pid_t __wait4(pid_t pid, int* status, int options, struct rusage* rusage) { - return wait4(pid, status, options, rusage); -}