generic-library/bionic
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

libc_logging: Set SOCK_CLOEXEC on socket

Browse Source 
Socket file descriptors remain open across exec unless
SOCK_CLOEXEC is set. Enable this option, to avoid leaking
file descriptors.

In practice, this isn't a big deal, since the socket only remains
open for a very short period to write a message. However, this
socket might leak for for multithreaded programs if an exec occurs
between the open and close.

Change-Id: Ica2e71fe28657c32d56de1431c8f7f1f5c7b7c58
This commit is contained in:
Nick Kralevich 2014-07-02 22:39:14 -07:00
parent 1f262b35fe
commit bae5b1dbd8
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libc/bionic/libc_logging.cpp
View File

@ -453,7 +453,7 @@ static int __libc_open_log_socket()
// found that all logd crashes thus far have had no problem stuffing // found that all logd crashes thus far have had no problem stuffing
// the UNIX domain socket and moving on so not critical *today*. // the UNIX domain socket and moving on so not critical *today*.
int log_fd = TEMP_FAILURE_RETRY(socket(PF_UNIX, SOCK_DGRAM, 0)); int log_fd = TEMP_FAILURE_RETRY(socket(PF_UNIX, SOCK_DGRAM | SOCK_CLOEXEC, 0));
if (log_fd < 0) { if (log_fd < 0) {
return -1; return -1;
} }