generic-library/bionic
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

am 100d6784: am 53ddcc90: Merge "linker: Emit a warning on text relocations"

Browse Source 
* commit '100d678438f222ad6ef8f3dc0646911b218c50a9':
  linker: Emit a warning on text relocations
This commit is contained in:
Nick Kralevich 2013-06-21 16:01:02 -07:00 committed by Android Git Automerger
commit ae9353387d
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
linker/linker.cpp
View File

@ -1533,6 +1533,8 @@ static bool soinfo_link_image(soinfo* si) {
* phdr_table_protect_segments() after all of them are applied * phdr_table_protect_segments() after all of them are applied
* and all constructors are run. * and all constructors are run.
*/ */
DL_WARN("%s has text relocations. This is wasting memory and is "
"a security risk. Please fix.", si->name);
if (phdr_table_unprotect_segments(si->phdr, si->phnum, si->load_bias) < 0) { if (phdr_table_unprotect_segments(si->phdr, si->phnum, si->load_bias) < 0) {
DL_ERR("can't unprotect loadable segments for \"%s\": %s", DL_ERR("can't unprotect loadable segments for \"%s\": %s",
si->name, strerror(errno)); si->name, strerror(errno));