am 100d6784: am 53ddcc90: Merge "linker: Emit a warning on text relocations"

* commit '100d678438f222ad6ef8f3dc0646911b218c50a9': linker: Emit a warning on text relocations
2013-06-21 16:01:02 -07:00 · 2013-06-21 16:01:02 -07:00 · ae9353387d
commit ae9353387d
parent cf3c9ce0f5 100d678438
1 changed files with 2 additions and 0 deletions
--- a/linker/linker.cpp
+++ b/linker/linker.cpp
@ -1533,6 +1533,8 @@ static bool soinfo_link_image(soinfo* si) {
         * phdr_table_protect_segments() after all of them are applied
         * and all constructors are run.
         */
+        DL_WARN("%s has text relocations. This is wasting memory and is "
+                "a security risk. Please fix.", si->name);
        if (phdr_table_unprotect_segments(si->phdr, si->phnum, si->load_bias) < 0) {
            DL_ERR("can't unprotect loadable segments for \"%s\": %s",
                   si->name, strerror(errno));