From ca10ac6dd45f73752e8822fee606d83116a5721a Mon Sep 17 00:00:00 2001 From: Dmitriy Ivanov Date: Thu, 28 May 2015 11:44:31 -0700 Subject: [PATCH] Improve some of error/warning messages Bug: http://b/20464031 Change-Id: I948141c46f9e054fc45f5934153dee56ce3cd558 (cherry picked from commit 087005f37e02b48809746947159d824493885b1e) --- linker/linker.cpp | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/linker/linker.cpp b/linker/linker.cpp index e8bebff63..764b5cc5f 100644 --- a/linker/linker.cpp +++ b/linker/linker.cpp @@ -331,6 +331,7 @@ static bool realpath_fd(int fd, std::string* realpath) { std::vector buf(PATH_MAX), proc_self_fd(PATH_MAX); snprintf(&proc_self_fd[0], proc_self_fd.size(), "/proc/self/fd/%d", fd); if (readlink(&proc_self_fd[0], &buf[0], buf.size()) == -1) { + PRINT("readlink('%s') failed: %s [fd=%d]", &proc_self_fd[0], strerror(errno), fd); return false; } @@ -1287,7 +1288,7 @@ static soinfo* load_library(int fd, off64_t file_offset, std::string realpath = name; if (!realpath_fd(fd, &realpath)) { - PRINT("cannot resolve realpath for the library \"%s\": %s", name, strerror(errno)); + PRINT("warning: unable to get realpath for the library \"%s\". Will use given name.", name); realpath = name; } @@ -2761,7 +2762,7 @@ bool soinfo::prelink_image() { set_dt_flags_1(d->d_un.d_val); if ((d->d_un.d_val & ~SUPPORTED_DT_FLAGS_1) != 0) { - DL_WARN("Unsupported flags DT_FLAGS_1=%p", reinterpret_cast(d->d_un.d_val)); + DL_WARN("%s: unsupported flags DT_FLAGS_1=%p", get_realpath(), reinterpret_cast(d->d_un.d_val)); } break; #if defined(__mips__)