generic-library/bionic
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Implement __fsetlocking.

Browse Source 
The old __isthreaded hack was never very useful on Android because all user
code runs in a VM where there are lots of threads running. But __fsetlocking
lets a caller say "I'll worry about the locking for this FILE*", which is
useful for the normal case where you don't share a FILE* between threads
so you don't need any locking.

Bug: 17154740
Bug: 18593728
Change-Id: I2a8dddc29d3edff39a3d7d793387f2253608a68d
This commit is contained in:
Elliott Hughes
2015-01-20 18:09:05 -08:00
parent f374358414
commit 8c4994bbc1
5 changed files with 41 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
tests/stdio_ext_test.cpp
View File

@@ -133,7 +133,10 @@ TEST(stdio_ext, __freadable__fwritable) {
TEST(stdio_ext, __fsetlocking) {
FILE* fp = fopen("/proc/version", "r");
// Android doesn't actually support the other modes.
ASSERT_EQ(FSETLOCKING_INTERNAL, __fsetlocking(fp, FSETLOCKING_QUERY));
ASSERT_EQ(FSETLOCKING_INTERNAL, __fsetlocking(fp, FSETLOCKING_BYCALLER));
ASSERT_EQ(FSETLOCKING_BYCALLER, __fsetlocking(fp, FSETLOCKING_QUERY));
ASSERT_EQ(FSETLOCKING_BYCALLER, __fsetlocking(fp, FSETLOCKING_INTERNAL));
ASSERT_EQ(FSETLOCKING_INTERNAL, __fsetlocking(fp, FSETLOCKING_QUERY));
fclose(fp);
}